Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220823055739.1451419-1-floridsleeves@gmail.com> <YwRyC93rC/BAjR23@kroah.com>
In-Reply-To: <YwRyC93rC/BAjR23@kroah.com>
From:   Li Zhong <floridsleeves@gmail.com>
Date:   Fri, 26 Aug 2022 01:29:12 -0700
Message-ID: <CAMEuxRrLXov-brDL4ENyHS=1Yjd2YE0bGNHZ69p9wmuBQo9avQ@mail.gmail.com>
Subject: Re: [PATCH v1] drivers/tty/serial: check the return value of uart_port_check()
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
        jirislaby@kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Aug 22, 2022 at 11:22 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Mon, Aug 22, 2022 at 10:57:39PM -0700, lily wrote:
> > uart_port_check() can return NULL pointer. Check its return value
> > before dereference it.
>
> Also, how did you find this issue?
>
> >
> > Signed-off-by: Li Zhong <floridsleeves@gmail.com>
>
> Also, your From: name does not match this one, so I can't take the patch
> even if it is ok :(
>
> Please do initial kernel work in drivers/staging/ to get issues like
> this fixed up before moving to other portions of the kernel so that
> basic email problems do not bother other subsystem maintainers.
>
Thanks for the suggestions! I'll correct the From: in my v2 patch.

> thanks,
>
> greg k-h
>
>