Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 26 Aug 2022 10:27:17 +0200
From:   Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
To:     Ming Qian <ming.qian@nxp.com>
Cc:     "mchehab@kernel.org" <mchehab@kernel.org>,
        "hverkuil-cisco@xs4all.nl" <hverkuil-cisco@xs4all.nl>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        "X.H. Bao" <xiahong.bao@nxp.com>,
        "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
Subject: Re: [EXT] Re: [PATCH v5 2/4] media: amphion: tell and handle
 contiguous and non contiguous format
Message-ID: <20220826082717.GB3151@tom-ThinkPad-T14s-Gen-2i>
References: <cover.1661390673.git.ming.qian@nxp.com>
 <7e6a945b898254679bd93e7e001e7c24b5aea0ef.1661390673.git.ming.qian@nxp.com>
 <20220826072047.GA3151@tom-ThinkPad-T14s-Gen-2i>
 <AM6PR04MB634128ED70894F35B629C69AE7759@AM6PR04MB6341.eurprd04.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <AM6PR04MB634128ED70894F35B629C69AE7759@AM6PR04MB6341.eurprd04.prod.outlook.com>
Precedence: bulk

Hi Ming,

On Fri, Aug 26, 2022 at 07:47:47AM +0000, Ming Qian wrote:
> [snip]
> 
> >> diff --git a/drivers/media/platform/amphion/vpu_helpers.c
> >> b/drivers/media/platform/amphion/vpu_helpers.c
> >> index e9aeb3453dfc..019c77e84514 100644
> >> --- a/drivers/media/platform/amphion/vpu_helpers.c
> >> +++ b/drivers/media/platform/amphion/vpu_helpers.c
> >> @@ -59,6 +59,36 @@ const struct vpu_format
> >*vpu_helper_find_format(struct vpu_inst *inst, u32 type,
> >>       return NULL;
> >>  }
> >>
> >> +const struct vpu_format *vpu_helper_find_sibling(struct vpu_inst
> >> +*inst, u32 type, u32 pixelfmt) {
> >> +     const struct vpu_format *fmt;
> >> +     const struct vpu_format *sibling;
> >> +
> >> +     fmt = vpu_helper_find_format(inst, type, pixelfmt);
> >> +     if (!fmt || !fmt->sibling)
> >> +             return NULL;
> >> +
> >> +     sibling = vpu_helper_find_format(inst, type, fmt->sibling);
> >> +     if (!sibling || sibling->sibling != fmt->pixfmt ||
> >> +         sibling->comp_planes != fmt->comp_planes)
> >> +             return NULL;
> >
> >I think to preserve code style you need the following solutions on this if
> >statement:
> >
> >if (!sibling || (sibling->sibling != fmt->pixfmt) ||
> >    (sibling->comp_planes != fmt->comp_planes))
> >         return NULL;
> >
> >I think I have suggested to you this solution on the v4. But never mind we
> >need this :)
> >
> >Thanks
> >
> 
> Hi Tommaso,
>     The parentheses are unnecessary, the checkpatch.pl will report the following style problems if I add the parentheses:
> 
> CHECK: Unnecessary parentheses around 'sibling->sibling != fmt->pixfmt'
> #11: FILE: drivers/media/platform/amphion/vpu_helpers.c:72:
> +       if (!sibling || (sibling->sibling != fmt->pixfmt) ||
> +           (sibling->comp_planes != fmt->comp_planes))
> 
> CHECK: Unnecessary parentheses around 'sibling->comp_planes != fmt->comp_planes'
> #11: FILE: drivers/media/platform/amphion/vpu_helpers.c:72:
> +       if (!sibling || (sibling->sibling != fmt->pixfmt) ||
> +           (sibling->comp_planes != fmt->comp_planes))
> 
> total: 0 errors, 0 warnings, 2 checks, 10 lines checked
> 
> NOTE: For some of the reported defects, checkpatch may be able to
>       mechanically convert to the typical style using --fix or --fix-inplace.
> 
> 1.patch has style problems, please review.
> 
> NOTE: If any of the errors are false positives, please report
>       them to the maintainer, see CHECKPATCH in MAINTAINERS.

Sorry, my bad. I don't check this using checkpatch.pl, but checking the
others driver code, you are right. Thanks for clarify this.

Then, Looks good to me.

Regards,
Tommaso

-- 
Tommaso Merciai
Embedded Linux Engineer
tommaso.merciai@amarulasolutions.com
__________________________________

Amarula Solutions SRL
Via Le Canevare 30, 31100 Treviso, Veneto, IT
T. +39 042 243 5310
info@amarulasolutions.com
www.amarulasolutions.com