Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7927ac6e-7738-822a-59ce-09992947f3b4@redhat.com>
Date:   Fri, 26 Aug 2022 10:57:24 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH -next] sched/deadline: Add start_new_instance helper
Content-Language: en-US
To:     shangxiaojing <shangxiaojing@huawei.com>
Cc:     mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
        vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
        rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
        vschneid@redhat.com, linux-kernel@vger.kernel.org
References: <20220826031521.13391-1-shangxiaojing@huawei.com>
 <651dbb96-8d6e-53e9-a99f-0bb12f5b2723@redhat.com>
 <893836a5-0aaa-e5e6-81ba-cc9570b9a026@huawei.com>
From:   Daniel Bristot de Oliveira <bristot@redhat.com>
In-Reply-To: <893836a5-0aaa-e5e6-81ba-cc9570b9a026@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 8/26/22 09:40, shangxiaojing wrote:
>> again, this is not a good function name. Maybe, dl_replenish_new_period() ?
> 
> right, i have thought like replenish_new_instance, but when i'm making
> patch,  i was worried that "replenish" is only for ENQUEUE_REPLENISH.

I see, but that is a flag, not the action.

> what about dl_start_new_period? which means a new deadline will be set, rather than

The thing it is doing is replenishing... 

>     dl_se->deadline += pi_of(dl_se)->dl_period;
> 
> in replenish_dl_entity.

that is why I added "new_period"....  so replenish_dl_new_period() to keep the consistency.

>>> +static inline void start_new_instance(struct sched_dl_entity *dl_se, struct rq *rq)
>>>
>>> +{
>>> +    /* for non-boosted task, pi_of(dl_se) == dl_se */
>>> +    dl_se->deadline = rq_clock(rq) + pi_of(dl_se)->dl_deadline;
>>> +    dl_se->runtime = pi_of(dl_se)->dl_runtime;
>>> +}
>>> +
>> -- Daniel 

-- Daniel