Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp165712rwe; Fri, 26 Aug 2022 02:50:29 -0700 (PDT) X-Google-Smtp-Source: AA6agR7LyzAJA0vBhF0ByLNIVgOMB/986dZU+j8ejlYyio8Sf7OkDmOM2IdxPf8abnzGu8CgUHpZ X-Received: by 2002:a63:d84e:0:b0:42b:5834:fd73 with SMTP id k14-20020a63d84e000000b0042b5834fd73mr2573579pgj.506.1661507429610; Fri, 26 Aug 2022 02:50:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661507429; cv=none; d=google.com; s=arc-20160816; b=tSopjxxUrqR0WZary7KPdTQnwPSBkZENmI8i1XpzsOkvHEN2LRimctCBAkX6pjmDin eIr/Dsy2JpiCCvpK8lcPoBQrrwKTXyEPFyyDwehAtUI71uGBrEfBE/WyjMtBllhm7emd cq9RzioBu5zrjMJ5n7kXaj9xngxinX4XjkL4Pvho3GCTDC6uVa9/bEEm9Kb6k1fQONGB 7FWJeJkzAMMbw/agymkp4kjKzMwF8lZzmvxcfFm6pvi9wFicDWOKmO81BhvlE3Nyuqme GhdiPrrE61lNBy08LavnzmwO2P365Lbbq/u3qZ8bd4onxYce408UQF4kPnV9R01SZfSm 4u1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=9gvdPpfWhML/QsrMl+pD+HweNQ2GBnbJdkoZ5Iv84OE=; b=IDI4iHwKif0vYTe8zXFlYsfOvRvZXeYiksG02pYR4r1HSg3d8RIwkIt8igX9t1BvIM hh+uPVIPb3jacqAzoSn6nvUMf1s4Y/EshsHN8e42RQRLpVIEdT5hv0aQjXnAvB5YS7N9 4rSormNNSYtOOTQ9/fxbmUL/mdMw9krLon01PuRmTzCsSftd2mJUGqmx647sXrzIAHfZ g6lW0JG8ctcCMsV/5WVl21XEYrcwwVNdf5UnfCW9Th+0QXuLt1C0fiu9K8ZRlvYyfptV 6sK3qJmXsLW6FgkV0smSCZaVGMkvnmTboaxL/9n9HpTn33bug5j7GLp2urPW//zvLhcD syTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@foss.st.com header.s=selector1 header.b=IlHC48Br; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=foss.st.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h13-20020a170902f70d00b00174402831aesi622799plo.259.2022.08.26.02.50.16; Fri, 26 Aug 2022 02:50:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@foss.st.com header.s=selector1 header.b=IlHC48Br; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=foss.st.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245588AbiHZJTY (ORCPT + 99 others); Fri, 26 Aug 2022 05:19:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240799AbiHZJTW (ORCPT ); Fri, 26 Aug 2022 05:19:22 -0400 Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19BC5D741B; Fri, 26 Aug 2022 02:19:21 -0700 (PDT) Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 27Q8XnIa002217; Fri, 26 Aug 2022 11:19:04 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=selector1; bh=9gvdPpfWhML/QsrMl+pD+HweNQ2GBnbJdkoZ5Iv84OE=; b=IlHC48Br61AxoVupam3KG+mMws0m+4cuyJJuqO6jZaumyW1J63/3QX/ztiGEinlX3D5x eqzvb0PwBgphdSI/lmaQYfzOKFzd04VDFCKqf5Tv4pXwCj/UtpH+2GUA7ay9THduvBJ/ uZlOWjd4Esx1e35VPX+35kk91pBFSJ2OPxopUQsnIzkQb6lf/ZCsWpIFFxbTqaz/HUuA Ez7VeImJ8GRGI84bmjnq/kf3sxAgLfHQfnFfZAtIfhLs/07It/WmOXm5MpTl0gzfOjES uLCrk09mcekEk2IwvEeHFe+P3cLt7WBbcWeQQFO7OCjboWGPY9mVNWCtfDj9jli5L5uR pw== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3j5h4wn6g9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 26 Aug 2022 11:19:04 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 172CE10002A; Fri, 26 Aug 2022 11:19:03 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 90099217B72; Fri, 26 Aug 2022 11:19:03 +0200 (CEST) Received: from localhost (10.75.127.119) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.20; Fri, 26 Aug 2022 11:19:03 +0200 From: To: Mark Brown CC: , , , , , , Dan Carpenter Subject: spi: stm32-qspi: Fix stm32_qspi_transfer_one_message() error path Date: Fri, 26 Aug 2022 11:18:51 +0200 Message-ID: <20220826091851.1393266-1-patrice.chotard@foss.st.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.75.127.119] X-ClientProxiedBy: GPXDAG2NODE5.st.com (10.75.127.69) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-26_04,2022-08-25_01,2022-06-22_01 X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Patrice Chotard The patch a557fca630cc: "spi: stm32_qspi: Add transfer_one_message() spi callback" from Aug 23, 2022, leads to the following Smatch static checker warning: drivers/spi/spi-stm32-qspi.c:627 stm32_qspi_transfer_one_message() error: uninitialized symbol 'ret'.Fix the following Smatch static checker warning: Fixes: a557fca630cc ("spi: stm32_qspi: Add transfer_one_message() spi callback") Reported-by: Dan Carpenter Signed-off-by: Patrice Chotard --- drivers/spi/spi-stm32-qspi.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-stm32-qspi.c b/drivers/spi/spi-stm32-qspi.c index 92459daca95f..679fd1c34f7e 100644 --- a/drivers/spi/spi-stm32-qspi.c +++ b/drivers/spi/spi-stm32-qspi.c @@ -562,7 +562,7 @@ static int stm32_qspi_transfer_one_message(struct spi_controller *ctrl, struct spi_transfer *transfer; struct spi_device *spi = msg->spi; struct spi_mem_op op; - int ret; + int ret = 0; if (!spi->cs_gpiod) return -EOPNOTSUPP; @@ -592,8 +592,10 @@ static int stm32_qspi_transfer_one_message(struct spi_controller *ctrl, dummy_bytes = transfer->len; /* if happens, means that message is not correctly built */ - if (list_is_last(&transfer->transfer_list, &msg->transfers)) + if (list_is_last(&transfer->transfer_list, &msg->transfers)) { + ret = -EINVAL; goto end_of_transfer; + } transfer = list_next_entry(transfer, transfer_list); } -- 2.25.1