Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Divya.Koppera@microchip.com>
To:     <michael@walle.cc>
CC:     <UNGLinuxDriver@microchip.com>, <andrew@lunn.ch>,
        <davem@davemloft.net>, <edumazet@google.com>,
        <hkallweit1@gmail.com>, <kuba@kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux@armlinux.org.uk>,
        <netdev@vger.kernel.org>, <pabeni@redhat.com>
Subject: RE: [PATCH net-next] net: phy: micrel: Adding SQI support for lan8814
 phy
Thread-Topic: [PATCH net-next] net: phy: micrel: Adding SQI support for
 lan8814 phy
Thread-Index: AQHYuFmMgzj2knw/J0+AGHw88JSECa3A3vGAgAACdoA=
Date:   Fri, 26 Aug 2022 09:11:21 +0000
Message-ID: <CO1PR11MB477162C762EF35B0E115B952E2759@CO1PR11MB4771.namprd11.prod.outlook.com>
References: <20220825080549.9444-1-Divya.Koppera@microchip.com>
 <20220826084249.1031557-1-michael@walle.cc>
In-Reply-To: <20220826084249.1031557-1-michael@walle.cc>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?QoU12Poe/x/grWGUHYhRX7sQvF07fxPGhuMsEvVRiovGYjgilKvFG/sty/Fh?=
 =?us-ascii?Q?2I0ugeOvFOD/lxLC5MsAl67pF9jq1W1KTsV8RoXdbbVwtRztHjHJp+xVmNRw?=
 =?us-ascii?Q?6B8GNR6umIQ0Ra0j/0Fm5B1TK8lk15Yn5+R90+9N1k2THiQHmczCEZE7lY3P?=
 =?us-ascii?Q?22miXEpg8o5kIZmXIuUcfSFjtE43EE8BRyooa7oW+trPct07P9JHCXxmuwDf?=
 =?us-ascii?Q?sJWxIcilrRE8GduE4mOpA13/FWqRCVOtMbcj8bi/4cUkvRBk12VyMdSjr6nb?=
 =?us-ascii?Q?VH2PBn1n2W7T24Qm6ESOPscd4W7OBehM1mYsqzGG8CfvwEgi2XEk6iTbmj8b?=
 =?us-ascii?Q?zo/uyrcQ6bFPY+x3X51qo5Pf9f8nf5H3R4xnIcZPROVH2GsHc1zjiLPEB3li?=
 =?us-ascii?Q?xQAhzc2B47JQd1LpgMFz6Q7TtIq5S1r39y2mIyfVpFi6TFZSRlys+2odox9m?=
 =?us-ascii?Q?6ouObRhQ6ryD90vLbw6pMA/m/Qn8lIex74EjKubm1f1iF1bI+M+ok1OUcHp7?=
 =?us-ascii?Q?TBWgx4Hb2oh+Vkd+s2cdqSg8aNPPw1TsMFrbuYDLS9cCWiP31wfg2TH+82v4?=
 =?us-ascii?Q?oiM5AnU8zUUdmxdid43tEU+zOg7saaIA8pCgNamcqbMZOEXZmnKbNiUUAZaA?=
 =?us-ascii?Q?Qtjhp93uxb562x2S958JYSFkXnYQII2tvTukVBpW0YQ9O57vyROhqNweRJdC?=
 =?us-ascii?Q?b6fQLTvYUXWfY5e0/ODSJuUasYC91v6r6pZOcMcOkqdrk9+Mymqu87/Pn2d2?=
 =?us-ascii?Q?kaDo4Djvj/9yQRus9iATxOTscLdpTcgtnExy3JU8quhVAqm+Qr/X9smCKTRX?=
 =?us-ascii?Q?SoYQWzZVA57NwUbHK9RTFK4w73IWu1pGasK5ZTAbYUnKBnQd95Ba9QMvkWud?=
 =?us-ascii?Q?yBfW7G1+o4kjaoS+gdc+1x5YuglCsXdkAF6xOj4rOATHXp9qi1NTZOSKIpy3?=
 =?us-ascii?Q?B8ixUfcZYHoD+yKW4DPeYwjKP/DDQVg8xQM7Rwh1gErGg2VBfZV9ntxekm5o?=
 =?us-ascii?Q?JsxkJcPCCJ3ygtVr8LZIbYCa8HIktYucQbOes3iBmXt+7cXDFxsTv9BDPLub?=
 =?us-ascii?Q?3eGWjGvwbwMOILypKhVjjRJkfAxuSBFZXnT21DVVey/dJkn3rOqt1Kr8jOpJ?=
 =?us-ascii?Q?5XruvTlY3qechPTFezh/83CaOcREBOz0eMhf2DpozjAMFFMiwIvzVZ84IcMu?=
 =?us-ascii?Q?0bRjTy20R26fLTNIkUTcSrE6Q/SK9z01gsi8NxkHSGECI3/L7ZUNcGmg09+B?=
 =?us-ascii?Q?XUEJOq/dWfFnrk1kH0AVR+Y71ls3sZ27vzvHzCdatOSKjiQwjmo1YInNmQ0x?=
 =?us-ascii?Q?TaxUuld21hcVrmiFnNEflixj4c5u4uYIO92nfxjw8BqUz1mrSE92G/J4SJZ9?=
 =?us-ascii?Q?lbYQf5adjXd0LizqoP/k9b5GZNFhdoGJhxUOf/L5lkHCKuF3lMaOxz7naMES?=
 =?us-ascii?Q?S9AcTgMdWnywjO23w7f2rr8khKlAqrUL7rqx7Mt8wjm5xO/ix3GOOGnZPBgp?=
 =?us-ascii?Q?xqi0Y7yvhkT4de4agG7aYbmjQt/e129OHb15a3JNDUfsorGPktDUJOXJruNW?=
 =?us-ascii?Q?Ovi8tdr1KPOUgGNgauBkcd+TknIQTEEojijaHonyfLH2d0C9MzzM0+paluCx?=
 =?us-ascii?Q?Bw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4771.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7a204ad2-be42-43de-eca0-08da8742f17b
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Aug 2022 09:11:21.5055
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: mlAPqqRkhkNMU+mv7gVrcL0YOMKnFPxXqx5uqZvK0mxZb9Ofn6CWt9Kni5w1Q9cvx2Uc6uANx+5xpRyzDqVHA7oico+ueffrpDJHt0fgl0A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1660
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Michael,

> -----Original Message-----
> From: Michael Walle <michael@walle.cc>
> Sent: Friday, August 26, 2022 2:13 PM
> To: Divya Koppera - I30481 <Divya.Koppera@microchip.com>
> Cc: UNGLinuxDriver <UNGLinuxDriver@microchip.com>; andrew@lunn.ch;
> davem@davemloft.net; edumazet@google.com; hkallweit1@gmail.com;
> kuba@kernel.org; linux-kernel@vger.kernel.org; linux@armlinux.org.uk;
> netdev@vger.kernel.org; pabeni@redhat.com; Michael Walle
> <michael@walle.cc>
> Subject: Re: [PATCH net-next] net: phy: micrel: Adding SQI support for
> lan8814 phy
>=20
> EXTERNAL EMAIL: Do not click links or open attachments unless you know th=
e
> content is safe
>=20
> Hi,
>=20
> > Supports SQI(Signal Quality Index) for lan8814 phy, where it has SQI
> > index of 0-7 values and this indicator can be used for cable integrity
> > diagnostic and investigating other noise sources.
> >
> > Signed-off-by: Divya Koppera <Divya.Koppera@microchip.com>
> > ---
> >  drivers/net/phy/micrel.c | 35 +++++++++++++++++++++++++++++++++++
> >  1 file changed, 35 insertions(+)
> >
> > diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index
> > e78d0bf69bc3..3775da7afc64 100644
> > --- a/drivers/net/phy/micrel.c
> > +++ b/drivers/net/phy/micrel.c
> > @@ -1975,6 +1975,13 @@ static int ksz886x_cable_test_get_status(struct
> phy_device *phydev,
> >  #define LAN8814_CLOCK_MANAGEMENT                     0xd
> >  #define LAN8814_LINK_QUALITY                         0x8e
> >
> > +#define LAN8814_DCQ_CTRL                             0xe6
> > +#define LAN8814_DCQ_CTRL_READ_CAPTURE_                       BIT(15)
>=20
> Why does it end with an underscore?
>=20

All LAN8814 Macros that carries bit numbers are ending with _ in this drive=
r. So following same.

> > +#define LAN8814_DCQ_CTRL_CHANNEL_MASK                        GENMASK(1=
,
> 0)
> > +#define LAN8814_DCQ_SQI                                      0xe4
> > +#define LAN8814_DCQ_SQI_MAX                          7
> > +#define LAN8814_DCQ_SQI_VAL_MASK                     GENMASK(3, 1)
> > +
> >  static int lanphy_read_page_reg(struct phy_device *phydev, int page,
> > u32 addr)  {
> >       int data;
> > @@ -2927,6 +2934,32 @@ static int lan8814_probe(struct phy_device
> *phydev)
> >       return 0;
> >  }
> >
> > +static int lan8814_get_sqi(struct phy_device *phydev) {
> > +     int rc, val;
> > +
> > +     val =3D lanphy_read_page_reg(phydev, 1, LAN8814_DCQ_CTRL);
> > +     if (val < 0)
> > +             return val;
> > +
> > +     val &=3D ~LAN8814_DCQ_CTRL_CHANNEL_MASK;
>=20
> I do have a datasheet for this PHY, but it doesn't mention 0xe6 on EP1.

This register values are present in GPHY hard macro as below

4.2.225	DCQ Control Register
Index (In Decimal):	EP 1.230	Size:	16 bits

Can you give me the name of the datasheet which you are following, so that =
I'll check and let you know the reason.

> So I can only guess that this "channel mask" is for the 4 rx/tx pairs on =
GbE?

Yes channel mask is for wire pair.

> And you only seem to evaluate one of them. Is that the correct thing to d=
o
> here?
>=20

I found in below link is that, get_SQI returns sqi value for 100 base-t1 ph=
y's
https://lore.kernel.org/netdev/20200519075200.24631-2-o.rempel@pengutronix.=
de/T/

In lan8814 phy only channel 0 is used for 100base-tx. So returning SQI valu=
e for channel 0.

> -michael
>=20
>=20
> > +     val |=3D LAN8814_DCQ_CTRL_READ_CAPTURE_;
> > +     rc =3D lanphy_write_page_reg(phydev, 1, LAN8814_DCQ_CTRL, val);
> > +     if (rc < 0)
> > +             return rc;
> > +
> > +     rc =3D lanphy_read_page_reg(phydev, 1, LAN8814_DCQ_SQI);
> > +     if (rc < 0)
> > +             return rc;
> > +
> > +     return FIELD_GET(LAN8814_DCQ_SQI_VAL_MASK, rc); }