Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220825111715.3025694-1-sakari.ailus@linux.intel.com>
In-Reply-To: <20220825111715.3025694-1-sakari.ailus@linux.intel.com>
From:   Ard Biesheuvel <ardb@kernel.org>
Date:   Fri, 26 Aug 2022 12:14:45 +0200
Message-ID: <CAMj1kXFVnZzmYN46d0YB8ieri4vEPz49ufw1FvQ19GT+cQ+wLw@mail.gmail.com>
Subject: Re: [PATCH 1/1] acpi: Remove default association from integer maximum values
To:     Sakari Ailus <sakari.ailus@linux.intel.com>
Cc:     linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
        sbinding@opensource.cirrus.com, andriy.shevchenko@intel.com,
        patches@opensource.cirrus.com, rafael@kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, 25 Aug 2022 at 13:17, Sakari Ailus <sakari.ailus@linux.intel.com> wrote:
>
> Remove the default association from integer maximum value checks. It is
> not necessary and has caused a bug in other associations being unnoticed.
>
> Fixes: 923044133367 ("ACPI: property: Unify integer value reading functions")
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>

Acked-by: Ard Biesheuvel <ardb@kernel.org>

> ---
>  drivers/acpi/property.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/property.c b/drivers/acpi/property.c
> index 91d0e75859d37..d4c168ce428ca 100644
> --- a/drivers/acpi/property.c
> +++ b/drivers/acpi/property.c
> @@ -1046,8 +1046,7 @@ static int acpi_data_prop_read_single(const struct acpi_device_data *data,
>                                                                 u8 *: U8_MAX, \
>                                                                 u16 *: U16_MAX, \
>                                                                 u32 *: U32_MAX, \
> -                                                               u64 *: U64_MAX, \
> -                                                               default: 0U)) { \
> +                                                               u64 *: U64_MAX)) { \
>                                 ret = -EOVERFLOW;                       \
>                                 break;                                  \
>                         }                                               \
> --
> 2.30.2
>