Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220826101523.79502-1-jinpu.wang@ionos.com> <50bfdb3f-f6fe-b0ef-4214-5d533d45e89c@wanadoo.fr>
In-Reply-To: <50bfdb3f-f6fe-b0ef-4214-5d533d45e89c@wanadoo.fr>
From:   Jinpu Wang <jinpu.wang@ionos.com>
Date:   Fri, 26 Aug 2022 12:39:24 +0200
Message-ID: <CAMGffE=Gg=h5mSAQojhtmp64aT0XZzCJskfR+AbYGh9D4Ob-XA@mail.gmail.com>
Subject: Re: [PATCH] intel_th: Fix dma_map_sg error check
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Aug 26, 2022 at 12:31 PM Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
>
> Le 26/08/2022 =C3=A0 12:15, Jack Wang a =C3=A9crit :
> > dma_map_sg return 0 on error.
> >
> > Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> > Cc: linux-kernel@vger.kernel.org
> > Fixes: 4e0eaf239fb3 ("intel_th: msu: Fix single mode with IOMMU")
> > Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
> > ---
> >   drivers/hwtracing/intel_th/msu.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/hwtracing/intel_th/msu.c b/drivers/hwtracing/intel=
_th/msu.c
> > index 6c8215a47a60..b49237d56a60 100644
> > --- a/drivers/hwtracing/intel_th/msu.c
> > +++ b/drivers/hwtracing/intel_th/msu.c
> > @@ -931,7 +931,7 @@ static int msc_buffer_contig_alloc(struct msc *msc,=
 unsigned long size)
> >
> >       ret =3D dma_map_sg(msc_dev(msc)->parent->parent, msc->single_sgt.=
sgl, 1,
> >                        DMA_FROM_DEVICE);
> > -     if (ret < 0)
> > +     if (!ret)
>
> Missing ret =3D -EIO?
> like in other patches?
oh, right, thx for catching it.
sent v2 patch.
>
> CJ
>
> >               goto err_free_pages;
> >
> >       msc->nr_pages =3D nr_pages;
>