Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp223597rwe; Fri, 26 Aug 2022 04:02:03 -0700 (PDT) X-Google-Smtp-Source: AA6agR6Rhal2ZTneh49hE52IvXhhxjgh4qKV12qeVIxZHChi/Oc/ZX0FgZc0Pq1lYnyCtkGY4FcV X-Received: by 2002:a17:907:8a1a:b0:731:6475:68f7 with SMTP id sc26-20020a1709078a1a00b00731647568f7mr5019896ejc.359.1661511723628; Fri, 26 Aug 2022 04:02:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661511723; cv=none; d=google.com; s=arc-20160816; b=nm+XZaV5/szMlJ2T154V22JzUbpVEbhj2jZSkF33wJpnkGzoY3/yDziXw0wDHLJwzq zhoGSULySb9SWTdBXn3KjiBkKvm+u/4L7anl+4vHgvIt4tX03YsKlGFRRvm5mVwYRSC9 9lNRJkoALmuTHOU425TzozjeqNjQZrCiyqZ8+6TSSWLaq27XCOOGQ8ofRZwxxVFxAw9+ aX63UqgeW3FRNfNhOuO/GhdroVd4LomVjhmJnUgw2jAAIHH4x+7O8mDH+Jwam96yYiUZ kPiLFK6LbXElLwq2euJ2GnpNpFmEAO7I5BKP3Z49HPvVJXQWJgiUzMcMConvHYZi9PXB wA6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=8wxqs5XsLps0afC5KBsbgrTkoAm6TP0SK3rkHHly3y4=; b=tPcol+9Lcel+WF2T4o3jZuKp5YmGtcjwXu2WvZ2bu42QOBcEBHWu9budjDEwDx4/YQ H/ia/pRvUy7Te+TvB6FQMc+GojM7yD/3zrLCiHOCxWzJisCM9nPZcu4nw6x7g2W0EaJR JTx9pyrLnWdTdM2Mz806u5fIDmFDjqnMJ8BNjYTwtpJxdQOBODTN6XLbZrm/3bdsCf+B EDOACpav2GvimQ7znkf7861vY8ZmjYjODWqRaI/KOAiSA1Ho2KzpA+CRXbBj5pTzJWzL Dm13Gb3he6cBFE3bWU6Cne8XH5STMJxEuNwVsDnWD447GgOzW7gurvHayw+qi5pFWgh3 T7Zw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cs11-20020a170906dc8b00b0073d67a50114si1162800ejc.916.2022.08.26.04.01.34; Fri, 26 Aug 2022 04:02:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344169AbiHZK5O (ORCPT + 99 others); Fri, 26 Aug 2022 06:57:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344046AbiHZK4z (ORCPT ); Fri, 26 Aug 2022 06:56:55 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 259AA61B08 for ; Fri, 26 Aug 2022 03:56:54 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oRX0x-0002vN-FK; Fri, 26 Aug 2022 12:56:39 +0200 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1oRX0w-0024ZI-79; Fri, 26 Aug 2022 12:56:38 +0200 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1oRX0t-00GB3V-J7; Fri, 26 Aug 2022 12:56:35 +0200 From: Oleksij Rempel To: Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Oleksij Rempel , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH net-next v4 11/17] net: dsa: microchip: ksz9477: remove MII_CTRL1000 check from ksz9477_w_phy() Date: Fri, 26 Aug 2022 12:56:28 +0200 Message-Id: <20220826105634.3855578-12-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220826105634.3855578-1-o.rempel@pengutronix.de> References: <20220826105634.3855578-1-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The reason why PHYlib may access MII_CTRL1000 on the chip without GBit support is only if chip provides wrong information about extended caps register. This issue is now handled by ksz9477_r_phy_quirks() With proper regmap_ranges provided for all chips we will be able to catch this kind of bugs any way. So, remove this sanity check. Signed-off-by: Oleksij Rempel Reviewed-by: Vladimir Oltean --- drivers/net/dsa/microchip/ksz9477.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/dsa/microchip/ksz9477.c b/drivers/net/dsa/microchip/ksz9477.c index fb9de6b447b12..f0c81d90c99f4 100644 --- a/drivers/net/dsa/microchip/ksz9477.c +++ b/drivers/net/dsa/microchip/ksz9477.c @@ -341,10 +341,6 @@ int ksz9477_w_phy(struct ksz_device *dev, u16 addr, u16 reg, u16 val) if (addr >= dev->phy_port_cnt) return 0; - /* No gigabit support. Do not write to this register. */ - if (!dev->info->gbit_capable[addr] && reg == MII_CTRL1000) - return -ENXIO; - return ksz_pwrite16(dev, addr, 0x100 + (reg << 1), val); } -- 2.30.2