Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp226315rwe; Fri, 26 Aug 2022 04:03:53 -0700 (PDT) X-Google-Smtp-Source: AA6agR4npeWrhikENM46wcj1y42MCPZ0OhgwFYe3JXt7Y0ooq7RHNQxIUwwVlSJ86Mp7CWtKJT94 X-Received: by 2002:a17:907:87b0:b0:731:36ab:3223 with SMTP id qv48-20020a17090787b000b0073136ab3223mr5116070ejc.715.1661511833655; Fri, 26 Aug 2022 04:03:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661511833; cv=none; d=google.com; s=arc-20160816; b=z8joheVDozdyGbLDZ36rFysp4iq8P39o2klOVkaJRcfkhmJGSYRtHZSBqewRJzVkep fonsgoghhAYoGlGDJiLqxQgWauhDwo6mImpSD/uz4SGLhguxYeix0HiPqg6V6yQRoyDI y4kWDWarXlPBCIceP1PK8Kr0NQ1SiwW9bwKwAt7/eIRgVVir2KS5Lvnp4S20AGuEHgC0 EyFs7MhgoPCAblpAfpXrhCPyQaAzzNvR9V/OO69dQ3PiUWXyTtUG1ck5KupYA91fTQBe 45kA2xAXL7vaLKJLFuIuPZVWtQkGq1sps816aVOUqPbrzK6zVVgOfyNWgM/tTsXXNaFz jBwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=RkSZPihaYKwqsabMl7bzj5m5ibmkx665ssetTx78zpc=; b=MR8/OFE2OZlQoYGgHVOz6tXy7XDq53b7Bhhp1bQIy+otNICVMjiV4+epl9Tfgb/qUf RRiqaXenbTIbQusOEJJ4pcs4Qjl0BwR05Z1Fd0kfqNTpPICxfNfYWuhqpdt6dS4M08DB cMDW1SlFHwh456kv67mzOJdOSz8ejZ2osDu2lpy63iefuEgV/eJ5EEQvyk3Rpxp5kuil 1OOB0TVgHse25qR7Ctxj0Uh1ov+2eO1z1sgJ26TOo2/EvGDb8SmUDUaDN8Gbbb5pBNvY MYYURhxVuw18O0K9IVoVI5Ll1K+eAwpkGzQZjw68DxS4+Zo+Psjb56dmvXku3IGlt0yC +G1Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ho7-20020a1709070e8700b0073156b6fe1csi1273262ejc.799.2022.08.26.04.03.26; Fri, 26 Aug 2022 04:03:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245432AbiHZK6x (ORCPT + 99 others); Fri, 26 Aug 2022 06:58:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344128AbiHZK5A (ORCPT ); Fri, 26 Aug 2022 06:57:00 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C704F77556 for ; Fri, 26 Aug 2022 03:56:56 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oRX0x-0002ue-3H; Fri, 26 Aug 2022 12:56:39 +0200 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1oRX0w-0024Z9-1b; Fri, 26 Aug 2022 12:56:38 +0200 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1oRX0t-00GB34-HO; Fri, 26 Aug 2022 12:56:35 +0200 From: Oleksij Rempel To: Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Oleksij Rempel , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH net-next v4 08/17] net: dsa: microchip: KSZ9893: do not write to not supported Output Clock Control Register Date: Fri, 26 Aug 2022 12:56:25 +0200 Message-Id: <20220826105634.3855578-9-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220826105634.3855578-1-o.rempel@pengutronix.de> References: <20220826105634.3855578-1-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This issue was detected after adding regmap register access validation. KSZ9893 compatible chips do not have "Output Clock Control Register 0x0103". So, avoid writing to it. Signed-off-by: Oleksij Rempel Reviewed-by: Vladimir Oltean --- drivers/net/dsa/microchip/ksz9477.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/dsa/microchip/ksz9477.c b/drivers/net/dsa/microchip/ksz9477.c index f60ceaf25a66c..fb9de6b447b12 100644 --- a/drivers/net/dsa/microchip/ksz9477.c +++ b/drivers/net/dsa/microchip/ksz9477.c @@ -193,6 +193,11 @@ int ksz9477_reset_switch(struct ksz_device *dev) ksz_write32(dev, REG_SW_PORT_INT_MASK__4, 0x7F); ksz_read32(dev, REG_SW_PORT_INT_STATUS__4, &data32); + /* KSZ9893 compatible chips do not support refclk configuration */ + if (dev->chip_id == KSZ9893_CHIP_ID || + dev->chip_id == KSZ8563_CHIP_ID) + return 0; + data8 = SW_ENABLE_REFCLKO; if (dev->synclko_disable) data8 = 0; -- 2.30.2