Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Huqiang Qin <huqiang.qin@amlogic.com>
Subject: Re: [PATCH] arm64: dts: meson-s4: include meson-s4-gpio.h
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <narmstrong@baylibre.com>, <khilman@baylibre.com>,
        <jbrunet@baylibre.com>, <martin.blumenstingl@googlemail.com>
CC:     <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-amlogic@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Message-ID: <e32a8c39-1e47-cad1-e093-2cabb2dd37a4@amlogic.com>
Date:   Fri, 26 Aug 2022 19:32:37 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Krzysztof,

On 2022/8/25 20:02, Krzysztof Kozlowski wrote:
> Why? We can see what you did here, but commit msg should explain why you
> do it...

Sorry, I didn't describe this commit message clearly.

In the future, meson-s4.dtsi will have some nodes that need
to use the meson-s4-gpio.h file.

e.g.
	(1) Bluetooth enable pin:
		bt_en-gpios = <&gpio GPIOX_17 GPIO_ACTIVE_HIGH>;
	(2) Audio mute pin:
		spk_mute-gpios = <&gpio GPIOH_8 GPIO_ACTIVE_LOW>;
	(3) ...

So, this patch was born.

Best regards,
Huqiang