Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp319543rwe; Fri, 26 Aug 2022 05:47:02 -0700 (PDT) X-Google-Smtp-Source: AA6agR6JAbXQsIXPC0BXpqAymWc1srq4CQ6fYHW6ejK/8pkmNl4MFUzX3Vf6ueQCIf70znYlMpVa X-Received: by 2002:a65:4484:0:b0:42b:2096:1600 with SMTP id l4-20020a654484000000b0042b20961600mr3114080pgq.284.1661518021790; Fri, 26 Aug 2022 05:47:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661518021; cv=none; d=google.com; s=arc-20160816; b=KiSX8ShcHzevbdfBFTFxR87YuLQR5TpyyBpsy3j7L9Lf4AAw5KlUd5u/RsAYgZNZep 6NEZgDTs93CzNQbChDUkNDPdcsTvA7ekph9uDVBQTqa5rn5Lqt0xINsjWQ74fpFKZrog yW0o5b2IO8gre9i01W9JotTSauQa3yy/Rg4tRBmGHsSUpMTxL4461Tgw6lyJCwmeuU4O 16vlSVXDKUeHkhOg5oofhhM+uFoaefAETbXVBcG4WEjzWdssyByOrkae7rDAgn4+RuTK BtP2x2YQ6ukWQLqni4+PTiWjZNT9LttG/zWzBy8X9py/a6uxsoFLeixrg8kRxISEYEMc hCGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=nMtNIpyaxV6n6y1j4kQGb3c6ARKMgnzuDhHNiwEVBA4=; b=ey16Pv1dtBfNM+/mNO3K+ZbpMMxYjVVy5V/rBExUbzs7uMOl6lgwtTTCrk7/hIZq3g yV76KLGexUeM6hlhj3apZh2Q2YXTaMRCBXOuSRdfCHaOAHLf86bvTlor6Rb6+Ibq/eIr zdKcLiSuDiQ24mfVg0FgmBM/BHPTRlV/AA4jKnqcvq96C5fdPNMA0ITXwymGGzwVZPe1 AsYaPjJ9l8Tx3fYnWSrrfHB9/B08Qa9INkO+9OzFszSGMdh3w9Ioq/kwUt+MYdgcqkHM 1VNfWfS45O7OT+n8n0hQvoLTKLFGZ3NJNBHLfk/IdSklWSwnZfdjom2aG6vakan7q1Kc onNQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@friendlyarm-com.20210112.gappssmtp.com header.s=20210112 header.b=NDXiZwcP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r22-20020a17090a941600b001f7283763fesi1734095pjo.44.2022.08.26.05.46.50; Fri, 26 Aug 2022 05:47:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@friendlyarm-com.20210112.gappssmtp.com header.s=20210112 header.b=NDXiZwcP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230141AbiHZMD7 (ORCPT + 99 others); Fri, 26 Aug 2022 08:03:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230305AbiHZMD4 (ORCPT ); Fri, 26 Aug 2022 08:03:56 -0400 Received: from mail-yw1-x112b.google.com (mail-yw1-x112b.google.com [IPv6:2607:f8b0:4864:20::112b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98C66267E for ; Fri, 26 Aug 2022 05:03:55 -0700 (PDT) Received: by mail-yw1-x112b.google.com with SMTP id 00721157ae682-3321c2a8d4cso30481327b3.5 for ; Fri, 26 Aug 2022 05:03:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=friendlyarm-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc; bh=nMtNIpyaxV6n6y1j4kQGb3c6ARKMgnzuDhHNiwEVBA4=; b=NDXiZwcPZjtmeIncwlMtPlhsL6rDiS/IDxaxVsoPMFZbAprw6sE4IhTH1pd7ZBiU8n Lz+K/SwbUm2CzgbeGFBJ4zLa/SMhAKc70eTfAi9+XBUGZ3DIkJUrmn6yMll46vjB0C6v vvp14qIMvKqsiLCGAfO4mGTHJqQOk8t9A+Sdg1RFmsPnJKfYd/L20bU5Q3mTb/sWqyeD VnY2tjHPxu7AntPtHTerHp2KDD6id6NEpy6yuKLhuiY+GHebX1xP6F5ripEBeRvOPnf0 a5Zg2dgJPOPSdBlPgKXMZN60iV52WsjLYLX/F7C2pwCxIPfe75Ff2khcY/rmRoTeLgbM +Q+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc; bh=nMtNIpyaxV6n6y1j4kQGb3c6ARKMgnzuDhHNiwEVBA4=; b=RgkmHf27mRimT1I8xFJSIuM67N8jgtR+VXixPFrP5KlLf1cS3IEIOpvL/3wVjFKmV/ 6feQpHdxmxRHxIMM5toY8YalbWfT+b4EDVej4ktwilizofRwe++QvHM+Z6lmsHRHZ60r ry1GQnXvuJdqGEMj4M7WJR3TZAqZXBAVtHjDikEMx2phXUbi1pZLquaP7kQMETcWoEmH BGWxAYKbG7tnAmQw4dlrCDk7Z7ksdhD9NBv+3kiylTGhB12vBk5d2wMXNWSXl3maSIp7 pDW4qU9AjnBPc9uN9oG2cSrn8pcWip3AeRlGInK8KXnRRMSVPzSdgXIV3Wkr3SWG7QLv SwnA== X-Gm-Message-State: ACgBeo2FvT8VC2jzvrjk/r+9IHf4OPg7SYchfezemzB1hGiuHzbzYxMn UphqpVJTqyr2fNf+Mec5c85lMs/rYGeqB52wwknizw== X-Received: by 2002:a0d:ea90:0:b0:33d:faad:db54 with SMTP id t138-20020a0dea90000000b0033dfaaddb54mr2214939ywe.116.1661515434826; Fri, 26 Aug 2022 05:03:54 -0700 (PDT) MIME-Version: 1.0 References: <20220822074139.3810-1-jensenhuang@friendlyarm.com> <23552842.6Emhk5qWAg@diego> In-Reply-To: From: Jensen Huang Date: Fri, 26 Aug 2022 20:03:43 +0800 Message-ID: Subject: Re: [PATCH] arm64: dts: rockchip: add enable-strobe-pulldown to emmc phy on rk3399 To: Doug Anderson Cc: =?UTF-8?Q?Heiko_St=C3=BCbner?= , Rob Herring , Krzysztof Kozlowski , Vinod Koul , Chris Ruehl , Brian Norris , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , "open list:ARM/Rockchip SoC..." , LKML Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Thanks! I understand that this patch does potentially affect boards with external pull down. To avoid this, I will move `enable-strobe-pulldown` to rk3399-nanopi4.dtsi and send patch v2. BR, Jensen On Wed, Aug 24, 2022 at 10:58 PM Doug Anderson wrot= e: > > Hi, > > On Tue, Aug 23, 2022 at 8:11 PM Jensen Huang > wrote: > > > > Hi, > > > > Sorry for sending an email in HTML format. > > > > I realized that only some devices may be affected, so I considered > > modifying rk3399-nanopi4.dtsi only, > > but other boards without external pull-down should still need this patc= h. > > I guess the other alternative would be to change how the dt property > works. You could say: > > 1. If `enable-strobe-pulldown` is set then enable the strobe pulldown. > > 2. If `enable-strobe-pulldown` is not set then don't touch the pin in > the kernel. > > 3. If someone later needs to explicitly disable the strobe pulldown > they could add a new property like `disable-strobe-pulldown`. > > > Obviously there are tradeoffs between that and what you've done and > I'm happy to let others make the call of which they'd prefer. > > > > BR, > > Jensen > > > > On Tue, Aug 23, 2022 at 10:13 PM Doug Anderson = wrote: > > > > > > Hi, > > > > > > On Tue, Aug 23, 2022 at 4:53 AM Heiko St=C3=BCbner = wrote: > > > > > > > > Am Montag, 22. August 2022, 09:41:39 CEST schrieb Jensen Huang: > > > > > Internal pull-down for strobe line (GRF_EMMCPHY_CON2[9]) was disa= bled > > > > > by commit 8b5c2b45b8f0, which causes I/O error in HS400 mode. > > > > > > > > > > Tested on NanoPC-T4. > > > > > > > > > > Fixes: 8b5c2b45b8f0 ("phy: rockchip: set pulldown for strobe line= in dts") > > > > > Signed-off-by: Jensen Huang > > > > > > > > ok, so this looks like it restores previous functionality. > > > > > > > > I'm just wondering as the "offending" patch is from 2020, why this > > > > only turns up now. Any ideas? > > > > > > Ah, I see. So before the offending patch we used to just leave the > > > pull state at whatever the default was when the kernel was booted. > > > After the offending patch we chose a default. > > > > > > On kevin I see an external pull down on this line. Enabling both the > > > internal and external is probably not a huge deal, it'll just affect > > > the strength of the pull. > > > > > > On bob I _think_ the external pull down is also stuffed. > > > > > > ...so I guess that would explain why it didn't cause a problem for at > > > least those two boards? > > > > > > -Doug