Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <577de16a-0a6c-faa5-54da-2d808451b4e9@baylibre.com>
Date:   Fri, 26 Aug 2022 16:02:52 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.0
Subject: Re: [PATCH v2 1/4] dt-bindings: thermal: mediatek: add binding
 documentation for MT8365 SoC
Content-Language: en-US
To:     Matthias Brugger <matthias.bgg@gmail.com>
Cc:     rafael@kernel.org, fparent@baylibre.com, amitk@kernel.org,
        daniel.lezcano@linaro.org, devicetree@vger.kernel.org,
        krzysztof.kozlowski+dt@linaro.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org,
        robh+dt@kernel.org, rui.zhang@intel.com
References: <20220720181854.547881-1-aouledameur@baylibre.com>
 <20220720181854.547881-2-aouledameur@baylibre.com>
 <59dd19f6-8e20-56d6-506a-93656bf15138@gmail.com>
From:   Amjad Ouled-Ameur <aouledameur@baylibre.com>
In-Reply-To: <59dd19f6-8e20-56d6-506a-93656bf15138@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Matthias,

On 7/21/22 10:57, Matthias Brugger wrote:
>
>
> On 20/07/2022 20:18, Amjad Ouled-Ameur wrote:
>> From: Fabien Parent <fparent@baylibre.com>
>>
>> Add the binding documentation for the thermal support on MT8365 SoC.
>>
>> Signed-off-by: Fabien Parent <fparent@baylibre.com>
>> Acked-by: Amjad Ouled-Ameur <aouledameur@baylibre.com>
>
> I suppose you wanted to add Signed-off-by here, at least 
> get_maintainers.pl doesn't list you.
>
Right, will add my SoB in V3, thank you!

Regards,

Amjad

> Apart from that:
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
>
>> ---
>>   Documentation/devicetree/bindings/thermal/mediatek-thermal.txt | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git 
>> a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
>> b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
>> index 5c7e7bdd029a..ba4ebffeade4 100644
>> --- a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
>> +++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
>> @@ -14,6 +14,7 @@ Required properties:
>>     - "mediatek,mt2712-thermal" : For MT2712 family of SoCs
>>     - "mediatek,mt7622-thermal" : For MT7622 SoC
>>     - "mediatek,mt8183-thermal" : For MT8183 family of SoCs
>> +  - "mediatek,mt8365-thermal" : For MT8365 family of SoCs
>>     - "mediatek,mt8516-thermal", "mediatek,mt2701-thermal : For 
>> MT8516 family of SoCs
>>   - reg: Address range of the thermal controller
>>   - interrupts: IRQ for the thermal controller