Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 26 Aug 2022 11:52:31 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Lu Baolu <baolu.lu@linux.intel.com>
Cc:     Joerg Roedel <joro@8bytes.org>,
        Christoph Hellwig <hch@infradead.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Kevin Tian <kevin.tian@intel.com>,
        Ashok Raj <ashok.raj@intel.com>, Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Jean-Philippe Brucker <jean-philippe@linaro.com>,
        Dave Jiang <dave.jiang@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Vinod Koul <vkoul@kernel.org>,
        Eric Auger <eric.auger@redhat.com>,
        Liu Yi L <yi.l.liu@intel.com>,
        Jacob jun Pan <jacob.jun.pan@intel.com>,
        Zhangfei Gao <zhangfei.gao@linaro.org>,
        Zhu Tony <tony.zhu@intel.com>, iommu@lists.linux.dev,
        linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v12 07/17] iommu: Try to allocate blocking domain when
 probing device
Message-ID: <YwjeL2SVmdRpoWb6@nvidia.com>
References: <20220826121141.50743-1-baolu.lu@linux.intel.com>
 <20220826121141.50743-8-baolu.lu@linux.intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220826121141.50743-8-baolu.lu@linux.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?z8ZrQEqd5dNDbg2ooD7JZNmiE+fhLS0UaGav5YCS+9IVVt1wLUjHdRV/NMSn?=
 =?us-ascii?Q?DosWNeUYX6msUyIJqw6aA+M2EZJMU9usrdBPftY0y+bP2W7uZRHmzasXE8/p?=
 =?us-ascii?Q?61XLuENY+X60prYSvR3+sx/fhf02wuDZAepwpl7k44sr+6ufaHPheFJChXSg?=
 =?us-ascii?Q?1cJP6XbR/NswPgnB7mKL0URwGt19GIfsDQwg0QcOdy/nC/+Yv4D5P+8R/55y?=
 =?us-ascii?Q?T78/UYaLr9TTajr0Balgru11zo9FpuxQMtPzRUGo+UN1ix4aI63S8z0r7Gd1?=
 =?us-ascii?Q?rMuutMqUy3zInr+VEdBMhHjlNEqb6Hm20l6N8Koeqs6Jr63v7xtP/u+ULAx8?=
 =?us-ascii?Q?+fTRLuZfx9j1SM/zrpAh/EV3MqbD4UmyVit6SgQFliKjFn+beUr+wrvvqn3B?=
 =?us-ascii?Q?NhU97oPbFYv8Rm+cO+HxMwN10UvpnR1cAODDQbDymARlr2SKjuqpgAHgOpw7?=
 =?us-ascii?Q?62BwjRbXzDYsVViFoDU9COtaVVQKUTbvBYKDvIbFbLjeaYS8sJQtH17OSIC1?=
 =?us-ascii?Q?XXDQRlqwxoFcjEerip7D6tY8r91NWw9hY7wIbw4q/ZehBAXa+SBOo0MqaNX5?=
 =?us-ascii?Q?wD4TTGCU9iseon24/HydqYFzOmBe1mHY4hXe9M97nmYnEoN+VHPwVdLCJ8p2?=
 =?us-ascii?Q?mYLDDhQE2hF7Q/x2tdJcvaHNFzEqfk3ce+eJTwndurCLThzjCR8beC9Wgv7f?=
 =?us-ascii?Q?cB6nykffMCCf4i0CrZOkbtnWtI5jVWhGiXnnWTKMJvh4Abgs9NEMO5kS5guR?=
 =?us-ascii?Q?g2DxOoppn0sD1CY+In42AH65IW5knodPAon1F4/Vouz6UABaIV70lH8LSqzn?=
 =?us-ascii?Q?b8qkquDZYmv/RYatrKKj/jsuf8NeZtD0khk8CO0UsaV7D3kOEiPipwcG3iqx?=
 =?us-ascii?Q?Zg4+2gvxq4l3IbGJyE0+ci43nqxR1ELME+Ip2ma9B5bn9mXZnhDjjBaoxWCF?=
 =?us-ascii?Q?EfdBCUVGMfDnZvf33ZevK+XY0KcOCgB8YCgjBdPY65H+7aIL8lTucIxWmCN/?=
 =?us-ascii?Q?pehH15OtoWp8ZUIwLJRRTNP9mzcC844lM3EVo28m/3+qYci2R8VEk9j8NJHt?=
 =?us-ascii?Q?oZ03DK82IcN+q/yzKDnc8aIXJAJhVDRZT4EINF5VxkSj2ypaQwQ3tFd0uVCw?=
 =?us-ascii?Q?FktxU71brGZ1FG7zNpcRMOT1nt54Na9z8j2rnuMK8XLVW7uyTlXs9IFRq9Xh?=
 =?us-ascii?Q?ouwIpKC461Xwb7MxDNxMGvSaj0AzhqEo2rYN7TPhQaphuZLUiFW+4KcUitgF?=
 =?us-ascii?Q?PqHwr1FF+N8bINMg6fGIBy3xr4QnNZN2UMXTGEmeHEgGqVhcGREAM1oopG5P?=
 =?us-ascii?Q?20iOZ7G3si52RxD0VoUA1avxlHY2T/G39RPuXa3Vh9fCH7kC8FEKVwD6+bYn?=
 =?us-ascii?Q?RyVksOjwQfjknvAUxs0qlPm+l7/kOr6DabFfv8VXYtB+zdty9NdQaoS7VDMk?=
 =?us-ascii?Q?ekPKb53Y7Aj4voBiet5d/pzoRQhUiUlofBvdS2CT/JJlMoM9lw/uU3M7nW+T?=
 =?us-ascii?Q?KeJY5AsAdEuYdTeGT1EAgSlunRGLuBBzzGvZRZUNdWAC/1SddIaho5ucqNxk?=
 =?us-ascii?Q?ldffmAEmcZlzJKkIf2PRGGOiMSqd+druV+r03b9a?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 65eaa174-8e0f-4504-2838-08da87729b54
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2022 14:52:33.0553
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fl9lpqUDRJF/OJsCVj7hgJARoOFUfwrHc7kcZ2Z1mBjdSRNP1w+DMIEmc0hPdi7/
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3034
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Aug 26, 2022 at 08:11:31PM +0800, Lu Baolu wrote:
> Allocate the blocking domain when probing devices if the driver supports
> blocking domain allocation. Otherwise, revert to the previous behavior,
> that is, use UNMANAGED domain instead when the blocking domain is needed.
> 
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> Tested-by: Zhangfei Gao <zhangfei.gao@linaro.org>
> Tested-by: Tony Zhu <tony.zhu@intel.com>
> ---
>  drivers/iommu/iommu.c | 29 +++++++++++++++++------------
>  1 file changed, 17 insertions(+), 12 deletions(-)

This seems like a lot of overhead to allocate these things for every
group?

Why not add a simple refcount on the blocking domain instead and
allocate the domain on the pasid attach like we do for ownership?

Jason