Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 26 Aug 2022 11:53:15 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Lu Baolu <baolu.lu@linux.intel.com>
Cc:     Joerg Roedel <joro@8bytes.org>,
        Christoph Hellwig <hch@infradead.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Kevin Tian <kevin.tian@intel.com>,
        Ashok Raj <ashok.raj@intel.com>, Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Jean-Philippe Brucker <jean-philippe@linaro.com>,
        Dave Jiang <dave.jiang@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Vinod Koul <vkoul@kernel.org>,
        Eric Auger <eric.auger@redhat.com>,
        Liu Yi L <yi.l.liu@intel.com>,
        Jacob jun Pan <jacob.jun.pan@intel.com>,
        Zhangfei Gao <zhangfei.gao@linaro.org>,
        Zhu Tony <tony.zhu@intel.com>, iommu@lists.linux.dev,
        linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v12 08/17] iommu: Make free of iommu_domain_ops optional
Message-ID: <YwjeW+nSIDkmmggd@nvidia.com>
References: <20220826121141.50743-1-baolu.lu@linux.intel.com>
 <20220826121141.50743-9-baolu.lu@linux.intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220826121141.50743-9-baolu.lu@linux.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Tpsp76ggvKreP/Z01GV6fjfNNUe2uLiQZNytQwGGes2xyh7l5HypnFP87e2o?=
 =?us-ascii?Q?stWQZpNIv343wwGfs38vX2KaF4idSiROBPrUS3cwI87sKF0x4ctg98K8m5tN?=
 =?us-ascii?Q?yGO4AhpnqV/E6SW2h0Q6DKm1iBdlccAyQqyKB03DWyqtNrVczZE49mo1y8sw?=
 =?us-ascii?Q?ItpDuc55CxaRsFRNX92+alkuTVBiDVdkX2uHC+f49OXGvTPjOv7LhIoSKnr3?=
 =?us-ascii?Q?rLqRNwwL2SSPVV7Xp/i6AQYrdm+RhTBwS7kVdcDN9bC4rD6FGdBLJHfCo+ft?=
 =?us-ascii?Q?Yc+eaBYV1AQwMBnYWMp3kjgw3rwdTPH2Q6wBlpWfWFZ3dzOVLRSonQFH/NSk?=
 =?us-ascii?Q?6Z0bQlOnaVPfzq1t99TVRSRbFmB2avILMmbfkZj8S4mHAwTzPA5vVgyW8w3u?=
 =?us-ascii?Q?ZVJ9WVihA0Rp1v3uyPEH8lbu+5t7MH9ipUOXQmoyi3zXaF3c0U2U6nRL7rbW?=
 =?us-ascii?Q?bSiZSShcQnvEg1Iwhxj0whFuUE5Rq2gm0BTPywyshK66/iO55NM31loZqudO?=
 =?us-ascii?Q?ZiZFcc19Ztw4LJwyK1Og1jl5WkcOiM9L4a5dDJqyfTnH/e8Q7ed/QjLr0CqT?=
 =?us-ascii?Q?W0BLT/sxtBP+vOxjmb0pUgZY9LyfQwLYudzecE2kcFTGsKIFyI5VhbswHwTv?=
 =?us-ascii?Q?bXj7aqlVfJv2rL6WYSfBr+aYX175IIzIEXF/PadfL/Y32KY0T9Vf/wtPc7X+?=
 =?us-ascii?Q?A4msNzZ0Mcb8dgeTgkLQi/huk2nWkuhq3VEDqxnTPL1Ocusdl2MPSFcKO6Hd?=
 =?us-ascii?Q?HLZgcOAKNlQuVqJxIjYsvDT3r61xkCIU55ybXs1RUUwf+Eb04BOjihDxwcEU?=
 =?us-ascii?Q?X8H4GhXsJbFU/NFEz6UNhS0LtwHXpNnBW2mfUZma6cEkXcFLuwV+jedBx0RK?=
 =?us-ascii?Q?4YxAy5U0x8QihCN3S1VIJg1+sTpWJ61y1V88pHSRzw9BvKJZuhWo98BisrKf?=
 =?us-ascii?Q?z3qLS+5cWg6PdRviUWzQpZQIvItYQ3Qy+avPa+4oUe85vbZuCIhofv5uRCN9?=
 =?us-ascii?Q?4fWloCYWd8CnWu7tSeRAprN8YaG+YqjWtZYB8XT/+kXXm/znoKTZmWX7CaX+?=
 =?us-ascii?Q?4RoHIQx1bgi0gAyEm2q2t1RD7zSTQFaw4EjV1tcf5iK88ZOBYt7LwZnRIFlZ?=
 =?us-ascii?Q?U5drUFk0xlLgcI02PVVXFBI2HPy3vFg5sZdlBFYc83hIQsLg6lrvXINeXUtM?=
 =?us-ascii?Q?92T6JC5CcCrKO86YAt3TFk0glK8E/c0DIh86Up26Y23IOlH4l8ycWclmAOTu?=
 =?us-ascii?Q?b5MC/IDm2vOO5JVCMre+xVuuRBD3/KPSzYKbR2LobG/80tSXCj4GnnIQKCyV?=
 =?us-ascii?Q?z6IF1qG1QuxezdfmAFMFImTsWRqJiX2Ju30R/wCUqcR8riP/1nFpMCSzC+KY?=
 =?us-ascii?Q?7dRSdzM5JvRurCgFmrOZ/I6V7c1D9jubn0mLIHvRplr1fSdZ0z8NWEHeKD6j?=
 =?us-ascii?Q?5YMcAg8TGZVK8Z7MfQVHQuo1aVnoBpPTh9kKUxxt/ybxFs4CVHJffOunjJlG?=
 =?us-ascii?Q?zR4zGvOIL6fR2Ef9POU3Z1fn9KPMUyQ6Ys2rguo8TEUjUCVhkXQIS15oQzb6?=
 =?us-ascii?Q?8FmkD8MLxdLBZKzv9HMyl4Yp8v1TYeG426USN43M?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5eec7a03-10d2-48b1-cdda-08da8772b5b0
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2022 14:53:17.2676
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Mrv5mYH7BIdlEthzJ/28sWa33/uQd36mNw3vajIWRyMfn+3efpKm6UFCup7n5mSf
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6797
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Aug 26, 2022 at 08:11:32PM +0800, Lu Baolu wrote:
> So that the drivers are able to implement static singleton instance for
> some special domains. The blocking domain is an example. The driver has
> no need to allocate different memory for each blocking domain allocation
> request. Hence, no need for a free callback.
> 
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> Tested-by: Zhangfei Gao <zhangfei.gao@linaro.org>
> Tested-by: Tony Zhu <tony.zhu@intel.com>
> ---
>  drivers/iommu/iommu.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
> index e985f4d5895f..630e1b64ed89 100644
> --- a/drivers/iommu/iommu.c
> +++ b/drivers/iommu/iommu.c
> @@ -1972,7 +1972,8 @@ void iommu_domain_free(struct iommu_domain *domain)
>  	if (domain->type == IOMMU_DOMAIN_SVA)
>  		mmdrop(domain->mm);
>  	iommu_put_dma_cookie(domain);
> -	domain->ops->free(domain);
> +	if (domain->ops->free)
> +		domain->ops->free(domain);
>  }
>  EXPORT_SYMBOL_GPL(iommu_domain_free);

This patch is in the wrong order, it needs to be before the ARM patch
implementing the blocking domain

But looks OK

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason