Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220826144629.11507-1-ilpo.jarvinen@linux.intel.com> <20220826144629.11507-2-ilpo.jarvinen@linux.intel.com>
In-Reply-To: <20220826144629.11507-2-ilpo.jarvinen@linux.intel.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Fri, 26 Aug 2022 18:39:57 +0300
Message-ID: <CAHp75Vc8jNDUnEMBcQqe0mvM_o-16TM+f3xjn1NMuedNd6wJZA@mail.gmail.com>
Subject: Re: [PATCH 1/3] serial: Rename vars in uart_get_rs485_config()
To:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jirislaby@kernel.org>,
        "open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Lino Sanfilippo <LinoSanfilippo@gmx.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Aug 26, 2022 at 5:50 PM Ilpo J=C3=A4rvinen
<ilpo.jarvinen@linux.intel.com> wrote:
>
> Make variable names to match uart_set_rs485_config() ones:
>         - rs485 -> rs485_user
>         - aux -> rs485

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
(see below)

> Signed-off-by: Ilpo J=C3=A4rvinen <ilpo.jarvinen@linux.intel.com>
> ---
>  drivers/tty/serial/serial_core.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial=
_core.c
> index 12c87cd201a7..9c1bf36b7a93 100644
> --- a/drivers/tty/serial/serial_core.c
> +++ b/drivers/tty/serial/serial_core.c
> @@ -1408,16 +1408,16 @@ int uart_rs485_config(struct uart_port *port)
>  EXPORT_SYMBOL_GPL(uart_rs485_config);
>
>  static int uart_get_rs485_config(struct uart_port *port,
> -                        struct serial_rs485 __user *rs485)
> +                        struct serial_rs485 __user *rs485_user)
>  {
>         unsigned long flags;
> -       struct serial_rs485 aux;
> +       struct serial_rs485 rs485;

At the same time you may order it by "the longest line first".

>         spin_lock_irqsave(&port->lock, flags);
> -       aux =3D port->rs485;
> +       rs485 =3D port->rs485;
>         spin_unlock_irqrestore(&port->lock, flags);
>
> -       if (copy_to_user(rs485, &aux, sizeof(aux)))
> +       if (copy_to_user(rs485_user, &rs485, sizeof(rs485)))
>                 return -EFAULT;
>
>         return 0;

--=20
With Best Regards,
Andy Shevchenko