Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 26 Aug 2022 18:15:20 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Hawkins Jiawei <yin31149@gmail.com>
Cc:     Anton Altaparmakov <anton@tuxera.com>, akpm@linux-foundation.org,
        chenxiaosong2@huawei.com, linux-kernel@vger.kernel.org,
        linux-ntfs-dev@lists.sourceforge.net,
        syzbot+5f8dcabe4a3b2c51c607@syzkaller.appspotmail.com,
        syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH] ntfs: change check order in ntfs_attr_find
Message-ID: <20220826151520.GF2071@kadam>
References: <20220826122735.2690-1-yin31149@gmail.com>
 <20220826123257.3826-1-yin31149@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220826123257.3826-1-yin31149@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YMHGDk4MIQbjFr4/egI4kbSMHQU3+wr+ecMppW8eoQxeOh7h3HMdq2W/NAwm?=
 =?us-ascii?Q?O5mfWh/8soW8qkGFWQ7u0Biwg1BC/J38Kuor29jhM14DniByDcmZdhLTJXYG?=
 =?us-ascii?Q?rJsK8CSID7Mwna/F9ug5iMbfPAG2bFKI1lteu/n7IJKRvtRE3PkKtJcqE99W?=
 =?us-ascii?Q?fjEVvOr0QQ2NTckrHX60Ps/OXxw/xqO2pBOJ4lqJ0v2Ijdrh6xg/RF/1EgaH?=
 =?us-ascii?Q?+sosERxUcrhNdF9wHnFMkb1+fAWhI32SMv70CuqCZ9uh8QsRz4qx4PQrOmzN?=
 =?us-ascii?Q?r9avHlDd70t9ib5hfwqpoV52IZSfrhSugbnNuBYzaUR/sC0oPBuojrF1m/vB?=
 =?us-ascii?Q?QA0aOA9Le5BDwPDoeOzKX9niydLj4QhRHh6QQhPBgBEtMcU5P7VyL+DUvLss?=
 =?us-ascii?Q?yVc9ZGM2vAlbboqRGz9WmmgoSi2BqolZKhKbJcgZaeTbTW98ObRnLOBB3n80?=
 =?us-ascii?Q?4wwKqVqZvb9lQibfNxTlAUyzHiIMM+XtMp47yahrCxe5uNz4QNSNSl5G5WSI?=
 =?us-ascii?Q?Ch+J6YPpwZ+I0n74doTkOBM8s8BdzLsbMVBs8ply2tYBJ99yW9ugzRocbvgr?=
 =?us-ascii?Q?KYHYc6L2W6tTXDvXVF76ezVDmSDVpyBO+egPlWijGjcX2wR/FnKe01j3Ze1M?=
 =?us-ascii?Q?tLcpTs41KNxCTryubh/fIz0KnDWOm+I2c24BvmU2vSP9z1TpFJXTW8LRcJft?=
 =?us-ascii?Q?8B3CP29hadBNiKagUWEYgdN/gQW55rS1dhNS9K7A2/qzVas19PCMYzrhfsWC?=
 =?us-ascii?Q?ylqdHBAJokXhLDmPL5CcjMp/of2DmQO/7TXlRiAGh+l5tZ6y6dc/X2614P5N?=
 =?us-ascii?Q?ABEAiIownAZ1wSy8B6xvI7dGt5tFjgrZtr0FwyqENys+EDsKtMpPxiJaZvWF?=
 =?us-ascii?Q?g050JEeNcUqEI8bwqom4yiMQkiq+ZbqihwsVjcutAX0gTfG9ln9vUV11RLXO?=
 =?us-ascii?Q?TupKtmtQsUuHyFrYOMYdg0lGWYQHKe3N/PL5XbRw6a04m//firT87rRe/CY0?=
 =?us-ascii?Q?Rm50R8RsatTsMaqRy8ZabqL8I+/TpPOhVr9Xx93fY+H8kI+WfkaQpiOBAqNT?=
 =?us-ascii?Q?UdBeR84/gQCUasTpvI0S4OUDk7iRsSolEh8l2Ed7u3xlZIS0SuGWo9PrYgKe?=
 =?us-ascii?Q?i3T2DA893nBp4FCGQKenULZkcErmYE3U+WDySgMkF7MPwt2oI2g78P8DNhNX?=
 =?us-ascii?Q?6NmL/I4Y2GUt4ASnUQ/LuGaNc+RflBI+AQGlbEM1JudDs4P5bRf56Jo+k/8W?=
 =?us-ascii?Q?j+ta97Hhq3CgNs/M1bnQUND/arM5Q8TB3CuXzl3XXnRtoH6ZUeWJlmS+jiHg?=
 =?us-ascii?Q?geGj9OOLbP0ArBi/hwanqU65ogAcrTwNytRFc04IUQ8tYWjRo8F3A5jD9sgT?=
 =?us-ascii?Q?3dJ0SvrxTu6tuuOOLQrVdxy+v+L30gdt6C1Zqub6tzovjlTNqCOb8NpvVJSy?=
 =?us-ascii?Q?ASwfj29XLcEZUzuC4BIcqf5wZRbblSvouuXB+Ny4JitOGm0lTiIzZ33fgZ2h?=
 =?us-ascii?Q?kVRuJekceGick6z7K/mqn3Jd5RNE5gXiVBTZVRn28giidRaxa7uBWNcGgHNa?=
 =?us-ascii?Q?z0dhXzojPWP9hprGXOCOsQ/6FIe+b9UgJN4gd6uIrMvvUX1Tk3kYniTNe+SW?=
 =?us-ascii?Q?Xw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 48a5dc24-6069-4bd2-18c3-08da8775d133
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2022 15:15:32.6430
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xh99oDDf1N8JG2S4vrVf/rdBLOp1kDyWfqBNhfAItyglcqKOSCEiqEJ9NWLl6raK4m8Er7HVG7mv36zLOU1LZdSzkaHjQGxtdyiVEEW0MZk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR10MB5464
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-26_08,2022-08-25_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxscore=0 phishscore=0
 spamscore=0 malwarescore=0 mlxlogscore=999 suspectscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000
 definitions=main-2208260063
X-Proofpoint-ORIG-GUID: Jl1hdRoL3F97Nr9f2R0HILgu8mftVxin
X-Proofpoint-GUID: Jl1hdRoL3F97Nr9f2R0HILgu8mftVxin
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Aug 26, 2022 at 08:32:57PM +0800, Hawkins Jiawei wrote:
> > syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> >
> > Looks like it is improper check order that causes this bug.
> 
> Sorry for wrong command.
> #syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> 
> diff --git a/fs/ntfs/attrib.c b/fs/ntfs/attrib.c
> index 52615e6090e1..6480cd2d371d 100644
> --- a/fs/ntfs/attrib.c
> +++ b/fs/ntfs/attrib.c
> @@ -594,10 +594,11 @@ static int ntfs_attr_find(const ATTR_TYPE type, const ntfschar *name,
>  	for (;;	a = (ATTR_RECORD*)((u8*)a + le32_to_cpu(a->length))) {
>  		u8 *mrec_end = (u8 *)ctx->mrec +
>  		               le32_to_cpu(ctx->mrec->bytes_allocated);
> +		if ((u8*)a < (u8*)ctx->mrec || (u8*)a > mrec_end)
> +			break;

This definitely seems like a bug.  But your code won't build.  Syzbot
must have -Werror turned off?

Btw, this was in the original code, but those casts are ugly.  Ideally
there would be some way to get rid of them.  But otherwise at least
put a space after the u8.  "(u8 *)a < (u8 *)ctx->mrec".

>  		u8 *name_end = (u8 *)a + le16_to_cpu(a->name_offset) +
>  			       a->name_length * sizeof(ntfschar);
> -		if ((u8*)a < (u8*)ctx->mrec || (u8*)a > mrec_end ||
> -		    name_end > mrec_end)
> +		if (name_end > mrec_end)
>  			break;

regards,
dan carpenter