Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 26 Aug 2022 12:50:42 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Lu Baolu <baolu.lu@linux.intel.com>
Cc:     Joerg Roedel <joro@8bytes.org>,
        Christoph Hellwig <hch@infradead.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Kevin Tian <kevin.tian@intel.com>,
        Ashok Raj <ashok.raj@intel.com>, Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Jean-Philippe Brucker <jean-philippe@linaro.com>,
        Dave Jiang <dave.jiang@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Vinod Koul <vkoul@kernel.org>,
        Eric Auger <eric.auger@redhat.com>,
        Liu Yi L <yi.l.liu@intel.com>,
        Jacob jun Pan <jacob.jun.pan@intel.com>,
        Zhangfei Gao <zhangfei.gao@linaro.org>,
        Zhu Tony <tony.zhu@intel.com>, iommu@lists.linux.dev,
        linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v12 00/17] iommu: SVA and IOPF refactoring
Message-ID: <Ywjr0rolwfdiaFSC@nvidia.com>
References: <20220826121141.50743-1-baolu.lu@linux.intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220826121141.50743-1-baolu.lu@linux.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?9SmC6L0hk7Fg/zIPCjvOTMQ/n3eX9sZ5rDQUT1SZuf3W2fok3rHSHPLGUu9A?=
 =?us-ascii?Q?Sm6bErT44nwGTr8h/5drZSV9CQ5y4BT9R2BWNqNK068bUXDDGyjw3gQv5Yo8?=
 =?us-ascii?Q?CRwH3vHYyVSVICwSs/YETS/Y2qpjTzEzoFkCtgA2kCjAieSLdrzmjBhahudl?=
 =?us-ascii?Q?EUsVxCRh6WBkaPYiz5eTzJK3HV1P5dZfkt0V6QXFvIGshojuEMZNzgKYsy7R?=
 =?us-ascii?Q?6GRP0Y2L4a2YvwMv0qnn0TRLbRWEfvehlxMGHmV32ruTJV0epfWwMjy7kVNS?=
 =?us-ascii?Q?5BbKaP7V8T4EBHHyvOug1fYvgFyGakahCZZ2x1u4ojn9q7ecymVbKeDbtgbF?=
 =?us-ascii?Q?uutI7HAdFBGWeCPAgG5Dh9aZmuVON8palUju2Wdw0fVj6qY+Uw6LE9KBVQut?=
 =?us-ascii?Q?Vd5m8aikSqel1XMCmJPPI0W8pqyYT9t1h8m7KrF2/lZmPypv+XEGZgFMWxis?=
 =?us-ascii?Q?2efbRo279u3Slhgx1YPgOvPC82a6sDUxp5QtNHKmLvbnrM9zDy1aTCHwjYvW?=
 =?us-ascii?Q?PvjT3xFdR3h/4wwNKJBfobkFrr90OJJO5/ypNOLwFaI/ycPEGysGEDxlJwCn?=
 =?us-ascii?Q?fh5oDwaC9XhxIF7qksEmy2LhLX+1RmW0TGOxzJ0J3EgYjEh3qDkNOj+QgUDV?=
 =?us-ascii?Q?fjG0a0jXbwVBQIX0h6n6UoAakGWHeOFtBbGIkcnecQLaWDWqgjU1hlfzmQny?=
 =?us-ascii?Q?7TjHDbbh33e3qBK4GXtCfRWIrS1WFRAyQy8xC0zUMg6Gigd1o93sXQGoxpGf?=
 =?us-ascii?Q?OG266c31OzZGKYAnynHkoHyTcNy0r+daTybcBL0HWru6U177D1Oeq5Q6LOp/?=
 =?us-ascii?Q?UsVkYjCcwETVmdsoGg0S//EKXikp3ERpbzlwicW5XTUOYAADEzwS7gv39TCi?=
 =?us-ascii?Q?DEfuaeDTeJ+oNEmDFB0rmYN06VsoiRU/AaP1jt7uF3mxixJpXmym1YZ4vi/v?=
 =?us-ascii?Q?pE2ZTK1JkudqK+2iG4D3mdZfHKHl+kBqDfudYoQEeHfeUumuRyJhiHEMrMco?=
 =?us-ascii?Q?OfgBM5c4RDzWVWQoAvDCsZ+6J4K7BCKFOmDtjg8fhO4fzBlZtlb2vTPcvBX+?=
 =?us-ascii?Q?fF7rqris6G/uaiCo7Q6CFH8xayW+IlRZDvT1LIEQm5lF/ZLRzmLO7jvN5SHC?=
 =?us-ascii?Q?RvCAmQljKB3ATeJFFqJ7KVpHCb+IgNM1AZ++YzcDP0h3bxE/6VONuoJY6RPS?=
 =?us-ascii?Q?IcOVDYAN3KFNl4IMUOmd2CA4nQyru92Pq6xHcLmr7eejysM4u6ObYmL4XIIJ?=
 =?us-ascii?Q?0VxsYyE89CdJTj4nMrt7B3j8Ngvqg3okRg+Eu5A1bK9EhBpWLB83EW3TKO5K?=
 =?us-ascii?Q?OGuIvnsUAJmdlik3/IHY1OoVpvvzSwc8PxePTmvhJzCK7zj1c/WhQ3ZayOSt?=
 =?us-ascii?Q?21YBC9F1McAbWs4aDhz1Nt+HtUPIFpNLmLKLuqen8YeRfuJJEsWEqSeWsoNB?=
 =?us-ascii?Q?imZRj9Qfuo0AjAqkjX3EH2OYxko3xUDm1nDo3SP99ty+bIOXqwyCJ6Qjxi4A?=
 =?us-ascii?Q?TzIn1WtEubgZeKEKHYfNMvr3p+kBL7Eqh9FRfOp9i8HENG+xX+4LaHuA0c6X?=
 =?us-ascii?Q?5w7KOhZcFe6L5WrBdyEOmw0majtWhHWAuORSHRN+?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2a3cb4ff-0d4e-4aa4-85b7-08da877abc18
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2022 15:50:43.9704
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: L/bTJOqcn8D+2GJYR13g/3zFjEUzQWLcJ1Htj8HRxIX6kFuL97FNBi8zopg+6Xel
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4887
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Aug 26, 2022 at 08:11:24PM +0800, Lu Baolu wrote:
> Hi folks,
> 
> The former part of this series introduces the IOMMU interfaces to attach
> or detach an iommu domain to/from a pasid of a device, and refactors the
> exsiting IOMMU SVA implementation by assigning an SVA type of iommu
> domain to a shared virtual address and replacing sva_bind/unbind iommu
> ops with a set_dev_pasid domain ops.
> 
> The latter part changes the existing I/O page fault handling framework
> from only serving SVA to a generic one. Any driver or component could
> handle the I/O page faults for its domain in its own way by installing
> an I/O page fault handler.
> 
> This series has been functionally tested by Tony Zhu on Intel hardware
> and Zhangfei Gao on arm64 (Kunpeng920) hardware. Thanks a lot for the
> efforts. 
> 
> This series is also available on github:
> https://github.com/LuBaolu/intel-iommu/commits/iommu-sva-refactoring-v12
> 
> Please review and suggest.
> 
> Best regards,
> baolu
> 
> Change log:
> v12:
>  - Add blocking domain support in both vt-d and smmuv3 drivers and make
>    the set blocking domain through its own domain ops.
>  - Add a type parameter in iommu_get_domain_for_dev_pasid() to matach
>    the interested domain type.
>  - Only enforce ACS RR & UF in pci_enable_pasid() and refine the commit
>    messages according to Bjorn's suggestions.
>  - Misc code and comment refinement.

I think this is looking pretty good, aside from some minor remarks

Jason