Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220825085810.7290-1-ilpo.jarvinen@linux.intel.com> <20220825085810.7290-4-ilpo.jarvinen@linux.intel.com>
In-Reply-To: <20220825085810.7290-4-ilpo.jarvinen@linux.intel.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Fri, 26 Aug 2022 18:56:27 +0300
Message-ID: <CAHp75Vdn6tTnJbP0--PZoKZJN3XbJpDNN+4GNAF65BK8DRKFgQ@mail.gmail.com>
Subject: Re: [PATCH 3/5] serial: fsl_lpuart: Remove custom frame size calculation
To:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jirislaby@kernel.org>,
        "open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Aug 25, 2022 at 11:59 AM Ilpo J=C3=A4rvinen
<ilpo.jarvinen@linux.intel.com> wrote:
>
> The number of bits can be calculated using tty_get_frame_size(), no
> need for the driver to do it on its own.

...

>         struct dma_slave_config dma_rx_sconfig =3D {};
>         struct circ_buf *ring =3D &sport->rx_ring;
>         int ret, nent;
> -       int bits, baud;
> +       int baud;
>         struct tty_port *port =3D &sport->port.state->port;
>         struct tty_struct *tty =3D port->tty;
>         struct ktermios *termios =3D &tty->termios;
>         struct dma_chan *chan =3D sport->dma_rx_chan;
>
>         baud =3D tty_get_baud_rate(tty);

You can move baud and join with the assignment, right?
At the same time provide a temporary variable for bits here with the assign=
ment.

> -       bits =3D (termios->c_cflag & CSIZE) =3D=3D CS7 ? 9 : 10;
> -       if (termios->c_cflag & PARENB)
> -               bits++;
> -
>         /*
>          * Calculate length of one DMA buffer size to keep latency below
>          * 10ms at any baud rate.
>          */
> -       sport->rx_dma_rng_buf_len =3D (DMA_RX_TIMEOUT * baud /  bits / 10=
00) * 2;

This will be left untouched.

> +       sport->rx_dma_rng_buf_len =3D (DMA_RX_TIMEOUT * baud / tty_get_fr=
ame_size(termios->c_cflag) /
> +                                    1000) * 2;

And no strange indentation.

--=20
With Best Regards,
Andy Shevchenko