Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220825091707.8112-1-ilpo.jarvinen@linux.intel.com>
In-Reply-To: <20220825091707.8112-1-ilpo.jarvinen@linux.intel.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Fri, 26 Aug 2022 19:03:50 +0300
Message-ID: <CAHp75VeJ2KR_-JUfW_3LEgB1ezQQzJ_2jLbH8vcWOtTSDAhKdQ@mail.gmail.com>
Subject: Re: [PATCH 0/3] serial: Add uart_xmit_advance() + fixes part (of a
 larger patch series)
To:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jirislaby@kernel.org>,
        "open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Aug 25, 2022 at 12:19 PM Ilpo J=C3=A4rvinen
<ilpo.jarvinen@linux.intel.com> wrote:
>
> Add uart_xmit_advance() helper to handle circular xmit buffer
> advancement + accounting of Tx'ed bytes. Use it to fix a few drivers
> that previously lacked to accounting for DMA Tx.

For the whole series
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Thanks for fixing this issue.

> Greg,
> I've a another series on top this which is tty-next material making the
> rest of the drivers to use uart_xmit_advance(). That series obviously
> depends on the patch 1/3 of this series so if you end up putting these
> 3 patches into tty-linus, I'll need it to be merged into tty-next at
> some point (I'm not in a big hurry with this so if you choose to delay
> the merge, it's not a big deal).
>
> Ilpo J=C3=A4rvinen (3):
>   serial: Create uart_xmit_advance()
>   serial: tegra: Use uart_xmit_advance(), fixes icount.tx accounting
>   serial: tegra-tcu: Use uart_xmit_advance(), fixes icount.tx accounting
>
>  drivers/tty/serial/serial-tegra.c |  5 ++---
>  drivers/tty/serial/tegra-tcu.c    |  2 +-
>  include/linux/serial_core.h       | 17 +++++++++++++++++
>  3 files changed, 20 insertions(+), 4 deletions(-)
>
> --
> 2.30.2
>


--=20
With Best Regards,
Andy Shevchenko