Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Secumail-id: <12fd7.6308f9de.56d05.0>
Date:   Fri, 26 Aug 2022 18:50:36 +0200
From:   Jules Maselbas <jmaselbas@kalray.eu>
To:     Conor.Dooley@microchip.com
Cc:     linux-kernel@vger.kernel.org, rdunlap@infradead.org,
        bagasdotme@gmail.com, corbet@lwn.net, linux-doc@vger.kernel.org
Subject: Re: [PATCH v3] Remove duplicated words across the whole
 documentation
Message-ID: <20220826165036.GE10294@tellis.lin.mbt.kalray.eu>
References: <20220826143300.6794-1-jmaselbas@kalray.eu>
 <20220826163458.1142-1-jmaselbas@kalray.eu>
 <cccaf53c-9438-0927-b074-c74c47bfb1ec@microchip.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <cccaf53c-9438-0927-b074-c74c47bfb1ec@microchip.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-ALTERMIMEV2_out: done
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Aug 26, 2022 at 04:40:50PM +0000, Conor.Dooley@microchip.com wrote:
> Hey Jules,
> On 26/08/2022 17:34, Jules Maselbas wrote:
> > Remove duplicated words (the, at, be ...) across the whole documentation.
> > In some cases the duplicated words are replaced by something that makes
> > more sense, for instance: "be be" is replaced by "can be" when possible.
> > 
> > There are likely more duplicated words to be found.
> > 
> > CC: Randy Dunlap <rdunlap@infradead.org>
> > CC: Bagas Sanjaya <bagasdotme@gmail.com>
> > CC: Jonathan Corbet <corbet@lwn.net>
> > CC: linux-doc@vger.kernel.org
> > Signed-off-by: Jules Maselbas <jmaselbas@kalray.eu>
> > ---
> 
> 
> >  
> >  printk_rb_static
> > diff --git a/Documentation/admin-guide/media/vivid.rst b/Documentation/admin-guide/media/vivid.rst
> > index 4f680dc9661c..a5a9c062b23f 100644
> > --- a/Documentation/admin-guide/media/vivid.rst
> > +++ b/Documentation/admin-guide/media/vivid.rst
> > @@ -392,7 +392,7 @@ Which one is returned depends on the chosen channel, each next valid channel
> >  will cycle through the possible audio subchannel combinations. This allows
> >  you to test the various combinations by just switching channels..
> >  
> > -Finally, for these inputs the v4l2_timecode struct is filled in in the
> > +Finally, for these inputs the v4l2_timecode struct is filled in the
> 
> FYI, this does not look like a typo. It reads as if the filling in happens
> in the dequeued struct.
You're right, I tought the same when seeing this elsewere, this is a mistake.

> 
> >  dequeued v4l2_buffer struct.
> >  
> >  
> 
> > diff --git a/Documentation/virt/uml/user_mode_linux_howto_v2.rst b/Documentation/virt/uml/user_mode_linux_howto_v2.rst
> > index af2a97429692..ce67a03a7c80 100644
> > --- a/Documentation/virt/uml/user_mode_linux_howto_v2.rst
> > +++ b/Documentation/virt/uml/user_mode_linux_howto_v2.rst
> > @@ -1090,7 +1090,7 @@ be formatted as plain text.
> >  
> >  Developing always goes hand in hand with debugging. First of all,
> >  you can always run UML under gdb and there will be a whole section
> > -later on on how to do that. That, however, is not the only way to
> 
> And neither is this. It means that there will be a later section that
> explains how to do it. Possibly there should be some punctuation in
> between though.
Yeah... I personally think that this reads badly but I don't mind dropping
this change.

> 
> > +later on how to do that. That, however, is not the only way to
> >  debug a Linux kernel. Quite often adding tracing statements and/or
> >  using UML specific approaches such as ptracing the UML kernel process
> >  are significantly more informative.
> 
> Thanks,
> Conor.
> 
>