Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 26 Aug 2022 09:51:08 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     Haiyue Wang <haiyue.wang@intel.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, david@redhat.com, apopple@nvidia.com,
        linmiaohe@huawei.com, ying.huang@intel.com,
        songmuchun@bytedance.com, naoya.horiguchi@linux.dev,
        alex.sierra@amd.com, gerald.schaefer@linux.ibm.com,
        Baolin Wang <baolin.wang@linux.alibaba.com>
Subject: Re: [PATCH v7 1/2] mm: migration: fix the FOLL_GET failure on
 following huge page
Message-ID: <Ywj5/F2MwgVIlEPl@monkey>
References: <20220823135841.934465-1-haiyue.wang@intel.com>
 <20220823135841.934465-2-haiyue.wang@intel.com>
 <20220824113858.9f0a2200c4d4875a5f4da31c@linux-foundation.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220824113858.9f0a2200c4d4875a5f4da31c@linux-foundation.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bD1Mvez6zHRJ798DgVVX6QpOpFuqhs+bVE/6a/kyYupRqXUDRvoGr/q8XlNv?=
 =?us-ascii?Q?yLD/MnUyK+UPl+w/TC0D4oqXYR26kyVlhkvZTIcKnnN3FZjGW+J8gurKVeLN?=
 =?us-ascii?Q?6rc2+/MIqhGEpsCBDKAlzy1cqoax9sonUR45nGTsEbPymOcHcN3m9KJgahY+?=
 =?us-ascii?Q?7uX0Fz9fvEtjBA1bQGik+J0vNXF3O65V5W6bTtSIp1jBiu/uSHsHog6qToHf?=
 =?us-ascii?Q?svzHr/gohM3zt17F8aW/ryk0FlRV0dU7ZkG0UZXH353xMQ2Tv5jjyt3KEZHT?=
 =?us-ascii?Q?hv2y7bnUCzpK+vwP+GYaX+JUH3c/C/dXnGLwDJMuGygn4Rbz2o7orcoTclCG?=
 =?us-ascii?Q?N/uPjqAp11vHIZOvaifuj4QPa+PngKkAiTCh2wxVgvy32MVd11S4DDPz8jVx?=
 =?us-ascii?Q?VC/7miQ7MVC28HiP8KZlFmSqjy13KHmytF6cQEkOg0REqpDp2V2qdNG8vQK2?=
 =?us-ascii?Q?GLnwYzXin9k2lRbR5YN7+H9JbXZ9Wgeq3Z229M7azwaaEChiANGtNx9sutkA?=
 =?us-ascii?Q?j7F5vlr/PlZA053rEDPXzTsi3iyp1y+3HZ+dFwxMCkNmnDszw6lx+UZA7Yp3?=
 =?us-ascii?Q?pWusC1pA2hX5csYbRD9/k9g0Ldi3ouX4tHtq8rCALFzKgIltXRy4yiv8xWT3?=
 =?us-ascii?Q?/1SkAdEPhZuxSvikX66aN2ouIQr+KmcugSexampf8Eun9t/9P1kjzt4lmjFN?=
 =?us-ascii?Q?YfmLfZatXfwP1pMHqIrgKkJxeS7MNsVVvtkjqXqo3OBOMrnjPYVVVUYCgYm7?=
 =?us-ascii?Q?kReCqyyRd3ni6A7N4MkN0ecCU3GhBsfwqvMPPxVDNPjOz2tnkZp3ozcoiUsX?=
 =?us-ascii?Q?zVfWCdvjE0WEvlF4I6lPy5S416QonV5kcbzCjcxEAnYiSoDxSPT3DN5WxT+b?=
 =?us-ascii?Q?8RpfACCtRiHm4Obylrvd9kuN4qdIfu2TnVbt6GMHZchg1eAzAOB6QEkoTgnW?=
 =?us-ascii?Q?ZQulbAsvtunbcoRtBJ2XKP4dzvEKR81bd0WE2OhjWcjdqx97ErCLbMFnCGz1?=
 =?us-ascii?Q?ATNrdE3L6GFg/pzesyEyG17eLBjXJS78DEWDObGdeJ2VBNzHtpNuLFHS3on0?=
 =?us-ascii?Q?i+nUZs3b3QPPMJ0vrnn28p49481LLQGekGgT29B3Uq6t0BN41MO4UYoW5OwQ?=
 =?us-ascii?Q?DgRMJ/mFzNlCdsH/rnmiwSQ22pppxkKSkarEjXv2xvaxvXIBzS9H6wuAf2qt?=
 =?us-ascii?Q?cwVfYcjKK6PNuT9POr9BmD9GEqLnmn/IU7WkJ3RDClxAo7Meljts5zyCiBsB?=
 =?us-ascii?Q?MrHi9uW7dZ2KvUTA2GRRS/BINrPOMR1HdDWXMZP8HcTkKgd5NG/76Y0YIUB1?=
 =?us-ascii?Q?10/tCP7WbivnN626qBoOYVIkFBEjj6VC/dDUl3g1mxz3tn+h6SVH2KamG9Vm?=
 =?us-ascii?Q?RNtNyyYoT3SKp5kAJpubCYSyzN/Gr37s8mrxnzaxO/w4Ylw0vF/TQSO/V88i?=
 =?us-ascii?Q?tpSWeDnQYcfYB0BI2cR//PyCX2R6kGQf8nh/G/A3VVHkFNRhwbnHTUgUFtgq?=
 =?us-ascii?Q?qp31nakFK+eQM+XWjOY4ssE6guZv2anuH/uPumpHxpKw7bv36xE7FXHc6neq?=
 =?us-ascii?Q?+OgmQP8/eRCXBGItbLreJnLRGAPQZ5u7gs2Sa6pHKiuKw+HrwS6AE4NtxgUm?=
 =?us-ascii?Q?EQ=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2e4e73fa-f2eb-4a94-e065-08da87832e68
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2022 16:51:11.7636
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qYaF6Qf0/qzGZD5hDyiDemHlmqNX4SG0FaJx9hMZqcmjyTH/T40l01VOSygABh74KqeEVYLBoE45JY4k8k85TQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3366
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-26_09,2022-08-25_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=913
 phishscore=0 adultscore=0 mlxscore=0 bulkscore=0 suspectscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2207270000 definitions=main-2208260067
X-Proofpoint-ORIG-GUID: noQLl7SiTEDf_qiQrD-gp5wDtfBBG72w
X-Proofpoint-GUID: noQLl7SiTEDf_qiQrD-gp5wDtfBBG72w
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 08/24/22 11:38, Andrew Morton wrote:
> On Tue, 23 Aug 2022 21:58:40 +0800 Haiyue Wang <haiyue.wang@intel.com> wrote:
> 
> > Not all huge page APIs support FOLL_GET option, so move_pages() syscall
> > will fail to get the page node information for some huge pages.
> > 
> > Like x86 on linux 5.19 with 1GB huge page API follow_huge_pud(), it will
> > return NULL page for FOLL_GET when calling move_pages() syscall with the
> > NULL 'nodes' parameter, the 'status' parameter has '-2' error in array.
> > 
> > Note: follow_huge_pud() now supports FOLL_GET in linux 6.0.
> >       Link: https://lore.kernel.org/all/20220714042420.1847125-3-naoya.horiguchi@linux.dev
> > 
> > But these huge page APIs don't support FOLL_GET:
> >   1. follow_huge_pud() in arch/s390/mm/hugetlbpage.c
> >   2. follow_huge_addr() in arch/ia64/mm/hugetlbpage.c
> >      It will cause WARN_ON_ONCE for FOLL_GET.
> >   3. follow_huge_pgd() in mm/hugetlb.c
> 
> What happened to the proposal to fix these three sites so this patch is
> not needed?
> 

Note mpe's comments here:
https://lore.kernel.org/linux-mm/87r113jgqn.fsf@mpe.ellerman.id.au/

It has been a while since powerpc supported hugetlb pages at the PGD
level.  And, this was the only architecture which had pages at this
level.  Unless I am missing something, this means there is no issue with
follow_huge_pgd as there is no way this code could be invoked when
commit 4cd614841c06 was made.
-- 
Mike Kravetz