Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp634771rwe; Fri, 26 Aug 2022 11:13:14 -0700 (PDT) X-Google-Smtp-Source: AA6agR4h+m/ElWCjtNRQ5NNzXzuLNPodBa40xbSIOdy9PqlBQpGjWnlq421zo66b+VAp7Xv9aKjJ X-Received: by 2002:a05:6402:268d:b0:43d:b9d0:9efc with SMTP id w13-20020a056402268d00b0043db9d09efcmr7886304edd.92.1661537594440; Fri, 26 Aug 2022 11:13:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661537594; cv=none; d=google.com; s=arc-20160816; b=VMQyFb9TCQJ/8yBZ78mhiVRjbDd16EGjhwpjJCp5IwhqbOjy2M83IuC0fu6axAtKi4 uvrRvLsN3wrZk72arlqk4g9c+KmMVgvcnnv5Htl6Wjh9VgwcHvSm+mIKw2wDOdIdxq14 5cF1e5UDaIOfpJ0Kp/uvedom9CT81wA/aI0ahS3F5PPkfOUloU5F4mlwEkPGTSYAkX5n kaP1rjln0Xg+3xN2zfS/DLDyvKkUxx2OpbXDtmGlCOS7g0VOuNtSitw6ZqjwaYb7JTwn oggWgS4z6Oej34JypDlWqX1ufGYiq/ns3ZtcuCBFlajB+neonN7YP8jZOXnvUvZNe2tJ Zsrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:mime-version:date :dkim-signature; bh=rDKGbIWlt5Gc791EqDZPKPzTTSlSMP6vk6lOe6XzVfU=; b=ImOl9LBeqYevF9TeH6CDYaNnP+uvDw/qnvphktGUnfX10TfgjDa5TO4zRD8R/tqRJ2 CjAzYwYZJdcm71FvQat85kAv09hncBbJeBe3Wg/L9EI3t/pUguHmnsIfYr+r9AQtB5Ps P4XGrjCiYK0rwbpb6vEPUBx9AxpcBwB6ub7ycaEQiGEO4eBT+PJgfjumDDq3HYAaRI8S WLZGygGm5mYCJ7YhLa2bgi/aLVkY73MwbQiy8Mjc/Wd6I+4wnfw2GN5V/1kHchN4532O yGIBcLQR1Lqh6Od56L8xE7k6Dz/I8rbuzNxhK/MG3P3rX4HRmanMGqW9UcUBfjJE6C0W edYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=lGjRGty+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s12-20020a056402520c00b0043d552deb37si1908048edd.14.2022.08.26.11.12.48; Fri, 26 Aug 2022 11:13:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=lGjRGty+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344982AbiHZSKz (ORCPT + 99 others); Fri, 26 Aug 2022 14:10:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344963AbiHZSKv (ORCPT ); Fri, 26 Aug 2022 14:10:51 -0400 Received: from mail-yw1-x1149.google.com (mail-yw1-x1149.google.com [IPv6:2607:f8b0:4864:20::1149]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 580B0D2EB2 for ; Fri, 26 Aug 2022 11:10:48 -0700 (PDT) Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-33ef3e5faeeso31962417b3.0 for ; Fri, 26 Aug 2022 11:10:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc; bh=rDKGbIWlt5Gc791EqDZPKPzTTSlSMP6vk6lOe6XzVfU=; b=lGjRGty+ST9TMLxhTjOyI4ogWlDEC9tFmGQYjFZ8KYQHVB1PfLyudgypP8U6DG0qtO JOWs0y0EMC/Tt+JMX/cCVbfGHj/VP6NfwlxTp5qypJ3g63H26wUd3vmVF0Viom3ajf1/ pnOqywB1S4A3h9hvZE8UpfNfV7qBMeEuUyp9VzCkFsmq+SEql3OtIJ4H14Xk7LIVliEt nNVrQum6NJXPJAYR2LPevGIPiQMVJ3LliJ6MzdFdrBocCWZpZUu+y+u/Zwtmgc2yZ2PK QFPjd4afx+6HpDaa7WdWfZqMie36ti93DFu6pcm+AfNVePa/YZZ5rZlbYnKYx7GQEo06 EjHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc; bh=rDKGbIWlt5Gc791EqDZPKPzTTSlSMP6vk6lOe6XzVfU=; b=1tgUkKfv53kqKeOF77IZ+ILd8ilekPvXv5BqHfX3TCLuS3s2X3QEh7Hg2JecqA/cj7 i5zWWvUDFE4FfNDDIDm1uH/JOVvl+5J6NnpFy3r7BUf671VLh55+Xy1FYLz8V92mfWv7 ULuzKVaqELS10VW41sUp8E0p58u7C4/KzZ9+oTODm33Q5LtiQ6yAubj2c6UGmlOyWKyB sgBlsrMPBtpqHtT6SdwTuw43LzFmPsPeFvqh+Bbqrr+dlyf9n0dnQSO91jlVqNlIpCo2 eWPYFbORb2jrOnCA89ghv3S5UVoOzhnpVKWpOCJd6vb8dR5o827e7QaH0qNqKW+qNqti U0Ww== X-Gm-Message-State: ACgBeo1p1ygeT9/VTV4cHcR3qyrwe1kVw9lZBil0YJF0Kt/HWyM+OQNb IJ4Y0MuSSjqguKto5KhOjwtqcMVNgK5L3VLssyI= X-Received: from ndesaulniers1.mtv.corp.google.com ([2620:0:100e:712:8d7b:b933:5438:2a88]) (user=ndesaulniers job=sendgmr) by 2002:a05:6902:72a:b0:694:d1a9:612f with SMTP id l10-20020a056902072a00b00694d1a9612fmr877316ybt.505.1661537448129; Fri, 26 Aug 2022 11:10:48 -0700 (PDT) Date: Fri, 26 Aug 2022 11:10:32 -0700 Mime-Version: 1.0 X-Developer-Key: i=ndesaulniers@google.com; a=ed25519; pk=lvO/pmg+aaCb6dPhyGC1GyOCvPueDrrc8Zeso5CaGKE= X-Developer-Signature: v=1; a=ed25519-sha256; t=1661537434; l=1299; i=ndesaulniers@google.com; s=20211004; h=from:subject; bh=vbnUKTrzZYx5zvY9/fWp8T7D0Mw2VG0BTmrBgetfzUY=; b=DA2AX+YJeEATy8NJW5byVKUVKyvrA31rEO6Ns1T+FOWnbSxMkE39xP8vPKtZdtI3+wcK3MsBwnbB cSgZdC9sAVMAK4LQTe3IJFsjyyZ2arpya/gc5nDmbGwOqKck96SG X-Mailer: git-send-email 2.37.2.672.g94769d06f0-goog Message-ID: <20220826181035.859042-1-ndesaulniers@google.com> Subject: [PATCH 0/3] fix debug info for asm and DEBUG_INFO_SPLIT From: Nick Desaulniers To: Masahiro Yamada Cc: Michal Marek , Nathan Chancellor , Tom Rix , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, x86@kernel.org, Dmitrii Bundin , Fangrui Song , Alexey Alexandrov , Bill Wendling , Greg Thelen , Nick Desaulniers Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Alexey reported that the fraction of unknown filename instances in kallsyms grew from ~0.3% to ~10% recently; Bill and Greg tracked it down to assembler defined symbols, which regressed as a result of: commit b8a9092330da ("Kbuild: do not emit debug info for assembly with LLVM_IAS=1") In that commit, I allude to restoring debug info for assembler defined symbols in a follow up patch, but it seems I forgot to do so in commit a66049e2cf0e ("Kbuild: make DWARF version a choice") Do so requires a fixup for as-option, which seems to be failing when used in scripts/Makefile.debug. Also includes a fix for DEBUG_INFO_SPLIT while I'm here. Dmitrii reports that this has been broken since gcc-11+ & clang-12+. I'm guessing no one uses this .config option...since no one else has reported it being broken yet... Nick Desaulniers (3): Makefile.compiler: s/KBUILD_CFLAGS/KBUILD_AFLAGS/ for as-option Makefile.debug: re-enable debug info for .S files Makefile.debug: set -g unconditional on CONFIG_DEBUG_INFO_SPLIT arch/x86/boot/compressed/Makefile | 5 +++-- scripts/Makefile.compiler | 6 +++--- scripts/Makefile.debug | 26 +++++++++++++++++++------- 3 files changed, 25 insertions(+), 12 deletions(-) -- 2.37.2.672.g94769d06f0-goog