Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0099cb36956090f7c5f3058b353d3555870aea32.camel@ndufresne.ca>
Subject: Re: [PATCH] [media] v4l2: Add AV1, AVS and AVS2 format
From:   Nicolas Dufresne <nicolas@ndufresne.ca>
To:     Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Shi Hao <hao.shi@amlogic.com>
Cc:     linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        mchehab@kernel.org, hans.verkuil@cisco.com,
        hverkuil-cisco@xs4all.nl, ezequiel@vanguardiasur.com.ar,
        sakari.ailus@linux.intel.com, ribalda@chromium.org,
        stanimir.varbanov@linaro.org, nanxin.qin@amlogic.com
Date:   Fri, 26 Aug 2022 14:12:27 -0400
In-Reply-To: <YwiPMOyfXKM8lxIR@pendragon.ideasonboard.com>
References: <20220826030003.1066976-1-hao.shi@amlogic.com>
         <YwiPMOyfXKM8lxIR@pendragon.ideasonboard.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) 
MIME-Version: 1.0
Precedence: bulk

Le vendredi 26 ao=C3=BBt 2022 =C3=A0 12:15 +0300, Laurent Pinchart a =C3=A9=
crit=C2=A0:
> Hello Shi,
>=20
> Thank you for the patch.
>=20
> On Fri, Aug 26, 2022 at 11:00:03AM +0800, Shi Hao wrote:
> > From: "hao.shi" <hao.shi@amlogic.com>
> >=20
> > Add AV1, AVS and AVS2 compressed pixel formats. They are
> > the more common formats.
> >=20
> > Signed-off-by: Shi Hao <hao.shi@amlogic.com>
> > ---
> >  drivers/media/v4l2-core/v4l2-ioctl.c | 3 +++
> >  include/uapi/linux/videodev2.h       | 3 +++
>=20
> The patch also needs to document the formats, in
> Documentation/userspace-api/media/v4l/.
>=20
> >  2 files changed, 6 insertions(+)
> >=20
> > diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-=
core/v4l2-ioctl.c
> > index c314025d977e..7b102c2f59b1 100644
> > --- a/drivers/media/v4l2-core/v4l2-ioctl.c
> > +++ b/drivers/media/v4l2-core/v4l2-ioctl.c
> > @@ -1497,6 +1497,9 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc =
*fmt)
> >  		case V4L2_PIX_FMT_MT21C:	descr =3D "Mediatek Compressed Format"; bre=
ak;
> >  		case V4L2_PIX_FMT_QC08C:	descr =3D "QCOM Compressed 8-bit Format"; b=
reak;
> >  		case V4L2_PIX_FMT_QC10C:	descr =3D "QCOM Compressed 10-bit Format"; =
break;
> > +		case V4L2_PIX_FMT_AV1:		descr =3D "AV1"; break;

A recommendation while adding proper spec/doc. AV1 have multiple representa=
tion,
the exact expected representation should be specified in the doc. This will
avoid similar issues we had with H.264 (Annex B. vs AVCc formats).

> > +		case V4L2_PIX_FMT_AVS:		descr =3D "AVS"; break;
> > +		case V4L2_PIX_FMT_AVS2:		descr =3D "AVS2"; break;

Same things should be checked for these two, they aren't very common outsid=
e of
China, at least I didn't had a chance to play with these so far.

cheers,
Nicolas

> >  		default:
> >  			if (fmt->description[0])
> >  				return;
> > diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videod=
ev2.h
> > index 01e630f2ec78..fa8ec0ddde3d 100644
> > --- a/include/uapi/linux/videodev2.h
> > +++ b/include/uapi/linux/videodev2.h
> > @@ -738,6 +738,9 @@ struct v4l2_pix_format {
> >  #define V4L2_PIX_FMT_FWHT_STATELESS     v4l2_fourcc('S', 'F', 'W', 'H'=
) /* Stateless FWHT (vicodec) */
> >  #define V4L2_PIX_FMT_H264_SLICE v4l2_fourcc('S', '2', '6', '4') /* H26=
4 parsed slices */
> >  #define V4L2_PIX_FMT_HEVC_SLICE v4l2_fourcc('S', '2', '6', '5') /* HEV=
C parsed slices */
> > +#define V4L2_PIX_FMT_AV1      v4l2_fourcc('A', 'V', '1', '0') /* AV1 *=
/
> > +#define V4L2_PIX_FMT_AVS      v4l2_fourcc('A', 'V', 'S', '0') /* AVS *=
/
> > +#define V4L2_PIX_FMT_AVS2     v4l2_fourcc('A', 'V', 'S', '2') /* AVS2 =
*/
> > =20
> >  /*  Vendor-specific formats   */
> >  #define V4L2_PIX_FMT_CPIA1    v4l2_fourcc('C', 'P', 'I', 'A') /* cpia1=
 YUV */
> >=20
> > base-commit: 568035b01cfb107af8d2e4bd2fb9aea22cf5b868
>=20