Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 26 Aug 2022 10:54:31 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Borislav Petkov <bp@alien8.de>, Jane Chu <jane.chu@oracle.com>
CC:     "tony.luck@intel.com" <tony.luck@intel.com>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "x86@kernel.org" <x86@kernel.org>,
        "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
        "dan.j.williams@intel.com" <dan.j.williams@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "hch@lst.de" <hch@lst.de>,
        "nvdimm@lists.linux.dev" <nvdimm@lists.linux.dev>
Subject: Re: [PATCH v7] x86/mce: retrieve poison range from hardware
Message-ID: <630908d7e6937_259e5b29445@dwillia2-xfh.jf.intel.com.notmuch>
References: <20220802195053.3882368-1-jane.chu@oracle.com>
 <YwUFlo3+my6bJHWj@zn.tnic>
 <b3880db6-6731-1d1b-144f-1080a033ad01@oracle.com>
 <Ywf9ZL6zjzSf5pdF@zn.tnic>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Ywf9ZL6zjzSf5pdF@zn.tnic>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xfeBra9bIx5qep4CJI/TN5+2p4405IUb2XQ16eXAYmhslHlZ044Aj9wF5CEy?=
 =?us-ascii?Q?eqWdf6oBxlCwxwyhd/8qEesd9xmU+DY5l3kU1SZuWKqXGKO+p+I2cSqPbAfK?=
 =?us-ascii?Q?EHQCRW/8YsfkU8j5CzBFE3S9A9z1ofoZs4g3wcruDi84YZobfbTFHXOvbOkX?=
 =?us-ascii?Q?marydcGnV8SUVd+CsYyApHJESfF2/ehVq1SWM139WLHoC0J+Hbuv8Sd9vAwu?=
 =?us-ascii?Q?FOUqjBiWwGTxVh/KVVGREQK5d2apr4xO0h0ruljwkkI+BOKx/f2WEoKUJUf4?=
 =?us-ascii?Q?9pIRXnRIfHjopwJTJAG0r8aU9zSkQayTxd3rpQNMYobbK74b9iS3Y0XRVaQf?=
 =?us-ascii?Q?AlIswW86o2i0pPDeMHAjgPPpJbivKvaLdnJeYaCIHEw9JTQGNcgM8aTlGC7L?=
 =?us-ascii?Q?rjZehH5YTbK6z/YxoMu9xPEzXIhpevDisLVqHnB0TaVZSvbg3pU+0yRESmdr?=
 =?us-ascii?Q?HGX5BLo9TWGZgZ4O9lGnpWmUgGWK7Nr3PfG8MhH0J5zZ9jqdR/qikbNUhTar?=
 =?us-ascii?Q?imvd6BoE6muBy55tFlWPIha2l28ZV13GlcWYNuMsT7vMZDoHHk8dUMmWoiCI?=
 =?us-ascii?Q?qWy+IrMYXjokW3xWK+t+SGtlNIEBAXGSCpDQPYeVFlAPybuLrr0qAtL4829a?=
 =?us-ascii?Q?qU3lWJhZybllyK5vnToo6pOD6T4JGKnz05HEu8sb62nmvl1clB3GMVE1jPla?=
 =?us-ascii?Q?CpH0hV1TRhN2TwN3/ubd8lDUaJX7KtylRZX3vhYrE0Rm3F7IbUK6HYZ9EMRb?=
 =?us-ascii?Q?PDb2jMimFsk7yH7RiWyeWHmom/4zrmjVU8HWhLCUQC56J+zqpbKtis9ftt23?=
 =?us-ascii?Q?4ZH7FMXcjBjv6akoq6POeOTJARwcHAoaFerBf4L5GYGXQHQpIRmcBNM6VAzs?=
 =?us-ascii?Q?K2K2klBNsNCqXg5mxiJjLalENPdpNDDm5reZmZf6cG/T+BZv9NIEnj6rWBEh?=
 =?us-ascii?Q?ftNdYW028sB1fNQc5rggjYnlenTWFesVKFEvzXepVlkM/DLuBbOqG8KUayWY?=
 =?us-ascii?Q?Y39s3NI0UqwaM3pqtAlaxUbjCuf0n0B6ls+Coj+bJUnsGdO62nNKLIKQRsx6?=
 =?us-ascii?Q?CpJgbPm05VsSdIt5opM1Ktutb0f131N2Kloro8HWxI58flpFzihnWt3jk5yv?=
 =?us-ascii?Q?9jsU07TpctNlZEsfAxoplJXAZPF1+QJ8ZSK91CrbK4DI+Wylho1wdMwvs3dX?=
 =?us-ascii?Q?961YmfNAIJa0a0lCf9F+KH0zF9IBG4V1DUGJctan+PZNGbiOZQMs0Y+bToS0?=
 =?us-ascii?Q?GXAvIhaHDf4gaAbw0qhw+08TP6GSHHTGC2/x88PLzuM+KgimmlreOo2J89wn?=
 =?us-ascii?Q?fRDH19OgLU/GcLQm3H8adf9efAu5z3k3xuyLszTpfzlm+DSHA02DH6+cBegC?=
 =?us-ascii?Q?NX+QLX46skKAKZuEPr/AOkaFzp1P0ebyVJAsp3uYtVWal/3FAneGLB7TP18E?=
 =?us-ascii?Q?8AvoXg3lJ305XojXvczzWvG4mIO+sWCcYuvI5nyLgGSxlTmnHqwawgXWet35?=
 =?us-ascii?Q?mSGBrVO/kpumsQhIXdxKkwknNd4Z6QiJmepQfeTHmpAskvw688ahNGNCOliN?=
 =?us-ascii?Q?PItc0EJ/0V6LNU8v+/yyyJRye9BhD0AkuTtzzYj8CCZvaAkRS0ELNPjYxCAC?=
 =?us-ascii?Q?wA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 70499d97-acc2-4d55-b18f-08da878c0930
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2126.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2022 17:54:34.7891
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FE2hcl+PULW4zzYXN9RhYHjr5Nh+lBpd122J+F5EGPJQyW2JgnF3hRGfjHZqZ8LL5jYbr1pQyr77cZ5hUAUC315qPy3kXHs6f2wPg/v1/ls=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4092
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Borislav Petkov wrote:
> On Thu, Aug 25, 2022 at 04:29:47PM +0000, Jane Chu wrote:
> > Tony has replied.
> 
> Do you really think that I can't look up what field means?
> 
> What I said was
> 
> "What I'm missing from this text here is... "
> 
> IOW, what I'm trying to say is, you should formulate your commit message
> better, more human-friendly. Right now it reads like for insiders only.
> But that's not its purpose.
> 
> Do you catch my drift?

How about:

---

When memory poison consumption machine checks fire,
mce-notifier-handlers like nfit_handle_mce() record the impacted
physical address range. The error information includes data about blast
radius, i.e. how many cachelines did the hardware determine are
impacted. A recent change, commit 7917f9cdb503 ("acpi/nfit: rely on
mce->misc to determine poison granularity"), updated nfit_handle_mce()
to stop hard coding the blast radius value of 1 cacheline, and instead
rely on the blast radius reported in 'struct mce' which can be up to 4K
(64 cachelines).

It turns out that apei_mce_report_mem_error() had a similar problem in
that it hard coded a blast radius of 4K rather than checking the blast
radius in the error information. Fix apei_mce_report_mem_error() to
convey the proper poison granularity.

---