Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp646590rwe; Fri, 26 Aug 2022 11:28:16 -0700 (PDT) X-Google-Smtp-Source: AA6agR4Vg+Q98GkCr7OMXtHQ6T2wmkfn/h39QVpLjwn2S/01/zc+Pi5lGRAmVT3V4HSFCxvpgKbq X-Received: by 2002:a17:907:b10:b0:73d:bedd:3121 with SMTP id h16-20020a1709070b1000b0073dbedd3121mr5955044ejl.530.1661538496595; Fri, 26 Aug 2022 11:28:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661538496; cv=none; d=google.com; s=arc-20160816; b=SsnTVHO5RM8lmF/XnZNUQm5NfWDR49LLoaUzFl+po9/O/Lp1qRaGxBGeIAKM6mI/Sd mw16eMhkPCr7rgB8hHZ2m/h5qL0E5oOAXdOl2vFLSZ38ADpfmhMKm3OwwVwUbAxqngYU jc8tHvLM1IEzDsXLTQqTDwe/tkhLdSiFbcCebT+K0FkYN6A65zIsGQmrRjjJ2NbjOju8 P9ZJRFXmo9Caw0gAATv+o1Ptikv8d0WzNhGx1nz9xJSvjyKtVsJkSTjMV80uZc6ofqwu WNp0aZLzFktyH82QnI7CZ0rIBZbviptWb6NVJ0YYUxoMAfS63BK/n2sxwmLk1V3aFsBB nm6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=+qlRjnbHsYMoK3QE6kiB3Jz6gVVo3eCKxIUxzMEtgRE=; b=qoaNbeX8mf/PyEH92G2ZaNLRxjRecdtHu9gnIC4oCjFJiadXYh5zcY3Gp0d248S3pV X7Fw7Y4Z8ZhxFLhxz0GU51UqgJdfNVZosfWADDbACxRXMmnNZpNk0ve2MsawyNAo7lh2 TL0Jc5FCC3mQBQV62PS5xHiUT4RRdL9R9Qds6LEAx74izesSg/12InoNzwFyGKPABQ9q m8U3K+MYUC5ltMxb94YII3oaU2yi/Z7yvViZL5OuF3iWOZO3HIL4424ujqVKIrZVenSj dfRXvFOQDBor7sE2+GFD45oNotSaK3p3Bmsd6f8d4JF1s1GZKI/PiFc+us16AKjSgZbK Hn7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mhzUWSwY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bk8-20020a170906b0c800b007317ad1f9a4si1569455ejb.310.2022.08.26.11.27.48; Fri, 26 Aug 2022 11:28:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mhzUWSwY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235364AbiHZS02 (ORCPT + 99 others); Fri, 26 Aug 2022 14:26:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229676AbiHZS0Z (ORCPT ); Fri, 26 Aug 2022 14:26:25 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E211D2B35; Fri, 26 Aug 2022 11:26:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id EAAC1B8321E; Fri, 26 Aug 2022 18:26:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B0249C433D6; Fri, 26 Aug 2022 18:26:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661538382; bh=+qlRjnbHsYMoK3QE6kiB3Jz6gVVo3eCKxIUxzMEtgRE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mhzUWSwY5d35iJf9L5F5I50510BX9NsD4S2WE6x0E6varC3ZhrJ4UpoizZi2j1+gN NJ8BaetmR5YzcwGCfO2DNieytqrh/jLzDveoWZL0mD+mSoczL3H346vPZw+12d/6BL AS9A0BIIkapqGL97vA8DEs1nOtzX9SppeUPFBXbqSAQNauU7QutNfWbNgKfYJCdzEO JCAXa0rQ7Yw2sUjxfEnAeFufB0BN6GZ43N8iUlOyakIKNPwNFWxFfBJb/5+UE6dJQ/ TR91oZ8DwsPRhRNtDXaMNybaBK4xxXwuEcsb5/yNOt6bPxj2Euz6yk1uTZq7NXlQgJ VHNdeD4xY/52g== Date: Fri, 26 Aug 2022 19:26:20 +0100 From: Mark Brown To: Christophe JAILLET Cc: shreeya.patel@collabora.com, alvaro.soliverez@collabora.com, kernel@collabora.com, krisman@collabora.com, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, sanju.mehta@amd.com, tanureal@opensource.cirrus.com Subject: Re: [PATCH v3] spi: amd: Configure device speed Message-ID: References: <20220825143132.253224-1-shreeya.patel@collabora.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Xf0FWGmO80sZj8xR" Content-Disposition: inline In-Reply-To: X-Cookie: Necessity is a mother. X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Xf0FWGmO80sZj8xR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Aug 26, 2022 at 08:44:31AM +0200, Christophe JAILLET wrote: > So, if the requested value is one of the table, nothing is done and it can't > be selected. > Is it what is expected? > Without looking at the rest of the code or at the driver, I don't see the > point of this test. No, the speed should be selected. --Xf0FWGmO80sZj8xR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmMJEEsACgkQJNaLcl1U h9D+RAf/VR65AY/CdkxjG6ff7Hu+K9SqwRyjLj538PyR5+tIH6JjKE3IRwFEyoHe d/SV0bLRiwnoShQYxyWZSAQk22YeOJ7/EHZZcLE094awqBJFotxhFOtHetwlcvc8 k6jVsLHY/ZBVIa5JY1hOr7UFLJXuooC8G1/PL3YwYeWogRXbG9PFZvFnC+zjP1cS XHBIC0ao6XFrByTXrZPnaB+8BHnJeHg1YT93CE/LVVITCm60+kRRxpYThdOFJnN3 EFgQ2AZb08iBSkEBIougUBoTiZlAZm4+3UeTNPGf+odasAwodCHNib1L7Yvvk0+7 XjVvOvyQKNkCz236Ww4wxPJvbdkHjA== =ho+M -----END PGP SIGNATURE----- --Xf0FWGmO80sZj8xR--