Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <CABwm_eTnARC1GwMD-JF176k8WXU1Z0+H190mvXn61yr369qt6g@mail.gmail.com>
 <YwfYyLE3ajSFVHGQ@kernel.org> <CABwm_eSvcnygceTU0sNXLkBFaNfEfrThFVmwH=TS4hN=HVGrGg@mail.gmail.com>
In-Reply-To: <CABwm_eSvcnygceTU0sNXLkBFaNfEfrThFVmwH=TS4hN=HVGrGg@mail.gmail.com>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Fri, 26 Aug 2022 11:32:22 -0700
Message-ID: <CAM9d7cjsbhHnaAiHSBb6qAfH0bNgdKrBHdg16esRCt+4DPmvtQ@mail.gmail.com>
Subject: Re: [PATCH] perf/genelf: Switch deprecated openssl MD5_* functions to
 new EVP API
To:     Zixuan Tan <tanzixuan.me@gmail.com>
Cc:     Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        linux-perf-users <linux-perf-users@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hello,

On Fri, Aug 26, 2022 at 10:22 AM Zixuan Tan <tanzixuan.me@gmail.com> wrote:
>
> On Fri, Aug 26, 2022 at 4:17 AM Arnaldo Carvalho de Melo
> <arnaldo.melo@gmail.com> wrote:
> >
> > Em Fri, Aug 26, 2022 at 01:00:58AM +0800, Zixuan Tan escreveu:
> > > Switch to the flavored EVP API like in test-libcrypto.c, and remove the
> > > bad gcc #pragma.
> > >
> > > Inspired-By: 5b245985a6de ("tools build: Switch to new openssl API for
> > > test-libcrypto")
> >
> > How did you test the end result? Can you please describe step by step?
> >
> > Also please consider adding a 'perf test' entry to make sure this
> > doesn't regress.
>
> Sorry but I don't get what you mean, what results do I need to test?
>
> These EVP_* APIs are just replacements for the deprecated MD5_* APIs in
> openssl v3 [1][2]. With the same input, they produce the same MD5 digest.
>
> And this patch just does the migration work for the upgrade and does not
> change the logic of the code. so...what should I test?

Yeah, I understand that this merely changes the MD5 APIs.
While it's good to have a test case for the genelf code, I don't think
it belongs to this patch.  So,

Acked-by: Namhyung Kim <namhyung@kernel.org>


>
> Links:
> [1] https://www.openssl.org/docs/man3.0/man3/MD5.html
> [2] https://stackoverflow.com/questions/69806220/advice-needed-for-migration-of-low-level-openssl-api-to-high-level-openssl-apis