Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Song Liu <songliubraving@fb.com>
To:     Namhyung Kim <namhyung@kernel.org>
CC:     Song Liu <song@kernel.org>,
        Andrii Nakryiko <andrii.nakryiko@gmail.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>, Martin Lau <kafai@fb.com>,
        Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Stanislav Fomichev <sdf@google.com>,
        Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>,
        "bpf@vger.kernel.org" <bpf@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH bpf-next] bpf: Add bpf_read_raw_record() helper
Thread-Topic: [PATCH bpf-next] bpf: Add bpf_read_raw_record() helper
Thread-Index: AQHYtzPeWFYcAGzsN0Wstq4jJDfNwK3AJloAgAAJpYCAAA9aAIAAO0MAgAAulQCAAAilAIAAsuMAgAAazgCAAAnxgA==
Date:   Fri, 26 Aug 2022 18:44:58 +0000
Message-ID: <FCC75F8E-4C2F-42A4-B582-9BE3BB87E15A@fb.com>
References: <20220823210354.1407473-1-namhyung@kernel.org>
 <CAEf4Bzbd0-jGFCSCJu3eDxxom42xnH9Tevq0n50-AajjHb5t3g@mail.gmail.com>
 <A9E2E766-E8A2-4E2E-A661-922400D2674D@fb.com>
 <CAEf4BzbGf6FuM7VcnA7HKb33HJeJjrDuydC4h1_tCUB8sPCW2g@mail.gmail.com>
 <E215461A-01E7-4677-A404-C4439D66A7AF@fb.com>
 <CAM9d7cgigkU8quUMpScL=Xt8+WLDVXKiF5xdKiz7BbDPibSNjg@mail.gmail.com>
 <CAPhsuW5V1U_UTHQw9E80vCTeP4Jqg9Ta8B+7o3pybKB=8CGRFA@mail.gmail.com>
 <CAM9d7cjTtOkRHLOosxHN8PcbVbhTK=uLDGjw8N5=1QiTHcd6rQ@mail.gmail.com>
 <C7F3F33B-4A8E-428C-9FED-FB635955C2B1@fb.com>
In-Reply-To: <C7F3F33B-4A8E-428C-9FED-FB635955C2B1@fb.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Dedg7hGjNkbDXDInjRy6m1Z7hi+Pr1WTwQ0mvCMsTupV8UP7DNNt4LjmyKOT?=
 =?us-ascii?Q?Q1wQ9OPEJ+xAEpUTgw4UBtitpEpdQ4Vr4pkhHFIKCG95Gp+NOC2un7l/JMsu?=
 =?us-ascii?Q?Bs/zTWfKIA30Tl9J71kHgrT29/0mn+dwZE0C96PHNw/Ptu6mmie4w02zD1GT?=
 =?us-ascii?Q?YbNol/lNHuN22kKi1rBbiG7XHUpDi4JZ/Q8AV3uOOaWV8BhCUjRZT8mixo/E?=
 =?us-ascii?Q?JIAHhol+GJTlg+orHkWcy05wy4bBx4QZtbJnk+GiSA28s161fgxBZ7jeDIAt?=
 =?us-ascii?Q?93+998YYSvDwy84EpmV9j08qTDdsgjWUJnANNkudGXu/RgTVPdAHUpiDGB/Q?=
 =?us-ascii?Q?idm1m8GI77UGhutI5ttv5GNb3UxZJfdudGR60GuO/Vaj+mQsxlB5ihFMwUWz?=
 =?us-ascii?Q?VRoL0UDSPoD3H9zotkYe3fVYDJAEZmeHpSRLhw2SVprh9epjnoE7e6EC03Ph?=
 =?us-ascii?Q?1mY1Pf9noXqQCoSveyx1tkIqksFolxteJAgqqHekvVkNUn5wFpRktO3es5MT?=
 =?us-ascii?Q?cCyAG4G+36vWSUsy6y0Q4DUWu6vqbmEP0ZbBaulPzDGF43RjVeASv04izCf0?=
 =?us-ascii?Q?9fCtCw8xFuI9XHJdn5UNXeUwk7Bn1EIpCuRlvDcekVFQ2ge9+49e64RY1/r9?=
 =?us-ascii?Q?/C7mwZICOVd3JoMDx8sxg5qqspVkaR4jR04DcfUusfF2QVdXvkNCGv/G0FQ2?=
 =?us-ascii?Q?n1dpF73yggmrQGk8PPT6x1cJQJzHQJa/74UB9pt73loGwvS7O+op+pjS+Rfx?=
 =?us-ascii?Q?mkF06D8rWgXEidW9xykGXXltAW55JFE/RHCWYzvwxbHbzPQkbtF8svfxRmHn?=
 =?us-ascii?Q?6mr5SYP9xKdXoHodX9UqQdidIySh6T+4+3db++AXp1c7wTOAwvBuljXk2fTF?=
 =?us-ascii?Q?0YFcIn2TpfusuTPX/Ez06v4y6Ap5WSQQKNVHn0UWfg59sLb3m6ad36jAlOvC?=
 =?us-ascii?Q?zQBCoQGDr5YtM6+KzY3Z5kYFcbvfd9U1ng246hfgBFC3xTE4Be0jZx0x94e0?=
 =?us-ascii?Q?Q/tE/LMgXwNPt2Jfl3olUCazMHckbnnhLq6+oLYFSfuMPEaAeZ1cQcNP1II5?=
 =?us-ascii?Q?31+V5znv/FUue8IYTuD3eHhhxCKEi+Iy5F2AJKe6RGeJgzzSqJxtKkgKl7e9?=
 =?us-ascii?Q?3MUHskTG8E3pJUw4gIiP8cjV/LpiWHmGuozFRaRXQO8EFZUzlGBgkMS1wi9O?=
 =?us-ascii?Q?D0MdKRKaSU/1upiZVPL74pXU5I26kx2cZKV1l3RM9J5aR1N0h+z8GCgCOKeX?=
 =?us-ascii?Q?vDQRGCrsbCESo/SV+KXYfz0NOZL84DVoRe4pxSRA+lf97hY4PGjn2qFWiIN1?=
 =?us-ascii?Q?mQKrDdUZeBHK9PjmZTuXl1rYE927VdTElK+a66r4FZKqPmqi9KFqBI3eu3Bp?=
 =?us-ascii?Q?EvT7ILqm5Oz7Zv7iYtxfzJ6AcTdtfla+UniMychW6jkj1N34GR6UAECCi089?=
 =?us-ascii?Q?ga3dJ7aQ3mHBMY1inFYf6wpgL+b/Rq173F4lALIc0YiZgHFt2Wkkmmpv2lOA?=
 =?us-ascii?Q?8ZCQ1zzGFSnQ3Rp8YVpabCuOvP1ug0GY6OF8wkUYfTE34Thr2SjhhrcCtFgv?=
 =?us-ascii?Q?DwymNhafYwTd25TzefFc/IpTZ/gabiDYMPcqo5I5veXQy3jm/6UNYTf+Aj+b?=
 =?us-ascii?Q?FGYITd6p5KGHpbo2LxnO5Zs=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <B392E81C237820498469EF8A68A8E473@namprd15.prod.outlook.com>
MIME-Version: 1.0
X-OriginatorOrg: fb.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR15MB5109.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8135152f-0eef-429e-5791-08da879313a6
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Aug 2022 18:44:58.5488
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: WtIU6JsQDCfdwH0SIPM7xrIFnw/w5dn6MaViBAAxZJoXNwr2fs2cAtuLlXDj4QzmZi8jY9HXrR7li+9ua50xAQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB3191
X-Proofpoint-GUID: MeZ0K8s-1LtWzQY5LZPU4SDPjc-dVZlT
X-Proofpoint-ORIG-GUID: MeZ0K8s-1LtWzQY5LZPU4SDPjc-dVZlT
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-26_10,2022-08-25_01,2022-06-22_01
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Aug 26, 2022, at 11:09 AM, Song Liu <songliubraving@fb.com> wrote:
> 
> 
> 
>> On Aug 26, 2022, at 9:33 AM, Namhyung Kim <namhyung@kernel.org> wrote:
>> 
>> On Thu, Aug 25, 2022 at 10:53 PM Song Liu <song@kernel.org> wrote:
>>> 
>>> On Thu, Aug 25, 2022 at 10:22 PM Namhyung Kim <namhyung@kernel.org> wrote:
>>>> 
>>>> On Thu, Aug 25, 2022 at 7:35 PM Song Liu <songliubraving@fb.com> wrote:
>>>>> Actually, since we are on this, can we make it more generic, and handle
>>>>> all possible PERF_SAMPLE_* (in enum perf_event_sample_format)? Something
>>>>> like:
>>>>> 
>>>>> long bpf_perf_event_read_sample(void *ctx, void *buf, u64 size, u64 flags);
>>>>> 
>>>>> WDYT Namhyung?
>>>> 
>>>> Do you mean reading the whole sample data at once?
>>>> Then it needs to parse the sample data format properly
>>>> which is non trivial due to a number of variable length
>>>> fields like callchains and branch stack, etc.
>>>> 
>>>> Also I'm afraid I might need event configuration info
>>>> other than sample data like attr.type, attr.config,
>>>> attr.sample_type and so on.
>>>> 
>>>> Hmm.. maybe we can add it to the ctx directly like ctx.attr_type?
>>> 
>>> The user should have access to the perf_event_attr used to
>>> create the event. This is also available in ctx->event->attr.
>> 
>> Do you mean from BPF?  I'd like to have a generic BPF program
>> that can handle various filtering according to the command line
>> arguments.  I'm not sure but it might do something differently
>> for each event based on the attr settings.
> 
> Yeah, we can access perf_event_attr from BPF program. Note that
> the ctx for perf_event bpf program is struct bpf_perf_event_data_kern:
> 
> SEC("perf_event")
> int perf_e(struct bpf_perf_event_data_kern *ctx)
> {	
> 	...
> }
> 
> struct bpf_perf_event_data_kern {
>        bpf_user_pt_regs_t *regs;
>        struct perf_sample_data *data;
>        struct perf_event *event;
> };
> 
> Alternatively, we can also have bpf user space configure the BPF 
> program via a few knobs. 
> 
> And actually, we can just read ctx->data and get the raw record, 
> right..?

Played with this for a little bit. ctx->data appears to be not 
reliable sometimes. I guess (not 100% sure) this is because we 
call bpf program before event->orig_overflow_handler. We can 
probably add a flag to specify we want to call orig_overflow_handler
first. 

Thanks,
Song