Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Song Liu <songliubraving@fb.com>
To:     Namhyung Kim <namhyung@kernel.org>
CC:     Song Liu <song@kernel.org>,
        Andrii Nakryiko <andrii.nakryiko@gmail.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>, Martin Lau <kafai@fb.com>,
        Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Stanislav Fomichev <sdf@google.com>,
        Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>,
        "bpf@vger.kernel.org" <bpf@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH bpf-next] bpf: Add bpf_read_raw_record() helper
Thread-Topic: [PATCH bpf-next] bpf: Add bpf_read_raw_record() helper
Thread-Index: AQHYtzPeWFYcAGzsN0Wstq4jJDfNwK3AJloAgAAJpYCAAA9aAIAAO0MAgAAulQCAAAilAIAAsuMAgAAazgCAABQ9AIAAGUIA
Date:   Fri, 26 Aug 2022 20:52:13 +0000
Message-ID: <BCF27304-3F49-4B8B-B1FE-D785370BB9A5@fb.com>
References: <20220823210354.1407473-1-namhyung@kernel.org>
 <CAEf4Bzbd0-jGFCSCJu3eDxxom42xnH9Tevq0n50-AajjHb5t3g@mail.gmail.com>
 <A9E2E766-E8A2-4E2E-A661-922400D2674D@fb.com>
 <CAEf4BzbGf6FuM7VcnA7HKb33HJeJjrDuydC4h1_tCUB8sPCW2g@mail.gmail.com>
 <E215461A-01E7-4677-A404-C4439D66A7AF@fb.com>
 <CAM9d7cgigkU8quUMpScL=Xt8+WLDVXKiF5xdKiz7BbDPibSNjg@mail.gmail.com>
 <CAPhsuW5V1U_UTHQw9E80vCTeP4Jqg9Ta8B+7o3pybKB=8CGRFA@mail.gmail.com>
 <CAM9d7cjTtOkRHLOosxHN8PcbVbhTK=uLDGjw8N5=1QiTHcd6rQ@mail.gmail.com>
 <C7F3F33B-4A8E-428C-9FED-FB635955C2B1@fb.com>
 <CAM9d7cgUVg1Cv+0fs=Mc7OBTOHNJkMqWnm0SZ5R7xfm5peBNDQ@mail.gmail.com>
In-Reply-To: <CAM9d7cgUVg1Cv+0fs=Mc7OBTOHNJkMqWnm0SZ5R7xfm5peBNDQ@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GDs0sdM7Ck+WLV4Z4x+zKRyrsqLQ2tHBYIm8fgB0IqsCCmA/bA6fKV92ibwS?=
 =?us-ascii?Q?xiurVNQZSrHyTOtow4XWHlNA5GPogwdMEJF0dT4ExzSOLn/KSo4YFJbpuJaU?=
 =?us-ascii?Q?tkBdSICzJ1Gf5YFr40Rfu7AwzSWS92yyQ7HrBG8X2aknw1weapes6MUuJrWS?=
 =?us-ascii?Q?tygfODWB5MxVKEP456qmV55CBOjOenNstOA77DFMVkn9ZbbWkXLlB0fho3yz?=
 =?us-ascii?Q?U3HEZeWuR+VGnl6n1IC9v8tHt2lzkQwb7PlsYhU9kt+q8qqcSKAIbFA4alDq?=
 =?us-ascii?Q?QfWvAhVMkp0mXxgAYoC9EWr6XCFncndVPze+FSQ3BLSCDQiB+8r+4UhFuR/X?=
 =?us-ascii?Q?EKMInkI7Rzagt+B95cgH3VeUUX7H/Of4Z7B75WDflCEXzBrntqFxX3h/a9tI?=
 =?us-ascii?Q?AOM+1mlxDz1SQ5PXt6YjJNdGmfRzjXkV6OR3PH8Jwy+Wce677OQJUF9K1pYY?=
 =?us-ascii?Q?lSNmn+B7rP5dDDQqTR5buJkykhkBHoGf+cz3LANuxDxi+war67thm6EojBnG?=
 =?us-ascii?Q?G314ehy46FkB7Okso5PuktpF3zVZSbAZarLTwDMVptR5rCs0FyNZaqxNGTTg?=
 =?us-ascii?Q?M8A0QeJ0yMh1TDn365OddBBNgcncA71GT2pbITKICRbgDzB6q7ShJpXgGuoL?=
 =?us-ascii?Q?vnH7Lk5+K0BmZhWOjqPBk4X06HW/xguyhmHqweP03P51QA+Yv5A8QYQ0BuuC?=
 =?us-ascii?Q?Q/5yT5mVG9Uqw7QBAyY3UGn40s3JQm1vv31/cAWRpWluLiNs4fHyckfl0Kwn?=
 =?us-ascii?Q?YAZsLEsMKJ1yZ+TGQkooNGc0wfpyJLZq4C2wjgyLJsRY+WdXUPMCdYrsnPGP?=
 =?us-ascii?Q?AMt2pVfm6b4ya4NIXye19XGvhOi6zcfMBEEPLfRxnRPW05OVy7kPFLLMnTHZ?=
 =?us-ascii?Q?/T9iM38Fr2FcIz5K7JVrrPo3m/u2Q3AWeUq0vBZwlx0tcfAtwrGKOOFOta1W?=
 =?us-ascii?Q?SG0TZIj3iL8nKTL1/XnMVaSxubmvtkhmfuyXQ0Ol0m8fmj60hIyMx64TGtmZ?=
 =?us-ascii?Q?/XtlevGajULhTuRJ2JvdzlYosqX0ikRfTmIXHTpgO2eXYjDtnk6/CTDo+SLW?=
 =?us-ascii?Q?I/87yJzkQzsiPkaQxrGHonCPT/am0gvhopp0Nfp71bRP3LSydsYzGz5B1WYh?=
 =?us-ascii?Q?qoOtu8/aGIVWmJ9M8H0sK/Nj7xoi6UqDX3w5L7cW8okbGhWCrWM0gwKGvwk2?=
 =?us-ascii?Q?kHcoHc1SidvLgpBuG0jsG7orsvzPZtzfpk1D0QEKxu+ThR1OaS5dnswg97BB?=
 =?us-ascii?Q?WWsL1ZmNmsgebq18OZy2faXYfNVhlNkCZjtUcNBgvb71gsT7ZZ1SoInb24aq?=
 =?us-ascii?Q?gI5fSbQe5Sz82ImcVrdXWjUAR7+9hoIXWDLm1fYNqY6WwouVKejaJKJM3xx8?=
 =?us-ascii?Q?9SItqB9J01JjfTfHsQNlPWHmXqLwb1PXZqJUX+aiI2+zMnoBXhtb5yW61g6Q?=
 =?us-ascii?Q?F4FWr2VpJZaSbaIFSLpguFAA3J4wSD+D2aPkctVAAAxzEi9wegmL8XvcU9eB?=
 =?us-ascii?Q?Xlad4hI6hkt4t0qn0pk0830tOYcN3C45dk9X6X96MtlQoXuvVEC3vOoyxSYo?=
 =?us-ascii?Q?DgQUrclu3IK+8UIrIX95gGkVrTdJFv2Xyn7I7anu80NYS71CxcBLzBNsaWZy?=
 =?us-ascii?Q?Z6J7H2xE2pE23ulBJarocvg=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <30EF321B431B444E974DF7B8A9D3B2D4@namprd15.prod.outlook.com>
MIME-Version: 1.0
X-OriginatorOrg: fb.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR15MB5109.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c91b6d14-acf9-49fc-863c-08da87a4da5a
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Aug 2022 20:52:13.3786
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: JlLTybxcOjUuNcEuKsvPJzlWad1+3egPxVgf6YipQRP0f1ixDrqgurh5FAEbLrA5D+GO1dqJGRyES2A6H18v1A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR15MB1201
X-Proofpoint-GUID: oMCD0Ofw8ZbTLvKqKLWQ_pMKiKae2i-Q
X-Proofpoint-ORIG-GUID: oMCD0Ofw8ZbTLvKqKLWQ_pMKiKae2i-Q
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-26_12,2022-08-25_01,2022-06-22_01
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Aug 26, 2022, at 12:21 PM, Namhyung Kim <namhyung@kernel.org> wrote:
> 
> On Fri, Aug 26, 2022 at 11:09 AM Song Liu <songliubraving@fb.com> wrote:
>> 
>> 
>> 
>>> On Aug 26, 2022, at 9:33 AM, Namhyung Kim <namhyung@kernel.org> wrote:
>>> 
>>> On Thu, Aug 25, 2022 at 10:53 PM Song Liu <song@kernel.org> wrote:
>>>> 
>>>> On Thu, Aug 25, 2022 at 10:22 PM Namhyung Kim <namhyung@kernel.org> wrote:
>>>>> 
>>>>> On Thu, Aug 25, 2022 at 7:35 PM Song Liu <songliubraving@fb.com> wrote:
>>>>>> Actually, since we are on this, can we make it more generic, and handle
>>>>>> all possible PERF_SAMPLE_* (in enum perf_event_sample_format)? Something
>>>>>> like:
>>>>>> 
>>>>>> long bpf_perf_event_read_sample(void *ctx, void *buf, u64 size, u64 flags);
>>>>>> 
>>>>>> WDYT Namhyung?
>>>>> 
>>>>> Do you mean reading the whole sample data at once?
>>>>> Then it needs to parse the sample data format properly
>>>>> which is non trivial due to a number of variable length
>>>>> fields like callchains and branch stack, etc.
>>>>> 
>>>>> Also I'm afraid I might need event configuration info
>>>>> other than sample data like attr.type, attr.config,
>>>>> attr.sample_type and so on.
>>>>> 
>>>>> Hmm.. maybe we can add it to the ctx directly like ctx.attr_type?
>>>> 
>>>> The user should have access to the perf_event_attr used to
>>>> create the event. This is also available in ctx->event->attr.
>>> 
>>> Do you mean from BPF?  I'd like to have a generic BPF program
>>> that can handle various filtering according to the command line
>>> arguments.  I'm not sure but it might do something differently
>>> for each event based on the attr settings.
>> 
>> Yeah, we can access perf_event_attr from BPF program. Note that
>> the ctx for perf_event bpf program is struct bpf_perf_event_data_kern:
>> 
>> SEC("perf_event")
>> int perf_e(struct bpf_perf_event_data_kern *ctx)
>> {
>>        ...
>> }
>> 
>> struct bpf_perf_event_data_kern {
>>        bpf_user_pt_regs_t *regs;
>>        struct perf_sample_data *data;
>>        struct perf_event *event;
>> };
> 
> I didn't know that it's allowed to access the kernel data directly.
> For some reason, I thought it should use fields in bpf_event_event_data
> only, like sample_period and addr.  And the verifier will convert the
> access to them according to pe_prog_convert_ctx_access().

We can bypass pe_prog_convert_ctx_access() with something like:

	struct perf_event *event;
	u64 config;

        bpf_probe_read_kernel(&event, sizeof(void *), &ctx->event);
        bpf_probe_read_kernel(&config, sizeof(u64), &event->attr.config);

Thanks,
Song