Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754901AbXFNRYu (ORCPT ); Thu, 14 Jun 2007 13:24:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752462AbXFNRYo (ORCPT ); Thu, 14 Jun 2007 13:24:44 -0400 Received: from mail.screens.ru ([213.234.233.54]:37454 "EHLO mail.screens.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751254AbXFNRYo (ORCPT ); Thu, 14 Jun 2007 13:24:44 -0400 Date: Thu, 14 Jun 2007 21:24:39 +0400 From: Oleg Nesterov To: Evgeniy Polyakov Cc: Andrew Morton , Benjamin Herrenschmidt , Roland McGrath , linux-kernel@vger.kernel.org Subject: w1_therm_read_bin: suspicious usage of flush_signals() Message-ID: <20070614172439.GA2468@tv-sign.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 494 Lines: 19 drivers/w1/slaves/w1_therm.c:w1_therm_read_bin() while (tm) { tm = msleep_interruptible(tm); if (signal_pending(current)) flush_signals(current); } current is user-space task, yes? this looks just wrong, could you please explain? Oleg. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/