Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Song Liu <songliubraving@fb.com>
To:     Namhyung Kim <namhyung@kernel.org>
CC:     Song Liu <song@kernel.org>,
        Andrii Nakryiko <andrii.nakryiko@gmail.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>, Martin Lau <kafai@fb.com>,
        Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Stanislav Fomichev <sdf@google.com>,
        Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>,
        "bpf@vger.kernel.org" <bpf@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH bpf-next] bpf: Add bpf_read_raw_record() helper
Thread-Topic: [PATCH bpf-next] bpf: Add bpf_read_raw_record() helper
Thread-Index: AQHYtzPeWFYcAGzsN0Wstq4jJDfNwK3AJloAgAAJpYCAAA9aAIAAO0MAgAAulQCAAAilAIAAsuMAgAAazgCAAAnxgIAADKuAgAAYuoCAAAP0AIAAA5MA
Date:   Fri, 26 Aug 2022 21:25:45 +0000
Message-ID: <1CA3FC40-BC8D-4836-B3E7-0EB196DE6E66@fb.com>
References: <20220823210354.1407473-1-namhyung@kernel.org>
 <CAEf4Bzbd0-jGFCSCJu3eDxxom42xnH9Tevq0n50-AajjHb5t3g@mail.gmail.com>
 <A9E2E766-E8A2-4E2E-A661-922400D2674D@fb.com>
 <CAEf4BzbGf6FuM7VcnA7HKb33HJeJjrDuydC4h1_tCUB8sPCW2g@mail.gmail.com>
 <E215461A-01E7-4677-A404-C4439D66A7AF@fb.com>
 <CAM9d7cgigkU8quUMpScL=Xt8+WLDVXKiF5xdKiz7BbDPibSNjg@mail.gmail.com>
 <CAPhsuW5V1U_UTHQw9E80vCTeP4Jqg9Ta8B+7o3pybKB=8CGRFA@mail.gmail.com>
 <CAM9d7cjTtOkRHLOosxHN8PcbVbhTK=uLDGjw8N5=1QiTHcd6rQ@mail.gmail.com>
 <C7F3F33B-4A8E-428C-9FED-FB635955C2B1@fb.com>
 <FCC75F8E-4C2F-42A4-B582-9BE3BB87E15A@fb.com>
 <CAM9d7cj6YNTL+u38PZjhPF2Qg_BYiJ1NMmDkPDx3N3Xe+ZTbyA@mail.gmail.com>
 <FD49F694-10FA-4346-8303-E1E185C3E6E4@fb.com>
 <CAM9d7cjj0X90=NsvdwaLMGCDVkMJBLAGF_q-+Eqj6b44OAnzoQ@mail.gmail.com>
In-Reply-To: <CAM9d7cjj0X90=NsvdwaLMGCDVkMJBLAGF_q-+Eqj6b44OAnzoQ@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RdnFflkZCnVWI0AvdocUDQqyRDWJt4YCDO7Ho0NN354AsdqpNbwC0Uv78jer?=
 =?us-ascii?Q?hcy6uhxYBrp0fWhA1Uae5SSbnL/4+quy5G9nhZt1ZMEye1URr4nG4wNo43ka?=
 =?us-ascii?Q?pyGLMeqS73Mk+IdkFeeBFMOHeVgceKCl1Y4wQDNnk6VPZPFPW+1P35+TGYEU?=
 =?us-ascii?Q?ijb20lFmQC7V0Py8qb5YXyozhQSOZK3WDR+NHh9jMfGILqql+UMHBgz4puTm?=
 =?us-ascii?Q?tBSVHe4SZN7OIiM5Sm6lX1+vWjDyUPyy8+4zRCF9IZc8slh04j/vC2S4y5br?=
 =?us-ascii?Q?PgAayIMMtAx/pjT4iMpGHV7grUPzxn0AXJ8K3/9sZ4uX6dlls54LkCX3MUOf?=
 =?us-ascii?Q?ndjKDSL+N3EDjOPc1fVcR4Vfu/iziQnJdIZchDxRYSDdotAcnfzihw+D0XR9?=
 =?us-ascii?Q?ekN0cVCX4aywecuXrs6Vseler/LmXQLwS0cZh7BME9tlwSFzO7VHIcvqozHj?=
 =?us-ascii?Q?xrT++9MI5NGd0XLCpTfUfAUmuDTEjGjTldl1d3DBWC5obmJ1Qo2shQhtUL0g?=
 =?us-ascii?Q?LKAc2GoLzKwW9dluJV5Sm+PnDCLQfzUMfDVXIZUS+4ejAutUud3h4kbSHSJ+?=
 =?us-ascii?Q?EpBw5/IiJuL2dT/hKoPfYoQOD4HSrrUeAtreYOQt1oFQxIywyrvgKfbIkEdM?=
 =?us-ascii?Q?FkhHoYPkcZ295cb6WDdAvty+1ypH5gdm+4fTWDNf6rxlXLnwo/0ZB6B7+6Xe?=
 =?us-ascii?Q?vimeCDDRzGI2Qk2mDWasDqq7Hhb5cQzA75coUWx3pQVsFXLohgdQaXtHcQ4u?=
 =?us-ascii?Q?UqNBwqqxqoFf7CJnptF6iMBsnVIJ3iw2K3qJcphRqqyIbLYGjc48/5k072vN?=
 =?us-ascii?Q?xRFBw41esZ8YqEYN7oyWFP83E8snGncKq3pJEM9J8EvfXJuy/4WClYf3cHFz?=
 =?us-ascii?Q?e+k+7pw5iPSJ6Y59Btyhti0sW4Vv07W5Vu5tr85L+8kPrIP2J1WbkV99/ZeO?=
 =?us-ascii?Q?X4JTkq07LnK+cn2hYfjCjuVYQBzE+ZaRehfUsjmHxAP2kWja8LmM0FPBJZFp?=
 =?us-ascii?Q?1WhbAm68u+Mzl0RtHG4QN4ZmP7O0a0VVhLmzzLE0NGjxi0DeXBbR4jmmFAEp?=
 =?us-ascii?Q?PmMjN3sfU8Ifg0mjYO7SLckJ1jHrMq3AG3abEvDqXIpa6w0a4a8xn1pyXqU7?=
 =?us-ascii?Q?QGp5jThrJuEevrPyq95/dB8aZXmNmtJBFH2qRW839H7FU4l7AUh6agfO3mhQ?=
 =?us-ascii?Q?gzoPiVoxOtYoLndhK35YGibOW2SRui3yn8MEkIFikLQCzpwAM4/1wXZdn2v5?=
 =?us-ascii?Q?ksqeEtqerxa+VeN2eBVfLv1oP09S9zh0v0AGAz3h2EeLlq6pnccD8JK3hOnq?=
 =?us-ascii?Q?3kNL0TZtbwhl/8ZZzEgDPktWvhDVtc6QKubkCiiAXSoauOb6f9aq+d0tHoeT?=
 =?us-ascii?Q?k2M3UNszwG9y9yEmomaVNQIxMhOFEp4AF9WpB0F61UBc0n8jbJ71aEZ5W2VG?=
 =?us-ascii?Q?9+BYGeEM2L15sqpff9iGzn3T46BXFcKGQc3uAIXY58j+OgeW5irwj0+mglH3?=
 =?us-ascii?Q?7lrZn4/yl22XgTXZTrOwHHKEheWnt1eAGtdTdWGBYgSDA8E6h3vO7RXw8dUb?=
 =?us-ascii?Q?orzliRZTDAkfzGRZ1pjXvm+zVmIGkAIqJDUFU9zOXY/Z8JvZSF7jL5WTb1PW?=
 =?us-ascii?Q?d0noBAvjikR3TA8v92LrgYI=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <92FA177B16382842858C4B8D9208F5EB@namprd15.prod.outlook.com>
X-OriginatorOrg: fb.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR15MB5109.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 08c7b429-8830-4ab0-94b9-08da87a989bc
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Aug 2022 21:25:45.6250
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ClhJ91MTDpxsZuledqSpEdIWy8KkPJCvgrvtSZfyDb8p6KxqpDLdOlpfhPir7XtJPJW0JKYVzBLum12VdLd1Kg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR15MB4939
X-Proofpoint-GUID: j18Fr6RWHuw-CihyJiQrp8R6QOfBaWwe
X-Proofpoint-ORIG-GUID: j18Fr6RWHuw-CihyJiQrp8R6QOfBaWwe
X-Proofpoint-UnRewURL: 0 URL was un-rewritten
MIME-Version: 1.0
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-26_12,2022-08-25_01,2022-06-22_01
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Aug 26, 2022, at 2:12 PM, Namhyung Kim <namhyung@kernel.org> wrote:
> 
> On Fri, Aug 26, 2022 at 1:59 PM Song Liu <songliubraving@fb.com> wrote:
>> 
>> 
>> 
>>> On Aug 26, 2022, at 12:30 PM, Namhyung Kim <namhyung@kernel.org> wrote:
>>> 
>>> On Fri, Aug 26, 2022 at 11:45 AM Song Liu <songliubraving@fb.com> wrote:
>>> 
>>>>> And actually, we can just read ctx->data and get the raw record,
>>>>> right..?
>>>> 
>>>> Played with this for a little bit. ctx->data appears to be not
>>>> reliable sometimes. I guess (not 100% sure) this is because we
>>>> call bpf program before event->orig_overflow_handler. We can
>>>> probably add a flag to specify we want to call orig_overflow_handler
>>>> first.
>>> 
>>> I'm not sure.  The sample_data should be provided by the caller
>>> of perf_event_overflow.  So I guess the bpf program should see
>>> a valid ctx->data.
>> 
>> Let's dig into this. Maybe we need some small changes in
>> pe_prog_convert_ctx_access.
> 
> Sure, can you explain the problem in detail and share your program?

I push the code to 

 https://git.kernel.org/pub/scm/linux/kernel/git/song/linux.git/log/?h=test-perf-event

The code is in tools/bpf/perf-test/. 

The problem is we cannot get reliable print of data->cpu_entry in 
/sys/kernel/tracing/trace. 

> 
>> 
>>> Also I want to control calling the orig_overflow_handler based
>>> on the return value of the BPF program.  So calling the orig
>>> handler before BPF won't work for me. :)
>> 
>> Interesting. Could you share more information about the use case?
> 
> Well.. it's nothing new.  The bpf_overflow_handler calls the
> orig_overflow_handler (which writes the sample to the buffer)
> only if the BPF returns non zero.  Then I can drop unnecessary
> samples based on the sample data by returning 0.
> 
> The possible use cases are
> 1. when you want to sample from specific code ranges only
> 2. when hardware sets specific bits in raw data

I like this idea. We already using BPF in counting perf_event. 
Now it is time to use it in sampling perf_event. :)

Thanks,
Song