Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp841818rwe; Fri, 26 Aug 2022 16:11:14 -0700 (PDT) X-Google-Smtp-Source: AA6agR6COyYAPTHYZ2ew61BF6Y1XNoIhyNWmo7h5b6opY/1bt5D074+pBibHFibtH3OYjOoo5t2X X-Received: by 2002:a17:906:8a74:b0:73d:d6bd:660b with SMTP id hy20-20020a1709068a7400b0073dd6bd660bmr5845322ejc.200.1661555474549; Fri, 26 Aug 2022 16:11:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661555474; cv=none; d=google.com; s=arc-20160816; b=gvVt1cVp00RYi0rlCVDN0VYZ8iaEMgpI33tejNcD1HkCLkqkG2pv54mdYSHsJRF2B3 AgZ4DwOeh8e/5RCxiLAl1+xSp6hCnpsuxb7cy6n+hdKzcQgci/+Fs9b0Uub1EwMqTqWh WYV+7qNpSI0ms2HdlHyNF6i1/BekM5/2E+F0t8xRRo+pRWnbR/RJTB0qBQ4r5WrCUK6b 0/33FCEtJ0ZmU76NCNhmQ3BJJnl82Pi1s3opVfoLkme6voSCksQNINBc+kYZju10/r2K stvkq8iQphq6oZ2p2uAjpZD8PvTqfOja2Ni9BHhYaJKJHypzsbiHepOO1mYyzJypaida hJpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=YVzdgHOnLRCNMj/Dtne4+E3xVYm73UAJFVxl5UM+dlI=; b=Z9safzyXwoYELeYurqq6rws33jcaLitNJ0GX7loE1ZSL83XTEiHGtg6zVMFsoOdEfv XwUQb3FcuBb128WsfZVJ3NjOvIqToV7BT963kdc0oZIIaBSdlpliK7UnVP8hv9qE334X Z2lXSDa8exDPodZBVDOarBBFKLIh5Rq2wkHWJYOekkoWSzuOwXpNpbMvRq+ZMCJJoaYN ERebaVqZF2QjYCxl9MO6M0mBu97gYq2n5FDRo5Yi38NXeDZWAPUjrPbp47AxWuTG7md4 y81td8oBvQuzmg98CVPUgbF82M4mAS5rQeN5xAv2AWURk86O7iUgsJbIvbqg/wrUrujY ivPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=OR3CneSk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q1-20020a1709063d4100b0073d785d443asi1617592ejf.708.2022.08.26.16.10.49; Fri, 26 Aug 2022 16:11:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=OR3CneSk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345421AbiHZXEa (ORCPT + 99 others); Fri, 26 Aug 2022 19:04:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231738AbiHZXE3 (ORCPT ); Fri, 26 Aug 2022 19:04:29 -0400 Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76FD9E831A for ; Fri, 26 Aug 2022 16:04:28 -0700 (PDT) Received: by mail-pf1-x42d.google.com with SMTP id y141so2875802pfb.7 for ; Fri, 26 Aug 2022 16:04:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=YVzdgHOnLRCNMj/Dtne4+E3xVYm73UAJFVxl5UM+dlI=; b=OR3CneSkHlCbKJtEcgpCri2+tewlhv5awjvREMp6AT1onwJcFk7obSWy94WM0oQrpv yCATqf2ZpkIPoo+j6Ds7kJ5gnpYDSczm0KyMMyXxOOo6UaMALxVVtM1PNYNhFI+atjkS +dHnatNk6iEnWkWjMzBIsLR24kZQ0jh2iwnFXHrmGWcWe/+lhPKX1duhOpUivlMPuUXZ edOMppqD/Ur7AN6XS51CbAoQqorPrf1MLHB6ypbPsLAe4I7t+hx22seAzy1OfgFCo8EN EcyLfxfloosq9fYL8FFTKEZnWST3q4frXOvZ3gNSC0P3Tmq/IZ1OmrJHvw9tCR9X3YIs 9SjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=YVzdgHOnLRCNMj/Dtne4+E3xVYm73UAJFVxl5UM+dlI=; b=EgpjCmR90PACDghTySavUAauEIz7yxW8FgRWeSNehmV3gRJKsvEPtMoIKJISNDYfYM WE1VQcCDYiTKa5G3SzoVXGfkU8AJ4sOMVGG+VYYRVqjazCIHacLbS3eqqfA3KwIlCsas 7/qFNa19Mh8F3xb4Vv/5eb6WdTUoZF/3XB9fMbBFYrqplWjyMdByt2kp0Q2rdjZ8nPrk 3FNKkYZj7eHIj07UcOL+vVeSG0R9BfZuMKZlMOnlsml32vzH/eEyUB7zP6ZdbBGpNifI 2t1HRpDRA1JT/cFWQzseg3Hf7M80QawCEjzBagG2xvpz6FSIdawV55ahJAjQlQLZR+6m CSqQ== X-Gm-Message-State: ACgBeo2JxbabdoIASneKQhU/uKbquxDyh5GT/4zEH6nfE9SApzUHamAY zynf1SQru3ZiRdvdyIysjWMx9Ojvkcf5tpaDXC/aBQ== X-Received: by 2002:a05:6a00:1d1a:b0:537:d750:65b5 with SMTP id a26-20020a056a001d1a00b00537d75065b5mr3114362pfx.85.1661555067845; Fri, 26 Aug 2022 16:04:27 -0700 (PDT) MIME-Version: 1.0 References: <20220826224812.550793-1-shakeelb@google.com> In-Reply-To: <20220826224812.550793-1-shakeelb@google.com> From: Shakeel Butt Date: Fri, 26 Aug 2022 16:04:16 -0700 Message-ID: Subject: Re: [PATCH] mm: deduplicate cacheline padding code To: Michal Hocko , Feng Tang Cc: Andrew Morton , Linux MM , LKML Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-17.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 26, 2022 at 3:48 PM Shakeel Butt wrote: > [...] > /* Write-intensive fields used from the page allocator */ > - ZONE_PADDING(_pad1_) > + CACHELINE_PADDING(_pad1_) This needs a semicolon with the common definition. (I had it in the definition but checkpatch made me remove it just before sending). Sending a v2.