Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp944930rwe; Fri, 26 Aug 2022 19:07:23 -0700 (PDT) X-Google-Smtp-Source: AA6agR4Vn1QiZ37Aimfm6uToyAcTU6PsoYgGH9aIBfRmkGGVs0M0JZSvnoNsVImdkXCPKHeIp7FR X-Received: by 2002:a05:6402:641:b0:446:d:bd64 with SMTP id u1-20020a056402064100b00446000dbd64mr8659158edx.32.1661566042838; Fri, 26 Aug 2022 19:07:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661566042; cv=none; d=google.com; s=arc-20160816; b=zxcfQbOW2ngne+ZGOQeC2szT72x6HhOcMpZS396uZw/knioyP4SPx4W+FLUWQ6DsfA Klhha2NAuIPlhBK0TNtGtE4EIW73tfEYcDBMjJnf/wwRXEcWvIlCEwmS2Z1vS+22SRqU yhd7aEmOWiTNkUGcbv+qvBXSWChpwreYIeDCDyN+gt0JIziY0LwFSkHtZGgLKcOL7m9P Oeo0uMYK09SiPwy2gXGpFcugEDEYP5gTm6o1JBC+On3gNz7dcLyUQJwPeACqU93P52b7 V4Ulq6TFe2lO0LsQX3fDoHdvAMYbd/8ls/UzyllsRshDtDqrE8OvH9XI/sYrbkP1wRgF hf0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=4mYq57bI/mq7uz/4a/nP0LKoRANAwYRS+YwBodMIP/0=; b=PaQevOkjF90OurnOcXqOGQgA3Te0Qk/T9vd2uC5XdRcSmwjURwGpbiyXldN8ga+LZD 0EAJxP6YE7YcUxpJ0ozrcIcXOyDWefyxGu/E0MDeApFWPGIq55zrTRFcXBPESYjhXvYW rIYp/rSIRPFzvVTrFAy77dgEDQRNoWVK8AY5bzNElqGb4MTO4RSSleMck2yNvM0ymP3/ LoLnzjrLJcMebq/NZfAOeXtys7kTjHLr2dRklNKxpW2jXZpZR38RjeReC2G/4oDNRQUA Ur4qzt1itPh6nwSl5jv2hQo3H92nUVvcXGosxJJHLtaDCDQvkSoWK0EsX6YATcnBw4Xq lGmQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=scS+oXKo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s4-20020a17090699c400b007317732083csi2159483ejn.274.2022.08.26.19.06.58; Fri, 26 Aug 2022 19:07:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=scS+oXKo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345073AbiH0BhR (ORCPT + 99 others); Fri, 26 Aug 2022 21:37:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233267AbiH0BhP (ORCPT ); Fri, 26 Aug 2022 21:37:15 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD079DF0AF; Fri, 26 Aug 2022 18:37:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8B631B831BD; Sat, 27 Aug 2022 01:37:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA85DC433D6; Sat, 27 Aug 2022 01:37:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661564232; bh=gCe5krUjt94WhtRKYuI73X7CtqBoOaSa4DzCVLYy4Zw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=scS+oXKoPVI7/Fj6tkib3BKNPT+WmkmHIUQ54KyLmfgR3uZTZnojA/Ps//YoWJrJT MsWaN2mpo0SG58YVGaRTxprQ5dIHuS/UtSjMe+AEG+A3XiUxAY0VvPZl053N/iTiFv 7fU51+UuAsfptR3A7NYtonhfX4A3AwyazdxRwoPTof/7jPp8I18XS+62czefLJ79C2 +3bvldG3SZSh7z+dvuz9shcj8oEK1RbykDSs5pAlf1p8UnNiKASjT0z6wI8SMZqJtU zAuqsLCRqXrDod/AJcX2YRy7X9lphuMHRvT8GpfpNh8ODOkDit1gDowjc47+3E/8IB KiKxdpdOgJtFA== Date: Fri, 26 Aug 2022 18:37:11 -0700 From: Jakub Kicinski To: Andrew Lunn Cc: Horatiu Vultur , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, michael@walle.cc, UNGLinuxDriver@microchip.com, maxime.chevallier@bootlin.com Subject: Re: [PATCH net-next v2] net: phy: micrel: Make the GPIO to be non-exclusive Message-ID: <20220826183711.567bc7e8@kernel.org> In-Reply-To: References: <20220825201447.1444396-1-horatiu.vultur@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 25 Aug 2022 22:16:31 +0200 Andrew Lunn wrote: > On Thu, Aug 25, 2022 at 10:14:47PM +0200, Horatiu Vultur wrote: > > The same GPIO line can be shared by multiple phys for the coma mode pin. > > If that is the case then, all the other phys that share the same line > > will failed to be probed because the access to the gpio line is not > > non-exclusive. > > Fix this by making access to the gpio line to be nonexclusive using flag > > GPIOD_FLAGS_BIT_NONEXCLUSIVE. This allows all the other PHYs to be > > probed. > > > > Fixes: 738871b09250ee ("net: phy: micrel: add coma mode GPIO") > > Signed-off-by: Horatiu Vultur > > Reviewed-by: Andrew Lunn The tree name switch in the subject compared to v1 is unintentional?