Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp962522rwe; Fri, 26 Aug 2022 19:44:15 -0700 (PDT) X-Google-Smtp-Source: AA6agR5zcJS3UXW4lnEWNAgkveaNejz3aQZeghIzTGOOOwaU4r5H8lz7ivUin4gGmcb6sSKM3UP+ X-Received: by 2002:a17:907:6096:b0:73d:9d12:4b04 with SMTP id ht22-20020a170907609600b0073d9d124b04mr7236522ejc.745.1661568255083; Fri, 26 Aug 2022 19:44:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661568255; cv=none; d=google.com; s=arc-20160816; b=ttMd3V1fDKSRYjPSZX8ZqkrlxNpokkUuDUy3PN+/8nbWyY50MzfOFJo4OrYkImD4aN C5hjeBHJ313OfvEawbB5uv75WZE0ZKs+OhjDm9M5MlpchDAmbvq9XCelFy/XgRkPZ95w 5AOs1E30R54H/RbE5+rND8defRP27Q+HK2WS3/pWKqVFIzQ+t/0K39xkCfdJDcONCs3X El6wnxns/wMbwG/UEoOOLcfCPRt8E9QQ60yD+n0UfUuuJFHllqJooEFDS0/mi71FruaP q6EE7HGZKALR0RUDH1bP3fyn0TNu6FCBcsfVjrY7uokgo432D3/e2ekJg8rjlfMS98a9 bAQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=nW4xOXtK1LsAwF21QsqD0QLA/0ZBSGG7E4iecoHOTP8=; b=0Qb7fTKjqUYdI+7Cr0mok6VTmlV+C8Q3Q7cMdraMwjCM49aSEW3k1OflJTQcdf4YO2 9bOi9GO5tZ6+YjcGOuXAGOhjAudUQjdFMraWoqbxnoxgJPXH9rTK+AVEIZ8ZUqyeutJD 5cNDvLBuef0t8ijDluN8+7LcPbJJwdNN3mnXPiULJsBz9VpYwnm2roNtXLRNi7lKXaJF ABFJb/2VGWetjL9xS9Vff5nJA0cIwVcPpM9kyyHn7zRr6kz0i6uImS1/Y55zkV5ehFqG 0zOWTxGGHnbW9wluGHcsHtWCg6VUcirctRNlj2rQ2tyNjYlJIVT4b8LbABlh84a5G5+n wY3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=OHZOEdZr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c8-20020a05640227c800b0043cfed4d661si3003989ede.358.2022.08.26.19.43.49; Fri, 26 Aug 2022 19:44:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=OHZOEdZr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237229AbiH0Bnd (ORCPT + 99 others); Fri, 26 Aug 2022 21:43:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231131AbiH0Bna (ORCPT ); Fri, 26 Aug 2022 21:43:30 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E96DEC4D7 for ; Fri, 26 Aug 2022 18:43:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9F7F061CEB for ; Sat, 27 Aug 2022 01:43:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C968FC433D7; Sat, 27 Aug 2022 01:43:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1661564609; bh=ZRrgfPWyUv61JlX8iDzy2PZiGjGRvRzl+FOAReOkttk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=OHZOEdZr+3pm7ImsHzxQeWDoenMwByLK5b8Zm/YlaJS5271UR1A+xNersydHjlUmf MI1ICUUvwa/mumTeArajp/5smKe6mwi+1kXabJE/O+0FmnqOXQ+/npI5PwUOVX4YgW 6SF2IwHvaK92VxJ1JnElSB8HB7RIUGcYhrSD752g= Date: Fri, 26 Aug 2022 18:43:28 -0700 From: Andrew Morton To: Nathan Chancellor Cc: Liu Shixin , Seth Jennings , Dan Streetman , Vitaly Wool , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next 2/3] mm/zswap: delay the initializaton of zswap until the first enablement Message-Id: <20220826184328.3bce63050a1f82e9242580df@linux-foundation.org> In-Reply-To: References: <20220825142037.3214152-1-liushixin2@huawei.com> <20220825142037.3214152-3-liushixin2@huawei.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 26 Aug 2022 13:25:41 -0700 Nathan Chancellor wrote: > Hi Liu, > > On Thu, Aug 25, 2022 at 10:20:36PM +0800, Liu Shixin wrote: > > In the initialization of zswap, about 18MB memory will be allocated for > > zswap_pool in my machine. Since not all users use zswap, the memory may be > > wasted. Save the memory for these users by delaying the initialization of > > zswap to first enablement. > > > > ... > > This change is in -next as commit 22100432cf14 ("mm/zswap: delay the > initializaton of zswap until the first enablement"). I just bisected my > arm64 test system running Fedora failing to boot due to that commit, > with the following stack trace: > Thanks. Sorry. I dropped the series.