Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 27 Aug 2022 09:54:35 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Maxime Coquelin <maxime.coquelin@redhat.com>
Cc:     linux-kernel@vger.kernel.org,
        virtualization@lists.linux-foundation.org, elic@nvidia.com,
        guanjun@linux.alibaba.com, parav@nvidia.com,
        gautam.dawar@xilinx.com, xieyongji@bytedance.com,
        jasowang@redhat.com, mst@redhat.com
Subject: Re: [PATCH] vduse: prevent uninitialized memory accesses
Message-ID: <20220827065435.GL2030@kadam>
References: <20220826161605.559317-1-maxime.coquelin@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220826161605.559317-1-maxime.coquelin@redhat.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?B186t9MdiQxDwFEBpVAAPaSU0Ffu/N6AdtoELOcsVY7Xla4S1+kxOnQJTd6o?=
 =?us-ascii?Q?7yUgAGrKRyEyO3G7baT+I+BN9yPOraS4Zw0sBAeV/9UtrOTm8u+aufjuxcP7?=
 =?us-ascii?Q?xsn7H+PRGIovu6IQY+VBAs7DfuxtHgVI8rlvdf9D0AbPB5yIha9Nso1UYFRs?=
 =?us-ascii?Q?enlAGx5TD2Uw9KW71tsTfYa66utXxy1glFup7wfsqArKabB1lpAPryaxKl5F?=
 =?us-ascii?Q?nbVMbp9cn2u6NDUTkEl2r5wEe7fAG2i/hKyjg7GiaXlR65VrOoBxsbqLMxIA?=
 =?us-ascii?Q?jdjYusfaMqDXiPUQWK/3yK01csx+aGiYz10JG0g+2AaRrX/ppKYqNDcPSH7K?=
 =?us-ascii?Q?KWWR/sXwyMat7iDbaFiLnWaurVnWP7p/njyvI4MOa2k2aSW57bcEUexr+hIw?=
 =?us-ascii?Q?srFArrRzBKFwpN6fl84BzGR1fm5EwSkCRwcQomH93J5LUYLGCmif3a223hqv?=
 =?us-ascii?Q?PIMe8XTPZODnU8k5qcUuZz0REkDu+1upv0Gg7ykuOtpvbtfZFD16qSYDHllD?=
 =?us-ascii?Q?3XGa6fSLtQCThGVJGGZ2cf7BnWEJ4n0Zc+AxwIxzxV1Fz5oqgASEQEXxE8Vb?=
 =?us-ascii?Q?iXTwspb47MsT4TNUEnWmeBR+q2fx0wTbOxJekt+efVyfbIUEXK5JgoC0+wzM?=
 =?us-ascii?Q?jfAD7oKV7iL93pV17FqkoKyRoeY2Rs1SwWkR4mU2jd3YeDj41M+Htzv4oVcU?=
 =?us-ascii?Q?EOs/MlM2AEM2p8xzD39nyrmaeSXlrGkrlHGKlwkLtNwGD9b2bN2K5dbQFEtz?=
 =?us-ascii?Q?4cq16bymIsa+nsLCxn4aMw/ymfHU/F+XvoznXS75iNtpcia+OE8zdzU9gOe9?=
 =?us-ascii?Q?GNwYbm+5B2s70rnkhYfbzsl2jFZpiMwFpWwklk1zDjvstM9TJW8b21QxmUlY?=
 =?us-ascii?Q?/GQsv9noquzuLJ88lSRKA0gLWOQ0fXuGty9ye8hiBMj7+7d6V3uAHFOqr9RY?=
 =?us-ascii?Q?mM6eVOXMyaSXzp/h2IT48v/fc02/bU3SaHuT+MX39j+mDZ0GzUdPBObsJf1G?=
 =?us-ascii?Q?4+bgkG+nFNw22DFyx6NPPdj9r+MrdD/kXMeiFOYezX2Ap5RFyfAxJ1CJ+lcD?=
 =?us-ascii?Q?XhMLqHkN3VBp7JiKSKTcK+NrsszPERdVmgchWII6cU3o1HIpctZuZGbQKOJb?=
 =?us-ascii?Q?Rf3YIgGnle9+Q8PaZZKFXtC7xv/nHt0huSX/+iAeLq4QQNF8PPs300jpVgqk?=
 =?us-ascii?Q?wofdCPjfCks4Qqzpogf9PBbe7n641Sm5JjSRLQaRytxalosi7qt/GEp5OzFR?=
 =?us-ascii?Q?fxcvu8zOTeyEhFYISOYEiIB73arGmi20BCSfsxuyZOnSuOMcu1zGG25GXOMm?=
 =?us-ascii?Q?Fx0LGN3/rijUQOe/j3WB3VfMrDMvrLoGuqvhUviCWd3Cpoy18bUiLnKYR1AD?=
 =?us-ascii?Q?6aP8SvnQnREbVUspjb4v+vMMPxGt4A8otFiAqSd06QV1rzxlj/ERMfDUKoy6?=
 =?us-ascii?Q?XcMbuzeo6uC0ZvKA+TEPOZxSwHdwxpVUyrvbLTsdehoJcHHkDxNqhi5Xoo35?=
 =?us-ascii?Q?xGUEyZ2bxHrSOdmb0ncIksYOPYtG4MH0kN6ApbvDwj22MObAc+LpTZxVtFj7?=
 =?us-ascii?Q?e8+OoESciOE584h6KjFG0qwPkQFqiS8YeQH98mPFVe/oV8zewoc0Jbln4b2/?=
 =?us-ascii?Q?wA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f4031a17-d0bb-48ea-95c7-08da87f908ce
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Aug 2022 06:54:49.1959
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Riuj6We1OsTiYk1peAXRpt7buZs1qJc2ZzmbZoRQQX7Fd1hWktzNQLQoCATCTQ757p+kNOSq/UmS4Ki96j3roojxzZ358A4EIaW0HLfxIcs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6378
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-27_02,2022-08-25_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0 mlxscore=0
 spamscore=0 mlxlogscore=772 phishscore=0 suspectscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000
 definitions=main-2208270027
X-Proofpoint-GUID: KZ6es6DbpAlpCXOyRaZ9DrxPAx7dSq6I
X-Proofpoint-ORIG-GUID: KZ6es6DbpAlpCXOyRaZ9DrxPAx7dSq6I
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Aug 26, 2022 at 06:16:05PM +0200, Maxime Coquelin wrote:
> If the VDUSE application provides a smaller config space
> than the driver expects, the driver may use uninitialized
> memory from the stack.
> 
> This patch prevents it by initializing the buffer passed by
> the driver to store the config value.
> 
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>

This sounds like it needs a Fixes tag?

regards,
dan carpenter