Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp1101650rwe; Sat, 27 Aug 2022 00:14:45 -0700 (PDT) X-Google-Smtp-Source: AA6agR40ecjm1mTnIOlscPzbiXT2XD8nBd+J6tAXJElhI8THFl5cBXHSYBQayLEV0eL4wD7XrvFl X-Received: by 2002:a17:906:6a03:b0:730:a20e:cf33 with SMTP id qw3-20020a1709066a0300b00730a20ecf33mr7818339ejc.620.1661584484927; Sat, 27 Aug 2022 00:14:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661584484; cv=none; d=google.com; s=arc-20160816; b=umMROPEmWsoPO3+EVSlI36JD9ylb+Nlj9exs7kGeEyIusJhWTdtEb0HllcI0+qGQzV I7PwI/a7nS566GHF8aLBJ9bn6J1/GMAS4U0Ge/CsKz8cQOYsbi0VR4hYjoIoqW1bj3re UmkWGw69IvJww0EMOe6XoIRyxULGH0Bq0vWD70OVh++mODiR9wtPRJRwFgUKdP8dxqRM 189KPS5scTgvX38p1I5vyYUa7OStyAonLZ0SgKLBvwobCzHMJXh1/UJy6JWzvI2O62hr AG+h8sL74h77S4w+WUXT3o5LBF6MQEfTtxEv3wO/2ulvB92+nPuoWoTyYdQ0oZJg2ft0 y5xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=F+NZHHIRxyF+YByojv6eyno4QW1Pejn42UGhnesL1kU=; b=oR0QmB/dep1YSirqKJyHyuhL9ulnh4Eeawun63jRIeeuLI06Y4U7iOFRzZ0hqhE9Ol Ojg/GUFcTmFrhm6awlvs7+ShPk2RyhaKfTA76tVS9+6tmmEtjCPWBAeeIFGpb0DJ3wPd t5Yp49xkDcey1fLtn/JFdrysPm7FV9ejtF6eqJJP91en5RijGiCP60pCkohkrWeNP+Md Pr5Xr5MoHPUL34m3jX7BGFMJfJQ1ZEToV0pfiLItZ87J+uRbv10AjhpvmLR0D2Sr7/Iw KKbGuh+5fL89lf+KYKoHWDb6I1tWtKTW3nphM9dLuKXQG4ocjYPNh5PI4QODItTnf0Px zXvQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=q0unqfFt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e10-20020a17090658ca00b0073d6a56691asi2366036ejs.161.2022.08.27.00.14.18; Sat, 27 Aug 2022 00:14:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=q0unqfFt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232660AbiH0Gy3 (ORCPT + 99 others); Sat, 27 Aug 2022 02:54:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42486 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232280AbiH0Gy1 (ORCPT ); Sat, 27 Aug 2022 02:54:27 -0400 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F39F74CC6; Fri, 26 Aug 2022 23:54:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1661583264; x=1693119264; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=UH1E/vTeMlllSwzFZAoSra46+z3qWsWaFhDL//3BZu0=; b=q0unqfFtJtNLagcwhj+IwqN53NdUXBj1vxR0QZOnrpw0Zm4kI4hHX391 gzh+8Roz250YivFJdF55IKZo9BrDEvjfYrTYeqWUgKoBwuwrs8K9oxMo2 AKgD99LtliNtD6ZNVT+ZCdpl4HX8KVVDov09q+s9on7k2gMusNEG5evfm yR9kl+KinCtSp/3J48v9NrLysHHvk8anUfV6qhEP49030wmAj6RL6diqU +yTplyIJcHIWpiPr9/qEXi80wH/bj3uzttWfL1OQzQ0eXXn7DvcHwEnjb 5nmXKxR2q73heQR2JkuGkOylHOJ7AhXKNG6SWkpkALjJBuucDhW9gVNN8 w==; X-IronPort-AV: E=Sophos;i="5.93,267,1654585200"; d="scan'208";a="174423481" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 26 Aug 2022 23:54:23 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Fri, 26 Aug 2022 23:54:23 -0700 Received: from localhost (10.10.115.15) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server id 15.1.2507.12 via Frontend Transport; Fri, 26 Aug 2022 23:54:22 -0700 Date: Sat, 27 Aug 2022 08:58:38 +0200 From: Horatiu Vultur To: Jakub Kicinski CC: Andrew Lunn , , , , , , , , , , Subject: Re: [PATCH net-next v2] net: phy: micrel: Make the GPIO to be non-exclusive Message-ID: <20220827065838.7iw3cubgtzhwqc53@soft-dev3-1.localhost> References: <20220825201447.1444396-1-horatiu.vultur@microchip.com> <20220826183711.567bc7e8@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <20220826183711.567bc7e8@kernel.org> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The 08/26/2022 18:37, Jakub Kicinski wrote: Hi Jakub, > > On Thu, 25 Aug 2022 22:16:31 +0200 Andrew Lunn wrote: > > On Thu, Aug 25, 2022 at 10:14:47PM +0200, Horatiu Vultur wrote: > > > The same GPIO line can be shared by multiple phys for the coma mode pin. > > > If that is the case then, all the other phys that share the same line > > > will failed to be probed because the access to the gpio line is not > > > non-exclusive. > > > Fix this by making access to the gpio line to be nonexclusive using flag > > > GPIOD_FLAGS_BIT_NONEXCLUSIVE. This allows all the other PHYs to be > > > probed. > > > > > > Fixes: 738871b09250ee ("net: phy: micrel: add coma mode GPIO") > > > Signed-off-by: Horatiu Vultur > > > > Reviewed-by: Andrew Lunn > > The tree name switch in the subject compared to v1 is unintentional? Yes I have switch it by mistake. It should be net. I can send a new version if it is needed. -- /Horatiu