Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 27 Aug 2022 18:46:04 +0300
From:   Ido Schimmel <idosch@nvidia.com>
To:     Hans Schultz <netdev@kapio-technology.com>
Cc:     davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
        Florian Fainelli <f.fainelli@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Hauke Mehrtens <hauke@hauke-m.de>,
        Woojung Huh <woojung.huh@microchip.com>,
        UNGLinuxDriver@microchip.com, Sean Wang <sean.wang@mediatek.com>,
        Landen Chao <Landen.Chao@mediatek.com>,
        DENG Qingfang <dqfext@gmail.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Ivan Vecera <ivecera@redhat.com>,
        Roopa Prabhu <roopa@nvidia.com>,
        Nikolay Aleksandrov <razor@blackwall.org>,
        Shuah Khan <shuah@kernel.org>,
        Christian Marangi <ansuelsmth@gmail.com>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Yuwei Wang <wangyuweihx@gmail.com>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org,
        bridge@lists.linux-foundation.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v5 net-next 2/6] net: switchdev: add support for
 offloading of fdb locked flag
Message-ID: <Ywo8PONgDW/lUj+X@shredder>
References: <20220826114538.705433-1-netdev@kapio-technology.com>
 <20220826114538.705433-3-netdev@kapio-technology.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220826114538.705433-3-netdev@kapio-technology.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1UtIJVvGyukyhuZgfpec8cDVFMWgdafHa7aToWDQJWnvg+cljQD/A9k+agaS?=
 =?us-ascii?Q?Wlo/Rt+DxzKaZ+HlkC3h1JSrEf/RVl7dpQn+MOgzEevoM17o5484kwfJx4UZ?=
 =?us-ascii?Q?ZSDFc3FW2x4tTYXw1lkUElfwTXbiuEBz3mAJQFXKZBKIwXMkXneXORDLWOfv?=
 =?us-ascii?Q?8gFpq5aXIPoBzZIi++DGTphAoCtKXaLP1vXesjTYuKeYHcpWzL/j+qGEl5wh?=
 =?us-ascii?Q?itFC5vMOCPdQQhfgRFVYYBA6AyOYDnj43/Fle2gJTacbPjkxtOuQBap0M+Ra?=
 =?us-ascii?Q?1DwqPc9l2ie9D1gvNi4yyHAAd7dbmOm8aOY3b957VgMm8UCafKdBHCfHSzhS?=
 =?us-ascii?Q?hIj02VO8Ho8zD9ZaMq38Bn4R8oU/S6YcwDqkP8+TlaUB8+RXGWJlP4xoEcVQ?=
 =?us-ascii?Q?nfvqm6jJsc9m+nJkomEwhzmKGQOOeYRtERVmeWlEugk7hEkIoGGIY6nkKnbT?=
 =?us-ascii?Q?vjvGQwrKjaHrV9BTo7PVpPTk+JzgsQoStDqajbidKGR/RzT1xzlNkG/d6L/d?=
 =?us-ascii?Q?ZcPJfP/vBIhjuGmg7wEFh52dtn2WOP9S0IN0y1wEW9Bm7G/c08HI4ao7sBc/?=
 =?us-ascii?Q?A2yKqTICaPFrjvbwoggnaPS4YbR+QYkQG+qVD8fLtcswA2KvnNtx6v43QCuD?=
 =?us-ascii?Q?9tUWq2cjhv3X5geR+Jo4rOYTkOsqWmw8jSe0o7H2fr4+OATOzYUztshKz4no?=
 =?us-ascii?Q?cfTDH+lhcZuQYNR3ORnaW7obDRUX+KMazeM3vayKh4kIyXY1S/k4gsltzIMz?=
 =?us-ascii?Q?gX9uyaA2QyPmOcJ7FEA6LD2wsV9rIN0kPzDi+dKvLAN8Epd+pwgTNl/KrlKJ?=
 =?us-ascii?Q?6N0ZZ5VLWHj2et0HcDTJfJVLMWCC4cUUEG6dhASPSsyB53604jlgE2RXY8GS?=
 =?us-ascii?Q?NKl9oTDr3p2Bh/RNSPohcvbGkFZ0kw/ermfzQ6REKJl7ZIc2A/nXay5KR/rY?=
 =?us-ascii?Q?N2c+W3+nI7r+qfW/b8vD2kLvKhcGUOymkGNE4i4gZMnQPvQYIzia1UI5fSkm?=
 =?us-ascii?Q?9Oq2/hpeYyUDZPxEWjW4tEZ2ZubS42phqhGHkAB1zFrDWfoYUrCaGH8snuaq?=
 =?us-ascii?Q?EM70FTHtTgoy4eGJZkv3ZF5NULDKPPu+m8y1jOmJmLF5zoDrbV9emAp9Qkg3?=
 =?us-ascii?Q?QvC1E3hBTX/Pd+Q5PqxLqO3huoizbt0dTLYHQCtimqVO7QhPMLbsm1RFnwbt?=
 =?us-ascii?Q?MJifPEKzSp8SJV11/oaTltSXGN6KPujCXjVASZagMjH4mJaL3wCN1gQXkLhH?=
 =?us-ascii?Q?7HGVhPhPL7TOcHuIbWgqhdzLl/7zjWJlc1ZkgBGQ0pRzW4FUfFyp9dOJUg/v?=
 =?us-ascii?Q?Iy6o1QL3ukWCfT1detIvWCtwTnLZZWkC0exL+lSDeJSm36RPtFq8U2ixJ83Y?=
 =?us-ascii?Q?+A+g6b5KNPxV4IJU4DZuDUSOtzLe+FOG0EGazW1iXSkVtQh5yhzFTv3tYmMH?=
 =?us-ascii?Q?QV+tyU2i7fiXozYls/pARcMw0y78cbR49SvAMm1fd2K0OWBxES98mk7GK0iH?=
 =?us-ascii?Q?MSNBP3wdWu03kegD/DphSeefX9v8SLu8aJniyULjSCI0HsU75cwCzNmrwdcL?=
 =?us-ascii?Q?HqSu/70MGP+c4ob67QxielnZ6Yg87/s3DsIjGKIa?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a3feee7-eff7-49e6-d452-08da884343de
X-MS-Exchange-CrossTenant-AuthSource: PH7SPRMB0001.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Aug 2022 15:46:11.1083
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1hEfdPQFV0arqRAHuZ9McMCcLhfkacXaTbvsefUWtnLntj8EjEm3kehV9+zji2aujIrpvoKRFRPsuKY1Ga3CEw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1201MB0017
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Aug 26, 2022 at 01:45:34PM +0200, Hans Schultz wrote:
> diff --git a/include/net/switchdev.h b/include/net/switchdev.h
> index 7dcdc97c0bc3..437945179373 100644
> --- a/include/net/switchdev.h
> +++ b/include/net/switchdev.h
> @@ -247,7 +247,10 @@ struct switchdev_notifier_fdb_info {
>  	const unsigned char *addr;
>  	u16 vid;
>  	u8 added_by_user:1,
> +	   sticky:1,

If mv88e6xxx reports entries with 'is_local=1, locked=1, blackhole=1',
then the 'sticky' bit can be removed for now (we will need it some day
to support sticky entries notified from the bridge). This takes care of
the discrepancy Nik mentioned here:

https://lore.kernel.org/netdev/d1de0337-ae16-7dca-b212-1a4e85129c31@blackwall.org/

>  	   is_local:1,
> +	   locked:1,
> +	   blackhole:1,
>  	   offloaded:1;
>  };