Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220823115409.46653-1-yuanjilin@cdjrlc.com> <658faa4e-ad16-7b13-87f3-27ea91db4ba3@linaro.org>
In-Reply-To: <658faa4e-ad16-7b13-87f3-27ea91db4ba3@linaro.org>
From:   Rob Clark <robdclark@gmail.com>
Date:   Sat, 27 Aug 2022 09:42:42 -0700
Message-ID: <CAF6AEGvX_J_t04tUUxserXh_rrcdu5eYTt6JOHoD-SJ6944adQ@mail.gmail.com>
Subject: Re: [PATCH] drm/msm: fix repeated words in comments
To:     Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc:     Jilin Yuan <yuanjilin@cdjrlc.com>, quic_abhinavk@quicinc.com,
        airlied@linux.ie, daniel@ffwll.ch, linux-arm-msm@vger.kernel.org,
        dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Aug 26, 2022 at 2:43 AM Dmitry Baryshkov
<dmitry.baryshkov@linaro.org> wrote:
>
> On 23/08/2022 14:54, Jilin Yuan wrote:
> >   Delete the redundant word 'one'.
>
> The whitespace is unnecessary.
>
> >
> > Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Fixes: 7198e6b03155 ("drm/msm: add a3xx gpu support")
>

jfyi, this comment (and associated list-head) is removed by:

https://patchwork.freedesktop.org/patch/496131/?series=105633&rev=4

BR,
-R

>
> > ---
> >   drivers/gpu/drm/msm/msm_gem.h | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/msm/msm_gem.h b/drivers/gpu/drm/msm/msm_gem.h
> > index c75d3b879a53..e300c70e8904 100644
> > --- a/drivers/gpu/drm/msm/msm_gem.h
> > +++ b/drivers/gpu/drm/msm/msm_gem.h
> > @@ -118,7 +118,7 @@ struct msm_gem_object {
> >        * An object is either:
> >        *  inactive - on priv->inactive_dontneed or priv->inactive_willneed
> >        *     (depending on purgeability status)
> > -      *  active   - on one one of the gpu's active_list..  well, at
> > +      *  active   - on one of the gpu's active_list..  well, at
> >        *     least for now we don't have (I don't think) hw sync between
> >        *     2d and 3d one devices which have both, meaning we need to
> >        *     block on submit if a bo is already on other ring
>
> --
> With best wishes
> Dmitry
>