Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 27 Aug 2022 21:34:18 +0300
From:   Ido Schimmel <idosch@nvidia.com>
To:     Hans Schultz <netdev@kapio-technology.com>
Cc:     davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
        Florian Fainelli <f.fainelli@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Hauke Mehrtens <hauke@hauke-m.de>,
        Woojung Huh <woojung.huh@microchip.com>,
        UNGLinuxDriver@microchip.com, Sean Wang <sean.wang@mediatek.com>,
        Landen Chao <Landen.Chao@mediatek.com>,
        DENG Qingfang <dqfext@gmail.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Ivan Vecera <ivecera@redhat.com>,
        Roopa Prabhu <roopa@nvidia.com>,
        Nikolay Aleksandrov <razor@blackwall.org>,
        Shuah Khan <shuah@kernel.org>,
        Christian Marangi <ansuelsmth@gmail.com>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Yuwei Wang <wangyuweihx@gmail.com>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org,
        bridge@lists.linux-foundation.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v5 net-next 2/6] net: switchdev: add support for
 offloading of fdb locked flag
Message-ID: <YwpjqpmG0YaisS9J@shredder>
References: <20220826114538.705433-1-netdev@kapio-technology.com>
 <20220826114538.705433-3-netdev@kapio-technology.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220826114538.705433-3-netdev@kapio-technology.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dM0jHhN9s0q3FhKRYFnLUsBgNxdWy/OJzh0O+wUze7cy8NDWkm1KE+MDyuaF?=
 =?us-ascii?Q?vGFJEhbn/gbEwiuCGNv5GhgjVjRncWjadjbPjyIID1FjZGe4U0x/9Ex83YfC?=
 =?us-ascii?Q?p7IiHeUZUE87P8VLkSEpV0J8BjKV0hfY2JQpu+Wso8kl7Ur/Uu0Q/XpmHAJq?=
 =?us-ascii?Q?oONtTsAZE4NQvJfGLzOBm+CiLBEwVxuPYoHOskqWmpyt4f4EgIzMmuzaWmxW?=
 =?us-ascii?Q?yJY91h3As1RBrwJouNyWY4X3F2qQX93+9rzdz7TaWNxaHZvERhoF7jvMNIAi?=
 =?us-ascii?Q?X5t053afs8i8h1UeLnwcue8yrVzmnBdnHfgIheux5teQquAk9Xwy5HnhcCSF?=
 =?us-ascii?Q?VU2id96Io/IH0XHFZ83IXxHyaZSLUF522hZsXp33st+3FYMWDbX7w0w5Nnl/?=
 =?us-ascii?Q?q1cowp8VLjPljlxMnIx+Yc9cEaW/eI59kiCfV/f6jzc/0SdQ6PKRcOSy2jaX?=
 =?us-ascii?Q?Aut95AGnfFC5YYBayCILxSb1ZMmlb6B2DBaP5dYNZJ+pTcbDnwCsAIHPxi1v?=
 =?us-ascii?Q?kyigW0IXBUg6QAqNU7DfN68OP78xchsjgeZ98cbLP8djlB5JcQ7vOic6cZDk?=
 =?us-ascii?Q?HylPAwTAWuloTfIwf8Y8q9cImIgcjc6Rt7gMR59Wobm6RSCN2XObuLxfqGW3?=
 =?us-ascii?Q?Hj0Yo8MGOz6w3IOH2Ai6OuzpcssKFCkLEdOKSQb6GzJp/qszrQwG7+6ALBY1?=
 =?us-ascii?Q?gH8SvO2R/hxdqJ2v3x+sud0MiagIp068jPAWM6AZUxJOShmuFv+Ct3Vs8TmP?=
 =?us-ascii?Q?t87ijd8YcYQcVYqV3J6iOuVKCbG9z3DZn9nKAKRAHOWCcdTxSNd2PrXmpAdV?=
 =?us-ascii?Q?2ImtHwDIOSBzoXSmevCF2ndFvAWBh1jsuaeuCS8Qo0vehxWLOwW2dWTt4D5i?=
 =?us-ascii?Q?1MLr2ZgJkPNq+kHy0N9R3SOrHYrq9g6yvkG9DtrY1CkWkP9nYBcdn0jZ/pxR?=
 =?us-ascii?Q?mcNrBDbESrZFl+w+lTKvCqiQZK+S/SYt+mXmqaUMcJRVRD7AI2aPPhIpdlO+?=
 =?us-ascii?Q?m2ljD1FJSjr5Trcydg88K0VV8DwlXognn3pkSMYzg4KDEVHT7QwWKfrBALnV?=
 =?us-ascii?Q?hmzkh6wreRz95NRVzedAL0mbtDm2oHFW5PxorUyo6lQMqCBrN+GC9o4IeUMd?=
 =?us-ascii?Q?FQzLzJqTfOFfLBNuGfwDlukSP4L1Q8+mPVfgGqFabUVhTIBpybpce/Ma0HZC?=
 =?us-ascii?Q?PLtBdrhTemooPuyqhkz/vmSN0iAgENEmbLBICkfAh7WOMYVLe+Cs8sqOODdk?=
 =?us-ascii?Q?L3JQ+eDNa75SJRsPfLzPYjgN+dT/SrNS7ZO6tgN+0rwAdA1Wjyh4w8D6FPR7?=
 =?us-ascii?Q?RxzD9fwJbYcoELQ9eJTEfcpjJ6vWMwFSuXpTQjKFGM7Gdy2lQ8l7A0qhciXP?=
 =?us-ascii?Q?b42XbRobv+sQ3HhZ9wTsRxzrsZq1c66gpT9d0ABKqWb6jqrkOOOZz5VkmkRm?=
 =?us-ascii?Q?eMDl8ykRRA71GsuYD3MadHDWS+8xG1SEK3iSaOV2GWQeldfWrRG0LCJ1fsoO?=
 =?us-ascii?Q?yC4OT7Rjp7Hnw2PQoX5hifGxagqcnuU+YPxtM92jIBpKmhbh6fw+jOp03hgM?=
 =?us-ascii?Q?cDkDFq6It/X5PpcyxjQV/NPdNl8RkjWREXWWkKfX?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: abc6e43c-8be5-45ed-45d0-08da885ac3b4
X-MS-Exchange-CrossTenant-AuthSource: PH7SPRMB0001.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Aug 2022 18:34:24.1589
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Z69RAzFS0nFZOzE//Hah+qlE/b1K/XyPd194cHmA8yHMAWFmG3nrbMzshBPaczSt2N85yk8WP+Lgw4ZRwA4FFg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5027
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Aug 26, 2022 at 01:45:34PM +0200, Hans Schultz wrote:
> @@ -1403,6 +1404,15 @@ int br_fdb_external_learn_add(struct net_bridge *br, struct net_bridge_port *p,
>  		if (!p)
>  			flags |= BIT(BR_FDB_LOCAL);
>  
> +		if (locked)
> +			flags |= BIT(BR_FDB_ENTRY_LOCKED);
> +
> +		if (blackhole)
> +			flags |= BIT(BR_FDB_BLACKHOLE);
> +
> +		if (sticky)
> +			flags |= BIT(BR_FDB_STICKY);
> +

While reviewing the test cases it occurred to me that the else branch
(FDB entry already exists) needs modifications as well. Something like:

diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c
index e7f4fccb6adb..48f842a71597 100644
--- a/net/bridge/br_fdb.c
+++ b/net/bridge/br_fdb.c
@@ -1397,6 +1397,21 @@ int br_fdb_external_learn_add(struct net_bridge *br, struct net_bridge_port *p,
                        modified = true;
                }
 
+               if (local != test_bit(BR_FDB_LOCAL, &fdb->flags)) {
+                       change_bit(BR_FDB_LOCAL, &fdb->flags);
+                       modified = true;
+               }
+
+               if (locked != test_bit(BR_FDB_ENTRY_LOCKED, &fdb->flags)) {
+                       change_bit(BR_FDB_ENTRY_LOCKED, &fdb->flags);
+                       modified = true;
+               }
+
+               if (blackhole != test_bit(BR_FDB_BLACKHOLE, &fdb->flags)) {
+                       change_bit(BR_FDB_BLACKHOLE, &fdb->flags);
+                       modified = true;
+               }
+
                if (swdev_notify)
                        set_bit(BR_FDB_ADDED_BY_USER, &fdb->flags);

>  		fdb = fdb_create(br, p, addr, vid, flags);
>  		if (!fdb) {
>  			err = -ENOMEM;