Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 27 Aug 2022 20:45:29 +0200
From:   Pali =?utf-8?B?Um9ow6Fy?= <pali@kernel.org>
To:     Andrew Lunn <andrew@lunn.ch>
Cc:     Gregory Clement <gregory.clement@bootlin.com>,
        Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Marek =?utf-8?B?QmVow7pu?= <kabel@kernel.org>
Subject: Re: [PATCH] ARM: dts: turris-omnia: Add switch port 6 node
Message-ID: <20220827184529.x6f7vacuhypaq7bb@pali>
References: <20220825122102.18634-1-pali@kernel.org>
 <YwpldyOI5x1xgMoM@lunn.ch>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <YwpldyOI5x1xgMoM@lunn.ch>
User-Agent: NeoMutt/20180716
Precedence: bulk

On Saturday 27 August 2022 20:41:59 Andrew Lunn wrote:
> On Thu, Aug 25, 2022 at 02:21:02PM +0200, Pali Rohár wrote:
> > Switch port 6 is connected to eth0, so add appropriate device tree node for it.
> > 
> > Fixes: 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia")
> > Signed-off-by: Pali Rohár <pali@kernel.org>
> > ---
> >  arch/arm/boot/dts/armada-385-turris-omnia.dts | 12 +++++++++++-
> >  1 file changed, 11 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> > index f655e9229d68..8215ffb6a795 100644
> > --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
> > +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> > @@ -463,7 +463,17 @@
> >  				};
> >  			};
> >  
> > -			/* port 6 is connected to eth0 */
> > +			ports@6 {
> > +				reg = <6>;
> > +				label = "cpu";
> > +				ethernet = <&eth0>;
> > +				phy-mode = "rgmii-id";
> > +
> > +				fixed-link {
> > +					speed = <1000>;
> > +					full-duplex;
> > +				};
> > +			};
> 
> Hi Pali
> 
> I've not been following Vladimirs work on multiple CPU ports. Is it
> clearly defined, both for old and new kernels, what happens where
> there are multiple CPU ports defined?
> 
>       Andrew

Hello!

On older kernel kernel versions just the first one cpu port works. Like
if second node is not defined at all. So I sent this patch to have
complete HW definition in DTS, even when kernel does not support all
features yet.