Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753967AbXFNTRR (ORCPT ); Thu, 14 Jun 2007 15:17:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752014AbXFNTRF (ORCPT ); Thu, 14 Jun 2007 15:17:05 -0400 Received: from host86-137-96-215.range86-137.btcentralplus.com ([86.137.96.215]:47386 "EHLO hawkeye.stone.uk.eu.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751333AbXFNTRE (ORCPT ); Thu, 14 Jun 2007 15:17:04 -0400 Message-ID: <467193FD.3010803@hawkeye.stone.uk.eu.org> Date: Thu, 14 Jun 2007 20:16:13 +0100 From: Jack Stone User-Agent: Thunderbird 2.0.0.0 (Windows/20070326) MIME-Version: 1.0 To: david@lang.hm CC: greg@kroah.com, agruen@suse.de, sds@tycho.nsa.gov, jjohansen@suse.de, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, pavel@ucw.cz Subject: Re: [AppArmor 39/45] AppArmor: Profile loading and manipulation, pathname matching References: <20070514110607.549397248@suse.de> <200706042303.28785.agruen@suse.de> <1181136386.3699.70.camel@moss-spartans.epoch.ncsc.mil> <200706090003.57722.agruen@suse.de> <20070609001703.GA17644@kroah.com> <20070610083427.GA24808@elf.ucw.cz> <20070610210547.GC25138@elf.ucw.cz> In-Reply-To: X-Enigmail-Version: 0.95.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1478 Lines: 36 david@lang.hm wrote: > On Sun, 10 Jun 2007, Pavel Machek wrote: >> But you have that regex in _user_ space, in a place where policy >> is loaded into kernel. > > then the kernel is going to have to call out to userspace every time a > file is created or renamed and the policy is going to be enforced > incorrectly until userspace finished labeling/relabeling whatever is > moved. building this sort of race condigion for security into the kernel > is highly questionable at best. > >> AA has regex parser in _kernel_ space, which is very wrong. > > see Linus' rants about why it's not automaticaly the best thing to move > functionality into userspace. > > remember that the files covered by an AA policy can change as files are > renamed. this isn't the case with SELinux so it doesn't have this sort > of problem. How about using the inotify interface on / to watch for file changes and updating the SELinux policies on the fly. This could be done from a userspace daemon and should require minimal SELinux changes. The only possible problems I can see are the (hopefully) small gap between the file change and updating the policy and the performance problems of watching the whole system for changes. Just my $0.02. Jack - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/