Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Axel Lin <axel.lin@ingics.com>
To:     Mark Brown <broonie@kernel.org>
Cc:     Jerome Neanne <jneanne@baylibre.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Tony Lindgren <tony@atomide.com>, linux-kernel@vger.kernel.org,
        Axel Lin <axel.lin@ingics.com>
Subject: [RFT] [PATCH] regulator: tps65219: Fix .bypass_val_on setting
Date:   Sun, 28 Aug 2022 20:01:53 +0800
Message-Id: <20220828120153.1512508-1-axel.lin@ingics.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

The .bypass_val_on setting does not match the .bypass_mask setting, so the
.bypass_mask bit will never get set.  Fix it by removing .bypass_val_on
setting, the regulator_set_bypass_regmap and regulator_get_bypass_regmap
helpers will use rdev->desc->bypass_mask as val_on if the val_on is 0.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
Hi Jerome,
I don't have this h/w to test, please help to review and test the patch.

thanks,
Axel
 drivers/regulator/tps65219-regulator.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/regulator/tps65219-regulator.c b/drivers/regulator/tps65219-regulator.c
index ab16e6665625..7054d8805dd4 100644
--- a/drivers/regulator/tps65219-regulator.c
+++ b/drivers/regulator/tps65219-regulator.c
@@ -117,7 +117,6 @@ struct tps65219_regulator_irq_data {
 		.fixed_uV		= _fuv,				\
 		.bypass_reg		= _vr,				\
 		.bypass_mask		= _bpm,				\
-		.bypass_val_on		= 1,				\
 	}								\
 
 static const struct linear_range bucks_ranges[] = {
-- 
2.34.1