Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220818050019.1924408-1-keguang.zhang@gmail.com> <20220821171030.wc343w6zmrtcz5to@mobilestation>
In-Reply-To: <20220821171030.wc343w6zmrtcz5to@mobilestation>
From:   Kelvin Cheung <keguang.zhang@gmail.com>
Date:   Sun, 28 Aug 2022 21:31:25 +0800
Message-ID: <CAJhJPsW0HTs+=PD2JvXZVTkm9zrnRYKtEwLNv3dsVsf1AUNjDQ@mail.gmail.com>
Subject: Re: [PATCH] MIPS: loongson32: Fix the validation failure of LS1B &
 LS1C Ethernet PHY
To:     Serge Semin <fancer.lancer@gmail.com>
Cc:     linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        "David S . Miller" <davem@davemloft.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Serge,
Your patch also works for me.
But what about the plat_dat->interface? Is it obsolete?

Serge Semin <fancer.lancer@gmail.com> =E4=BA=8E2022=E5=B9=B48=E6=9C=8822=E6=
=97=A5=E5=91=A8=E4=B8=80 01:10=E5=86=99=E9=81=93=EF=BC=9A
>
> Hello Keguang
>
> On Thu, Aug 18, 2022 at 01:00:19PM +0800, Keguang Zhang wrote:
> > From: Kelvin Cheung <keguang.zhang@gmail.com>
> >
> > The Ethernet of LS1B/LS1C doesn't work due to the stmmac driver
> > using phylink_generic_validate() instead of stmmac_validate().
> > Moreover the driver assumes the PHY interface mode
> > passed in platform data is always supported.
> >
> > stmmaceth stmmaceth.0 eth0: validation of gmii with support 00000000,00=
000000,000062cf and advertisement 00000000,00000000,000062cf failed: -EINVA=
L
> > stmmaceth stmmaceth.0 eth0: stmmac_open: Cannot attach to PHY (error: -=
22)
> >
> > This patch sets phy_interface field of platform data.
>
> I've got a similar fix in my repo, though didn't have a chance to test
> it out due to lacking any loongson hardware. I've discovered the
> issues on my still going way of the STMMAC driver refactoring. Anyway
> IMO the problem is a bit different than you describe and should be
> fixed in a bit different way. Please see a patch attached to this
> email. Could you test it out on your hw? If it fixes the problem you
> can resend it as v2 patch.
>
> -Sergey
>
> >
> > Fixes: 04a0683f7db4 ("net: stmmac: convert to phylink_generic_validate(=
)")
> > Fixes: d194923d51c9 ("net: stmmac: fill in supported_interfaces")
> > Signed-off-by: Kelvin Cheung <keguang.zhang@gmail.com>
> > ---
> >  arch/mips/loongson32/common/platform.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/mips/loongson32/common/platform.c b/arch/mips/loongso=
n32/common/platform.c
> > index 794c96c2a4cd..741aace80b80 100644
> > --- a/arch/mips/loongson32/common/platform.c
> > +++ b/arch/mips/loongson32/common/platform.c
> > @@ -147,8 +147,10 @@ static struct plat_stmmacenet_data ls1x_eth0_pdata=
 =3D {
> >       .phy_addr               =3D -1,
> >  #if defined(CONFIG_LOONGSON1_LS1B)
> >       .interface              =3D PHY_INTERFACE_MODE_MII,
> > +     .phy_interface          =3D PHY_INTERFACE_MODE_MII,
> >  #elif defined(CONFIG_LOONGSON1_LS1C)
> >       .interface              =3D PHY_INTERFACE_MODE_RMII,
> > +     .phy_interface          =3D PHY_INTERFACE_MODE_RMII,
> >  #endif
> >       .mdio_bus_data          =3D &ls1x_mdio_bus_data,
> >       .dma_cfg                =3D &ls1x_eth_dma_cfg,
> >
> > base-commit: 568035b01cfb107af8d2e4bd2fb9aea22cf5b868
> > --
> > 2.34.1
> >


--=20
Best regards,

Kelvin Cheung