Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b120cf98-85e0-75d5-30f9-44306b036cdd@nvidia.com>
Date:   Sun, 28 Aug 2022 10:16:54 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH v2] mm: re-allow pinning of zero pfns (again)
Content-Language: en-US
To:     Alex Williamson <alex.williamson@redhat.com>
Cc:     akpm@linux-foundation.org, alex.sierra@amd.com,
        willy@infradead.org, hch@lst.de, Felix.Kuehling@amd.com,
        apopple@nvidia.com, david@redhat.com, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
References: <166015037385.760108.16881097713975517242.stgit@omen>
 <033c2e8d-8ba9-3e0b-9dee-7d0973c708fa@nvidia.com>
 <20220828063759.60c85fd6.alex.williamson@redhat.com>
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <20220828063759.60c85fd6.alex.williamson@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RFdXR09DaDZadWRySTRkYVRVSy9EbUlXYjhCb2xyNmFPekJDRkM1eCsvV0xX?=
 =?utf-8?B?S3I5OHdhVFBQUWVxNkFJWE5UUnBjMmtrcmpKOG5ySTF2Y1NPd1FtU2R3QmJW?=
 =?utf-8?B?ZzErd01nK2owUzZnbEdjdzVlOEFHOVl6Y3VwSXZsaGFqcUQ5aUhmdm9mTWVw?=
 =?utf-8?B?OWVROWdMeTJDSGViT2l5N0hVV2Z6bWdyS0Ztai9PamswVkVicXVmM1ZuYXh5?=
 =?utf-8?B?NGNkNDRuNDBKeXhCcGlpY2RlQ0VPWHBzYm9QVnd0MmpCQ0JmWVhaN3dKN25t?=
 =?utf-8?B?UGV4b0lVdnpsVXE1ZGI0enVYQitaQ1dUTU1nRnh1dEdpaVQrWWMwUHlyaGJm?=
 =?utf-8?B?bkE4OVhQbGVoNHFva1M3NmlxTjh1RXluMGRWOUhQSVpYQjBuejR3ZXRZKzBr?=
 =?utf-8?B?TmtibFlsN0RKem00OG1KWmw1NUJrcVNvSWdFbmZJbFpDQ2JJRXV5SnJhUnhR?=
 =?utf-8?B?UFJLV3d4MTJXYkVLOEtDRnpvalBxOEcwSWRGZm9uVUVZT2J6MEgzNXJUMFR2?=
 =?utf-8?B?MnppR0xMNXZBblVsZHdBQW1NZDlteXdtcjljUlpMMW9qblZKUjVlcHlYSGkz?=
 =?utf-8?B?ZUNLbXRnMFpIcUNpYmdJYlhRMjJFcW9FeTIzSk9tZTVGSEtLZ09HQ3ErOHVJ?=
 =?utf-8?B?QnFDU0FuQ3VmeE93Z2Vqa1c1dmVsZDFFQmRrR0FBbHMwWmdNVGZjVzVYd3hV?=
 =?utf-8?B?Vjg2VHlEZTdmVFQ2STdmMHlUU29vMnlyY2VSZ256Wk80VDk5RDVSUGxUNjVv?=
 =?utf-8?B?czluSzhvRnhGZ1dNL0VIT3pHSjYxb09CcDdhb01sS2VubzgrNmpkTUd5RUNN?=
 =?utf-8?B?VytZVFcrQXVVTmhVd2lzdDJGSzhKLy9uUmJWU1lCR2xaQzFVbEIzQTFCVHox?=
 =?utf-8?B?b216L1FzaHlQTWw3TWFaZFhuRTRtbmczT2NvM3Rwc0lkYjRrczdVSkNJM1pO?=
 =?utf-8?B?cE5sVm4xSTdzRDlQNkU4TDNmLzd6ZDJYVEdxRjBxMTZVN204ZjZJNTlrS0k4?=
 =?utf-8?B?eVZXSzVLcE5INGk1MStrUVorOWlMWGxwa2g4ZC8veHI4QXZDN1JOZzBoaElF?=
 =?utf-8?B?R3JBSzczR0MvMExEQTM0dEU4Y2dsQ2RTK09xb0dHNVVLM1VEdmNvN2Q1RTNC?=
 =?utf-8?B?dnpOeEV1S1daSzlpVFZrbjRZeFkzQkZxd1phSUMva1dyZVh0RzBIUWcwYWx2?=
 =?utf-8?B?dHFRVDRJbUtPOWJheVhHSnRqdEppeUd6Kzk5VnhucmtLSGJOWFNFeEM2Y3NR?=
 =?utf-8?B?Ui9vK0wrMmt3TXVCRWM4RXJwNWRhVnljK3BSUUorVTVLMlJtaFZCRC8wbE5n?=
 =?utf-8?B?b1FjTXJKT2tWYmtGZG5mdmpUZ3A3Q3lsRWRWV3lTc2hBM0xxcmVydlY3RzRH?=
 =?utf-8?B?SDVVY21CbUlDTk9ZTmJGWUl4K0tLSlRCZG4wVmt6YmRYcHNDak5zMS9OZ2lx?=
 =?utf-8?B?S2pxb2NpVndUaUQ4VHNpZGZtaURIYTFoUkIwaUpJTWMyL2UvdytkRFFvd3FW?=
 =?utf-8?B?N012eTFoZmR3bU9OZ2YwbWhJU0kxNGpkNGIrcnp0NnoxM2kzcVhiRUhrdCtv?=
 =?utf-8?B?VW0wMFJUS0xSYlVCNjh6d1JzUmRKMll1TXFqQ0x5b0NjbTY2bkFNaXZmekhI?=
 =?utf-8?B?RzFzUTRvWmQ3cUM0REZyaVdLT01BRytFVHZKbEJDTnZnK21hSURaVmRuOHFU?=
 =?utf-8?B?K1N5NG8wcmpuMVV0M0EvRXZmRlpzdjJFSjk4aUdkaTU2Z1dOQStqVUtnL3V5?=
 =?utf-8?B?R29mcXdmSFpUYml2MzcvMHpPdC9ZdDQzdmdyelZsdzU4M3ZmUVdzV0RZRUpZ?=
 =?utf-8?B?VmJYMitjSzlWSVR6bXBKNCt5RWg4RzNmdGhlRnArT2loL2EwL2FERDFXcWZ4?=
 =?utf-8?B?M2ZGeUxjUkhNQ2lTVDYzV1E5K0pjcjR4ZzFSR09CME1zL1I2SWFtcWRheDA4?=
 =?utf-8?B?NXVicjI4ay9EZFJpaGtCdis3UWd1TzdwVmFpR2REUTB2TXMwNkpvaXE5TFpv?=
 =?utf-8?B?RnpLaDFIeEdteVQxZkR6MHBhQjdnS0l4NFRKYjIvcjlaQzU4RGlZS1c3c09v?=
 =?utf-8?B?OGJVbUdxZXZNSko0c1ZHajhtVnNjejZyUmZnZ0N4NVJYSDdFMHA3d25LZWl1?=
 =?utf-8?Q?AaHMosW9SyoMtEL18rVLGROEm?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eaefed65-f2ed-45a6-eff5-08da89191bfb
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2022 17:16:56.4435
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QVjwkaxym6COJ58v93HGqfcUsDRNE28NhWWTKJm4TvaKJoV8yx8elg4sn12XLgAGhh6DFYScsjLit9BXhMHxzw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB2493
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 8/28/22 05:37, Alex Williamson wrote:
>> Those notes are all about (some of) the callers. But it's a simple
>> answer, really, so how about just this:
>>
>> 	/* The zero page is always allowed to be pinned. */
> 
> Sure.  Are we looking for a re-spin with this?  I see Andrew already
> added this incremental change to his hotfix-unstable branch separately.
> I'd hate for a comment re-spin to delay getting a fix for this problem,
> that blocks any VM use cases of VFIO, into mainline any longer.  Thanks,
> 

Definitely not. Andrews fixup should suffice.


thanks,

-- 
John Hubbard
NVIDIA