Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Li Zhong <floridsleeves@gmail.com>
To:     linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Cc:     rafael@kernel.org, lenb@kernel.org, mario.limonciello@amd.com,
        hdegoede@redhat.com, Shyam-sundar.S-k@amd.com,
        mika.westerberg@linux.intel.com, nakato@nakato.io,
        lily <floridsleeves@gmail.com>
Subject: [PATCH v1] drivers/acpi/x86: check return null pointer from acpi_evaluate_dsm()
Date:   Sun, 28 Aug 2022 13:51:20 -0700
Message-Id: <20220828205120.1956222-1-floridsleeves@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

From: lily <floridsleeves@gmail.com>

Check return value from acpi_evaluate_dsm(). Only do ACPI_FREE() when
out_obj is not NULL pointers.

Signed-off-by: Li Zhong <floridsleeves@gmail.com>
---
 drivers/acpi/x86/s2idle.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/acpi/x86/s2idle.c b/drivers/acpi/x86/s2idle.c
index f9ac12b778e6..1b449d3cfbf7 100644
--- a/drivers/acpi/x86/s2idle.c
+++ b/drivers/acpi/x86/s2idle.c
@@ -328,7 +328,8 @@ static void acpi_sleep_run_lps0_dsm(unsigned int func, unsigned int func_mask, g
 
 	out_obj = acpi_evaluate_dsm(lps0_device_handle, &dsm_guid,
 					rev_id, func, NULL);
-	ACPI_FREE(out_obj);
+	if (!out_obj)
+		ACPI_FREE(out_obj);
 
 	acpi_handle_debug(lps0_device_handle, "_DSM function %u evaluation %s\n",
 			  func, out_obj ? "successful" : "failed");
-- 
2.25.1