Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c6ccbcac-c5b1-f460-01e2-e1b6684b6e65@linux.intel.com>
Date:   Sun, 28 Aug 2022 17:19:33 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [PATCH v11 1/3] x86/tdx: Add TDX Guest attestation interface
 driver
Content-Language: en-US
To:     Dave Hansen <dave.hansen@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
        Shuah Khan <shuah@kernel.org>
Cc:     "H . Peter Anvin" <hpa@zytor.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        Tony Luck <tony.luck@intel.com>,
        Andi Kleen <ak@linux.intel.com>,
        Kai Huang <kai.huang@intel.com>,
        Wander Lairson Costa <wander@redhat.com>,
        Isaku Yamahata <isaku.yamahata@gmail.com>,
        marcelo.cerri@canonical.com, tim.gardner@canonical.com,
        khalid.elmously@canonical.com, philip.cox@canonical.com,
        linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
        linux-doc@vger.kernel.org
References: <20220826150638.2397576-1-sathyanarayanan.kuppuswamy@linux.intel.com>
 <dcf53e6b-d60f-5d6b-029a-38df68d66302@intel.com>
From:   Sathyanarayanan Kuppuswamy 
        <sathyanarayanan.kuppuswamy@linux.intel.com>
In-Reply-To: <dcf53e6b-d60f-5d6b-029a-38df68d66302@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 8/28/22 1:14 PM, Dave Hansen wrote:
> On 8/26/22 08:06, Kuppuswamy Sathyanarayanan wrote:
>> +struct tdx_report_req {
>> +	__u8  subtype;
>> +	__u64 reportdata;
>> +	__u32 rpd_len;
>> +	__u64 tdreport;
>> +	__u32 tdr_len;
>> +};
> 
> Please do take a look at how the compiler ends up building that structure.
> 
> If you sized things to "save space", the way the compiler treats that
> structure may surprise you.  You might also want to look at how a 32-bit
> compile deals with it versus a 64-bit one.

Since it is only used in user/kernel ABI, I did not consider the size
issue. But I understand your point. The size of this struct in a 64-bit
system is 40 bytes. So we did not gain anything with using different member
sizes. In a 32-bit system, size due to padding is less compared to 64-bit.

I will re-arrange the struct as below. With this change, the size will come
down to 32 bytes.

struct tdx_report_req {
        __u64 reportdata;;
        __u64 tdreport;
        __u32 rpd_len
        __u32 tdr_len;
        __u8 subtype;
};


-- 
Sathyanarayanan Kuppuswamy
Linux Kernel Developer