Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp2736103rwe; Sun, 28 Aug 2022 21:31:30 -0700 (PDT) X-Google-Smtp-Source: AA6agR78mNX0fxFRq2YIe57qaUZI5ujZNbvoN+OD/bA3kDNXvFCVBQ0aLavMLvOySi/skKM0Ux61 X-Received: by 2002:a05:6402:538a:b0:43a:298e:bc2b with SMTP id ew10-20020a056402538a00b0043a298ebc2bmr14757768edb.125.1661747490206; Sun, 28 Aug 2022 21:31:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661747490; cv=none; d=google.com; s=arc-20160816; b=LL/bRpjDFj9kval5Dh9Uuq4JmGmtt1XAcHRcO0Ef3GrNRqPDzTAKMl5JiojiePgtYA qvyrFMtIocsXa5mH5ZCAgLUyowwg3ycXb1vELmMUxOlC0PGpRsTQEW2ZBmrmStT2gTYs 8vgyk3E9F9k8nyeNP/4gXkKidCi771lRKWoaW1kMMbLvD/r3MaB3fwHIyBuJd5c8upwE Pwmr5uRAEhyQJ2aNMB8IwCK745ypQ18JItE/Jh35Mk6uiLvV2X8DvQIQuCiix3muIr9u jKjjnit3dhXEa0aTUHdL0c8ld52erXov0G0X8FMn3HT09coMdIdUPDsF8qfWOSJ+z1Dd y8Lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=eQVsuwgc8uXKILvzGyvbWtTjg/syLvD78qexD18++Io=; b=VMmutWxS3llIz+hk45wz3/x2u8RKNj+JiKi1GAf/R5o/+GwAgZmgSigmC1XSZALZW6 XNoRjMkATdxA4zzbdm3znjukYDstgIow6oEUvMdzn/GcVlkxnu4xwubwWAtJJC2jYVzm HLqWFn/8eLpx/ASWj0o4/smz9id7yjTkiGlRygyFyCYpNXLmkn/4eEiKx+cXueVKk1xG HJ46aVKSnbYU0qWbaePoTuvv2JqqlxgyzyN4nI1uq31XOvh31VuYKLZ6A9HockMEEVqf 6Oq55TSWNckf1nlD+QHZkeua1edvxjLTVi7voTbjO0D03jB0Qdj1Wd8FrBW3ab0O193S Zq6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=PIRfcD3C; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id di5-20020a170906730500b0073d91a38b35si6142957ejc.789.2022.08.28.21.31.04; Sun, 28 Aug 2022 21:31:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=PIRfcD3C; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229566AbiH2EAd (ORCPT + 99 others); Mon, 29 Aug 2022 00:00:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229559AbiH2EA3 (ORCPT ); Mon, 29 Aug 2022 00:00:29 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1BD065D9 for ; Sun, 28 Aug 2022 21:00:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661745626; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=eQVsuwgc8uXKILvzGyvbWtTjg/syLvD78qexD18++Io=; b=PIRfcD3CHsVCDSBzRWxHcDU5vN1iyTwFwPyyVgkR398kTs3H6oPOmtSHeI+EQrgmsTHUQw Rp6x29lO/91CTUICEPzEaKilAsbtyXOccq6Kl4mDxhKl+HnUGKhw/K3WVFD4WS/+bRtB7G nd9RGJwTxR2YwK83nAVhnQGpkFdNsfg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-195-MGX3IdgNPZqK4dLJHzLY1A-1; Mon, 29 Aug 2022 00:00:21 -0400 X-MC-Unique: MGX3IdgNPZqK4dLJHzLY1A-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C4935185A7B2; Mon, 29 Aug 2022 04:00:20 +0000 (UTC) Received: from localhost (ovpn-8-18.pek2.redhat.com [10.72.8.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0001E1121314; Mon, 29 Aug 2022 04:00:19 +0000 (UTC) From: Ming Lei To: Jens Axboe Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Ming Lei , Christoph Hellwig Subject: [PATCH] kernel: export task_work_add Date: Mon, 29 Aug 2022 12:00:13 +0800 Message-Id: <20220829040013.549212-1-ming.lei@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Firstly task_work_add() is used in several drivers. In ublk driver's usage, request batching submission can only be applied with task_work_add, and usually get better IOPS. Secondly from this API's definition, the added work is always run in the task context, and when task is exiting, either the work is rejected to be added, or drained in do_exit(). In this way, not see obvious disadvantage or potential issue by exporting it for module's usage. So export it, then ublk driver can get simplified, meantime with better performance. Cc: Christoph Hellwig Signed-off-by: Ming Lei --- kernel/task_work.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/task_work.c b/kernel/task_work.c index dff75bcde151..5f9a42a388f1 100644 --- a/kernel/task_work.c +++ b/kernel/task_work.c @@ -73,6 +73,7 @@ int task_work_add(struct task_struct *task, struct callback_head *work, return 0; } +EXPORT_SYMBOL_GPL(task_work_add); /** * task_work_cancel_match - cancel a pending work added by task_work_add() -- 2.31.1