Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp2774269rwe; Sun, 28 Aug 2022 22:48:00 -0700 (PDT) X-Google-Smtp-Source: AA6agR5O9Ux6nxLLGx3WEHq9zZ+teadnLKbI5UweoJYud4VoGDLsmQIC1VoDWq/FRelkucd8U2SE X-Received: by 2002:a05:6402:27d3:b0:43e:5490:27ca with SMTP id c19-20020a05640227d300b0043e549027camr15596658ede.307.1661752079952; Sun, 28 Aug 2022 22:47:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661752079; cv=none; d=google.com; s=arc-20160816; b=cAdU1GK2T2bwLdFiSWgdUulO3REzb26nsI57eFmz4E3ndqDTMh90sw51eWfGeDf2CD feYobgnmSMB3Fx0odogCt7OaUETuPiqcOBUWbNQuqa2Z7tWFQHwEQytEm1mqbb4xmLt5 WRGArCsR0M5LSej1zLUL5jOOCyygB+94BG+tyFrnRkJiVlaMf3AWwOvFxGNm3ALkcvMG FWvBibegPhxKwqZNv/wRRO82zqjUcTTCG+EfubzBo4geQFvkxV5tyi0//hG92ivPYqOX VvjJWUUc9q/YzfM/fF7mIb/4SuwgjcGsaklFr2YLbt8XW9wrJgu2TqTApZzuFUH1K9R+ qGrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=TufmGBMzdjbryZzgkmvqQCryMrgc/SAHxff3fB5+xiI=; b=lS9d3LMl7PWnTub6XdiOU8vYA25fhnqjbQn2insT6L22OQqrpDEcHIRh8NfPGBrusN 1LIAZKF6KtjSzjlWLcrqs1Ff477fU5HvelJX32ErmZ4K5TQafX4Qut2qfJKv3bBZV5PT c7p4KmRSwsLrDlkIAMFCpA5/hKpFnO2eBzLYQ8qCyx7q14eLbZz52fNunS+aaEGcIkql oaTc9DbCx18TE6N7LadWap2vmf5U7tmig1mhN1rgAD46/mCKkecOhIjdkVSRM7nlvxBQ W9ABCoJGuIp6fiFT1zn5zSn4WrF//5GEd28/ILjGbqBE/dwUdb6Ty1ietrMQf+5gXCOW rfyQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=mnPOzLek; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d17-20020a056402517100b00447820ba16dsi5264136ede.434.2022.08.28.22.47.31; Sun, 28 Aug 2022 22:47:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=mnPOzLek; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229594AbiH2FNz (ORCPT + 99 others); Mon, 29 Aug 2022 01:13:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbiH2FNv (ORCPT ); Mon, 29 Aug 2022 01:13:51 -0400 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E963422F5; Sun, 28 Aug 2022 22:13:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661750030; x=1693286030; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=tfTTN8fVVmqUhF1jQjcmRJRxUTSzT6rPsDhYFizdeYE=; b=mnPOzLekELSKI91CFFZA86EJUW93Gt+m9E97YW5a0ghsasqi2eRJWJIZ abdmHscEd4/mBWFO26xhoVAwfksJGbuNzXt+FALlcJmACjFqvxK3Ibb9G Vt/ZArtxTb7v7aUeQj7cJheVbFPEFteTyE0jfIAvhrsfhl7c/kFuLHhLz 7blUfZ3j4SzVUxqLdh7Gjrzz/tjzwF4NxvR5sAsoTuzUl3S8qNeMoR2Qy ECaLJNK6STJCcrXYrFY3BSjuOfcXAQrOCGzq1p11afvZyRX7u6TQ1ISa0 P7qrou6TDomPTHon7rKQtTwIqq3wJckLuqzz6kF4a/doxRChB0UkUmk6R A==; X-IronPort-AV: E=McAfee;i="6500,9779,10453"; a="274558757" X-IronPort-AV: E=Sophos;i="5.93,271,1654585200"; d="scan'208";a="274558757" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Aug 2022 22:13:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,272,1654585200"; d="scan'208";a="939443235" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga005.fm.intel.com with ESMTP; 28 Aug 2022 22:13:32 -0700 Received: by black.fi.intel.com (Postfix, from userid 1001) id EC602AD; Mon, 29 Aug 2022 08:13:46 +0300 (EEST) Date: Mon, 29 Aug 2022 08:13:46 +0300 From: Mika Westerberg To: Li Zhong Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, rafael@kernel.org, lenb@kernel.org, mario.limonciello@amd.com, hdegoede@redhat.com, Shyam-sundar.S-k@amd.com, nakato@nakato.io Subject: Re: [PATCH v1] drivers/acpi/x86: check return null pointer from acpi_evaluate_dsm() Message-ID: References: <20220828205120.1956222-1-floridsleeves@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220828205120.1956222-1-floridsleeves@gmail.com> X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Sun, Aug 28, 2022 at 01:51:20PM -0700, Li Zhong wrote: > From: lily > > Check return value from acpi_evaluate_dsm(). Only do ACPI_FREE() when > out_obj is not NULL pointers. ACPI_FREE() expands to kfree() and that allows NULL pointers so I don't think this patch is necessary.