Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <732919ef-c8b8-159b-6f69-e95eea710680@amd.com>
Date:   Mon, 29 Aug 2022 07:58:10 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PTACH v3] drm/ast: add dmabuf/prime buffer sharing support
Content-Language: en-US
To:     oushixiong <oushixiong@kylinos.cn>,
        Dave Airlie <airlied@redhat.com>
Cc:     Thomas Zimmermann <tzimmermann@suse.de>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Sumit Semwal <sumit.semwal@linaro.org>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org
References: <20220827091030.496671-1-oushixiong@kylinos.cn>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20220827091030.496671-1-oushixiong@kylinos.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R1RCNlBvVGcydGRMNFRrdW1wV2RpLzZoZmMzRzc1VzN3YW9YRGVJMWlFVWVk?=
 =?utf-8?B?YkhJN1hNNUo5UW1JSmF1cnB3bXAyaVFTNmhUc004QlhUUHpqbmVIamdGOTBL?=
 =?utf-8?B?c3BldUNGZGFLT3RjNEN5ZmVvNUVnMVN5ZDZpeTR3ZUpmMFhjRmlPQ1BtOERk?=
 =?utf-8?B?ZWQyWTQ3UGthRHJwZUFBTUl4SER0NHNLMW02d2E3a25JVVV0d2YrRUhYdWhM?=
 =?utf-8?B?UEJFY2svbjZOZHVGRm5ackdzN2xkWGI4OXBkMjFiMWhRRHBzYnF6dVhjR2ZG?=
 =?utf-8?B?bEwra0MyR0tDRUVFSko0RE5NZ2xwcUlmV0oxQThFMWs0b0ZHdmE4S3hSZ0hz?=
 =?utf-8?B?TDIvcHFLQndQaTJLMzhac3JmQi9BaE5pMWQrMXJ4YnFLOWVOZG9YYlhQWDlt?=
 =?utf-8?B?eFphVitmK0xXaHQ1MVR3Q0srTW15ODF5Z3Vqbk5LK2oxVlk4eVZQbmQ2ZUc2?=
 =?utf-8?B?ZWZ6RjV6cnVNeVpXRVZrY0VUWk5zTEQ2d095cmM3ZVZNalNtR0xkaEZuaU9t?=
 =?utf-8?B?MU1rbUJlUmx5cXVURGtMRGZSQWZrYUx3SnNQZ2Vpa0lPRnk1WkhDaDJTRW9X?=
 =?utf-8?B?YWVCODRncWNNcUZGWWZUWEkrTW1VclFacXRib3EwWituQTBVRUxyTWdsY2hq?=
 =?utf-8?B?Q3Z0WnJKNVNNT0pCVEVNUTcraHl5WFZaZFdHNEZ3Nmd1TUFuOWZoeFdmWlov?=
 =?utf-8?B?K0pobEZRSXhqRDdTZHBINkpKRUZqdjRQOVRRTWw5cmJSS3B1MTNmS25UZHNv?=
 =?utf-8?B?M1hhdlg0Y3pMTTVRVFh3ZGtFSkF3WUYvQ2s1ZW83WVB2VktDS0pRY2YvbUVH?=
 =?utf-8?B?OHFRLzNOb1ZTOXhmRW9rcWk0bjJYbmJXaEk2ZEZZb0hTbGpydEM2SzUzMHBv?=
 =?utf-8?B?bHA5VEovdkIwRmVqR204cnp4NHdmNE1Ma1lsNHl6ZDhqN0h5WnE4NjV6bThp?=
 =?utf-8?B?TnVVUlpLUVRIdm1ISFpvaUs4eW1lVjVUd1lFZHhScGdnZDMxTHQ3QUJjZGx0?=
 =?utf-8?B?dkoxV1Y5dkFZNlBNRjB3UGcxek1CaDJ3cnN0cFdKdWI3aVJFb0JHNGk2OS9T?=
 =?utf-8?B?clhqNFRXcUlmK0hHKzdEL056eE5MaDJYYkRJa0ZDb2w2NTRqcm84dWR1UFYz?=
 =?utf-8?B?TXFKSUIzZkNHQnNiY1FjaDJra0NlRk5aV1k4eEN5VENPK09pL0FCc05GRE1C?=
 =?utf-8?B?M09UZDl4WGl6aFdDQjNwUTFjN3BnZ05Pd1NMUFYrRlhSZW1QbEZqWU9lVWlO?=
 =?utf-8?B?Y1JYODRnM1JUSWxXUnFNc3JoUlR1c2ZYZnlKRFJuOE9nZUw3MlI4TWFCTnVZ?=
 =?utf-8?B?WnpDWk5aUFhiNGxNdXZ1NzZQWTZxWkxzeXJLNlJxeTZ4RVUySFVoWW1NYml6?=
 =?utf-8?B?L3dzNUZMRlRJUSt1cWtvR2NzK3NtbjMvRnQ4Zm4vRlNSeEd2MVZiUXc5R3lX?=
 =?utf-8?B?anZpL3NKaXRLQm1Ua1RsbW1FUzRzMjN5dHJnUEhDcGtaa2xMRWFMU0FQQ2pW?=
 =?utf-8?B?czJPUTJZUGd6dDdsWXFUMnpGemdKb1UrT2tFZk94MnRoaC9jQjQ2cFRCOWFC?=
 =?utf-8?B?ZW81S1ZPQ3N3OEloRG9TbDhxNmM4dHdsOEJwcnBIVVl3cW15ckVlSDVhNHJP?=
 =?utf-8?B?eitpVXNSdE9jLzAwa21lYlVSSFJ2eUZVN1JNUGJyZUxYU2k2WjQyd213Wnlw?=
 =?utf-8?B?MWJNVmpNL0xCTHpkZ3UrU3hmY0I2K244c2FzVk1XRk41OGU1aUtNUytRVFRs?=
 =?utf-8?B?WS9laTNrVDdBU0RPbmpRQyt0SG5kWC9FTXNwOU9QdUZNdGZPZnY3K3FIdjZx?=
 =?utf-8?B?aW9NUUlZTTJ1b0dxeVFHU0VMSDlhRWNXdkZMbi9NRUZLeXpuOS9GRHZ1ZmV6?=
 =?utf-8?B?bm52REVwZDVueHl2UjZNWVN4am1sMXZCelJTS0RjaENISGFuR3NLQWVxMTVU?=
 =?utf-8?B?SmJmWlRkYWV6U0pxd2pXRytiVFJQSXlZMkJUMmh6d09MM2kvZ1hXbkF1YkYx?=
 =?utf-8?B?Yjc0UTNmM2g5NzYvaHczZUg2MWdwYVV0YmQ4a3R5Wmk1QWtaa2gvcWpaUDhz?=
 =?utf-8?B?RVFvSzJ1WjAvNWdjQ2pmNitPUi9WUWNkTXJnNktiQVFYS2VDdFNvcExXeWhN?=
 =?utf-8?Q?E6PCsW5EWZ8XS/00BcAqbhKm+?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fe909fb5-68ae-4e35-7210-08da898377f4
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2022 05:58:17.4919
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5HOF9GQB182lDeD7736crp7rMkHnxQAnLuqEFXrcBoLTvZoIVdichDhkPRB5t6Fd
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5301
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 27.08.22 um 11:10 schrieb oushixiong:
> This patch adds ast specific codes for DRM prime feature, this is to
> allow for offloading of rending in one direction and outputs in other.
>
> This patch is designed to solve the problem that the AST is not displayed
> when the server plug in a discrete graphics graphics card at the same time.
> We call the dirty callback function to copy the rendering results of the
> discrete graphics card to the ast side by dma-buf.
>
> v1->v2:
>    - Fix the comment.
> v2->v3:
>    - we remove the gem_prime_import_sg_table callback and use the gem_prime_import
>      callback, becuase it just map and access the buffer with the CPU. and do not
>      to pin the buffer.
>
> Signed-off-by: oushixiong <oushixiong@kylinos.cn>

Thomas should probably comment as well, I think at least the memcpy_toio 
usage can still be made cleaner.

But from the DMA-buf side I think that looks good now, feel free to add 
an Acked-by: Christian König <christian.koenig@amd.com>

Regards,
Christian.

> ---
>   drivers/gpu/drm/ast/ast_drv.c  |  27 +++++++
>   drivers/gpu/drm/ast/ast_mode.c | 125 ++++++++++++++++++++++++++++++++-
>   2 files changed, 151 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/ast/ast_drv.c b/drivers/gpu/drm/ast/ast_drv.c
> index 7465c4f0156a..107383a56ca7 100644
> --- a/drivers/gpu/drm/ast/ast_drv.c
> +++ b/drivers/gpu/drm/ast/ast_drv.c
> @@ -28,6 +28,7 @@
>   
>   #include <linux/module.h>
>   #include <linux/pci.h>
> +#include <linux/dma-buf.h>
>   
>   #include <drm/drm_aperture.h>
>   #include <drm/drm_atomic_helper.h>
> @@ -50,6 +51,29 @@ module_param_named(modeset, ast_modeset, int, 0400);
>   
>   DEFINE_DRM_GEM_FOPS(ast_fops);
>   
> +struct drm_gem_object *ast_gem_prime_import(struct drm_device *dev,
> +						struct dma_buf *dma_buf)
> +{
> +	struct drm_gem_vram_object *gbo;
> +
> +	gbo = drm_gem_vram_of_gem(dma_buf->priv);
> +	if (gbo->bo.base.dev == dev) {
> +		/*
> +		* Importing dmabuf exported from out own gem increases
> +		* refcount on gem itself instead of f_count of dmabuf.
> +		*/
> +		drm_gem_object_get(&gbo->bo.base);
> +		return &gbo->bo.base;
> +	}
> +
> +	gbo = drm_gem_vram_create(dev, dma_buf->size, 0);
> +	if (IS_ERR(gbo))
> +		return NULL;
> +
> +	get_dma_buf(dma_buf);
> +	return &gbo->bo.base;
> +}
> +
>   static const struct drm_driver ast_driver = {
>   	.driver_features = DRIVER_ATOMIC |
>   			   DRIVER_GEM |
> @@ -63,6 +87,9 @@ static const struct drm_driver ast_driver = {
>   	.minor = DRIVER_MINOR,
>   	.patchlevel = DRIVER_PATCHLEVEL,
>   
> +	.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> +	.gem_prime_import = ast_gem_prime_import,
> +
>   	DRM_GEM_VRAM_DRIVER
>   };
>   
> diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c
> index 45b56b39ad47..65a4342c5622 100644
> --- a/drivers/gpu/drm/ast/ast_mode.c
> +++ b/drivers/gpu/drm/ast/ast_mode.c
> @@ -48,6 +48,8 @@
>   #include "ast_drv.h"
>   #include "ast_tables.h"
>   
> +MODULE_IMPORT_NS(DMA_BUF);
> +
>   static inline void ast_load_palette_index(struct ast_private *ast,
>   				     u8 index, u8 red, u8 green,
>   				     u8 blue)
> @@ -1535,8 +1537,129 @@ static const struct drm_mode_config_helper_funcs ast_mode_config_helper_funcs =
>   	.atomic_commit_tail = drm_atomic_helper_commit_tail_rpm,
>   };
>   
> +static int ast_handle_damage(struct drm_framebuffer *fb, int x, int y,
> +					int width, int height)
> +{
> +	struct drm_gem_vram_object *dst_bo = NULL;
> +	void *dst = NULL;
> +	int ret = 0, i;
> +	unsigned long offset = 0;
> +	bool unmap = false;
> +	unsigned int bytesPerPixel;
> +	struct iosys_map map;
> +	struct iosys_map dmabuf_map;
> +
> +	bytesPerPixel = fb->format->cpp[0];
> +
> +	if (!fb->obj[0]->dma_buf)
> +		return -EINVAL;
> +
> +	if (!fb->obj[0]->dma_buf->vmap_ptr.vaddr) {
> +		ret = dma_buf_vmap(fb->obj[0]->dma_buf, &dmabuf_map);
> +		if (ret)
> +			return ret;
> +	} else
> +		dmabuf_map.vaddr = fb->obj[0]->dma_buf->vmap_ptr.vaddr;
> +
> +	dst_bo = drm_gem_vram_of_gem(fb->obj[0]);
> +
> +	ret = drm_gem_vram_pin(dst_bo, 0);
> +	if (ret) {
> +		DRM_ERROR("ast_bo_pin failed\n");
> +		return ret;
> +	}
> +
> +	if (!dst_bo->map.vaddr) {
> +		ret = drm_gem_vram_vmap(dst_bo, &map);
> +		if (ret) {
> +			drm_gem_vram_unpin(dst_bo);
> +			DRM_ERROR("failed to vmap fbcon\n");
> +			return ret;
> +		}
> +		unmap = true;
> +	}
> +	dst = dst_bo->map.vaddr;
> +
> +	for (i = y; i < y + height; i++) {
> +		offset = i * fb->pitches[0] + (x * bytesPerPixel);
> +		memcpy_toio(dst + offset, dmabuf_map.vaddr + offset,
> +			width * bytesPerPixel);
> +	}
> +
> +	if (unmap)
> +		drm_gem_vram_vunmap(dst_bo, &map);
> +
> +	drm_gem_vram_unpin(dst_bo);
> +
> +	return 0;
> +}
> +
> +
> +static int ast_user_framebuffer_dirty(struct drm_framebuffer *fb,
> +				struct drm_file *file,
> +				unsigned int flags,
> +				unsigned int color,
> +				struct drm_clip_rect *clips,
> +				unsigned int num_clips)
> +{
> +	int i, ret = 0;
> +
> +	drm_modeset_lock_all(fb->dev);
> +	if (fb->obj[0]->dma_buf) {
> +		ret = dma_buf_begin_cpu_access(fb->obj[0]->dma_buf,
> +				DMA_FROM_DEVICE);
> +		if (ret)
> +			goto unlock;
> +	}
> +
> +	for (i = 0; i < num_clips; i++) {
> +		ret = ast_handle_damage(fb, clips[i].x1, clips[i].y1,
> +				clips[i].x2 - clips[i].x1, clips[i].y2 - clips[i].y1);
> +		if (ret)
> +			break;
> +	}
> +
> +	if (fb->obj[0]->dma_buf) {
> +		dma_buf_end_cpu_access(fb->obj[0]->dma_buf,
> +				DMA_FROM_DEVICE);
> +	}
> +
> +unlock:
> +	drm_modeset_unlock_all(fb->dev);
> +
> +	return ret;
> +}
> +
> +static void ast_user_framebuffer_destroy(struct drm_framebuffer *fb)
> +{
> +	struct iosys_map dmabuf_map;
> +
> +	if (fb->obj[0]->dma_buf) {
> +		dmabuf_map.is_iomem = fb->obj[0]->dma_buf->vmap_ptr.is_iomem;
> +		dmabuf_map.vaddr = fb->obj[0]->dma_buf->vmap_ptr.vaddr;
> +		if (dmabuf_map.vaddr)
> +			dma_buf_vunmap(fb->obj[0]->dma_buf, &dmabuf_map);
> +	}
> +
> +	drm_gem_fb_destroy(fb);
> +}
> +
> +static const struct drm_framebuffer_funcs ast_gem_fb_funcs_dirtyfb = {
> +	.destroy	= ast_user_framebuffer_destroy,
> +	.create_handle	= drm_gem_fb_create_handle,
> +	.dirty		= ast_user_framebuffer_dirty,
> +};
> +
> +static struct drm_framebuffer *
> +ast_gem_fb_create_with_dirty(struct drm_device *dev, struct drm_file *file,
> +				const struct drm_mode_fb_cmd2 *mode_cmd)
> +{
> +	return drm_gem_fb_create_with_funcs(dev, file, mode_cmd,
> +					&ast_gem_fb_funcs_dirtyfb);
> +}
> +
>   static const struct drm_mode_config_funcs ast_mode_config_funcs = {
> -	.fb_create = drm_gem_fb_create,
> +	.fb_create = ast_gem_fb_create_with_dirty,
>   	.mode_valid = drm_vram_helper_mode_valid,
>   	.atomic_check = drm_atomic_helper_check,
>   	.atomic_commit = drm_atomic_helper_commit,