Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220825114018.1715-1-xuewen.yan@unisoc.com>
In-Reply-To: <20220825114018.1715-1-xuewen.yan@unisoc.com>
From:   Xuewen Yan <xuewen.yan94@gmail.com>
Date:   Mon, 29 Aug 2022 14:28:41 +0800
Message-ID: <CAB8ipk-su6DRo0DsgaY38Vf2AuxBuvG0GQ0xA22se7Wx5eH0Pg@mail.gmail.com>
Subject: Re: [PATCH] thermal: Check the policy first in cpufreq_cooling_register
To:     Xuewen Yan <xuewen.yan@unisoc.com>
Cc:     viresh.kumar@linaro.org, lukasz.luba@arm.com,
        amit.kachhap@gmail.com, daniel.lezcano@linaro.org,
        rafael@kernel.org, amitk@kernel.org, rui.zhang@intel.com,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        di.shen@unisoc.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi all,

Any comments?

On Thu, Aug 25, 2022 at 7:42 PM Xuewen Yan <xuewen.yan@unisoc.com> wrote:
>
> Since the policy needs to be accessed first when obtaining cpu devices,
> first check whether the policy is legal before this.
>
> Signed-off-by: Xuewen Yan <xuewen.yan@unisoc.com>
> ---
>  drivers/thermal/cpufreq_cooling.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/thermal/cpufreq_cooling.c b/drivers/thermal/cpufreq_cooling.c
> index b76293cc989c..7838b6e2dba5 100644
> --- a/drivers/thermal/cpufreq_cooling.c
> +++ b/drivers/thermal/cpufreq_cooling.c
> @@ -501,17 +501,17 @@ __cpufreq_cooling_register(struct device_node *np,
>         struct thermal_cooling_device_ops *cooling_ops;
>         char *name;
>
> +       if (IS_ERR_OR_NULL(policy)) {
> +               pr_err("%s: cpufreq policy isn't valid: %p\n", __func__, policy);
> +               return ERR_PTR(-EINVAL);
> +       }
> +
>         dev = get_cpu_device(policy->cpu);
>         if (unlikely(!dev)) {
>                 pr_warn("No cpu device for cpu %d\n", policy->cpu);
>                 return ERR_PTR(-ENODEV);
>         }
>
> -       if (IS_ERR_OR_NULL(policy)) {
> -               pr_err("%s: cpufreq policy isn't valid: %p\n", __func__, policy);
> -               return ERR_PTR(-EINVAL);
> -       }
> -
>         i = cpufreq_table_count_valid_entries(policy);
>         if (!i) {
>                 pr_debug("%s: CPUFreq table not found or has no valid entries\n",
> --
> 2.25.1
>

THanks!