Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp2816220rwe; Mon, 29 Aug 2022 00:05:05 -0700 (PDT) X-Google-Smtp-Source: AA6agR5LiNj3mMKpN+8977/WulfCfguRZMmcWL+fV7dsGU30SXrWrtN2bWt2DC9gzaEVPH/Q8F72 X-Received: by 2002:a17:902:bd49:b0:172:df88:8981 with SMTP id b9-20020a170902bd4900b00172df888981mr15206880plx.120.1661756704838; Mon, 29 Aug 2022 00:05:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661756704; cv=none; d=google.com; s=arc-20160816; b=PtDoBNJIM2XwPNGkgp6cMXCFIowSaHxcPJM8e2fgbvcRvYNn73nyhNcwodtptSdSPl 4aJxQmZpJigKsaQOlLHvRMMGDO2RHdDfw8baQ9v7XC8dV+naWANGZW1EQ+7lPolmGdki DaSwyi4kuARSsHmoy9wReIwES4VT17MPaiSeZQO/aFStqpKrlRFf0TQJQqYroE/2Cp3r D+ygdSKIzILidnjvXwU517iirGKfN2ISQ/hOxq7oGx0RoVT/0XfIxl/Ji/FBWxOJmKOS hSNimZkm57X9SuiIr+c5gby04NfeFBMtoZhaUbPQeu9FIxLVU6fSmBfHmWtIcumiJK0Z Owig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :content-language:references:cc:to:subject:from:user-agent :mime-version:date:message-id; bh=EJ5RS/AXlxYGDfI1KGrJxqXOusIBjaro7/7+u7BXOaU=; b=V5YH6eEBGlSdTISbJ0nH6O6Xyiq7wY0XHZO/oeGbF2BaJnJ+Hiip7jwpg+HFVMWsrO kLRcy/huvIKgLwpXQ+Mn+f+4ZwdmWmCWGOfdSYBvn5FZcagUMH9MgMSMd/TrlPUKv2db pNRvmN5BH+oKTd2EtoCGZGWeO3GOM8dbjIpuF6f54KNfqVoihK5r3uI7KFBjMNGJfP7z ojC/y77VPNHFuZwhC+2z249oc8ZaCKN03FqWwzqYAmnx9c1pfNK0diZUNZxW6WWpoPYr PDzVshU5Xekikxu7r0XuVq1d8EoOSpO5MeYxKCsiEaTePX8uX87EJViu7f09Qo/yo9vO K0dg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id jb15-20020a170903258f00b001714853e501si7882554plb.76.2022.08.29.00.04.53; Mon, 29 Aug 2022 00:05:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229813AbiH2Gd5 (ORCPT + 99 others); Mon, 29 Aug 2022 02:33:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229593AbiH2Gdz (ORCPT ); Mon, 29 Aug 2022 02:33:55 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88A462E9DE for ; Sun, 28 Aug 2022 23:33:54 -0700 (PDT) Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1oSYL8-0003TH-DC; Mon, 29 Aug 2022 08:33:42 +0200 Message-ID: Date: Mon, 29 Aug 2022 08:33:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 From: Ahmad Fatoum Subject: Re: [PATCH v1 0/2] Fix the wrong order of phy callbacks To: Richard Zhu , l.stach@pengutronix.de, bhelgaas@google.com, lorenzo.pieralisi@arm.com, vkoul@kernel.org, marcel.ziswiler@toradex.com, kishon@ti.com Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org References: <1661173856-1192-1-git-send-email-hongxing.zhu@nxp.com> Content-Language: en-US In-Reply-To: <1661173856-1192-1-git-send-email-hongxing.zhu@nxp.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:900:1d::77 X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 22.08.22 15:10, Richard Zhu wrote: > Refer [1], phy_init() must be called before phy_power_on(). > This series used to fix the wrong order of the phy_init() and phy_power_on(), > introduced by commit 1aa97b002258 ("phy: freescale: pcie: Initialize the imx8 pcie standalone phy driver") > Tested on i.MX8MM EVK board when one NVME device is used. > > [1]https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/phy/phy-core.c?id=v5.19-rc1#n233 > > [PATCH v1 1/2] PCI: imx6: Fix the wrong order of phy_init() and > [PATCH v1 2/2] phy: freescale: imx8m-pcie: Fix the wrong order of This introduces an intermittent breakage. Can you squash? > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |